Reviewers: jgw,
Message:
Review requested.
Description:
XMLHttpRequest.clearOnReadyStateChange() uses the wrong this object
and doesn't actually clear the handler.
http://code.google.com/p/google-web-toolkit/issues/detail?id=4133
Please review this at http://gwt-code-reviews.appspot.com/100813
-In Prod Mode
Error 500 The call failed on the server; see server log for details
StatusCodeException (this exception should be InvocationException, right?)
That's a bug. It shouldn't be returning a 500 status code. Please file a bug.
--
Bob Vawter
Google Web Toolkit Team
--
Revision: 6905
Author: tamplinjohn
Date: Mon Nov 16 07:06:05 2009
Log: Edited wiki page through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=6905
Modified:
/wiki/UsingOOPHM.wiki
===
--- /wiki/UsingOOPHM.wiki Wed Nov
Revision: 6906
Author: jlaba...@google.com
Date: Mon Nov 16 07:56:07 2009
Log: tr...@6895 was merged into this branch
Updating the Gwt Developer Plugin for IE to use the latest terminology
svn merge --ignore-ancestry -c6895
http://google-web-toolkit.googlecode.com/svn/trunk/ .
Patch
Comment by alex.dob...@gmail.com:
I'd like to use a Css file from which I'm not using ALL the stylesnames
initially. However, I've noticed the generated CssResource does not include
unused stylenames. Is there a way to solve this solution (somewhere in the
code to use addStyleName) ?
For
Revision: 6908
Author: jlaba...@google.com
Date: Mon Nov 16 08:25:35 2009
Log: tr...@6907 was merged into this branch
Add registry keys to IE plugin installer
svn merge --ignore-ancestry -c6907
http://google-web-toolkit.googlecode.com/svn/trunk/ .
Patch by: jlabanca
Revision: 6909
Author: j...@google.com
Date: Mon Nov 16 08:32:42 2009
Log: Work around JSNI uses of JSOs as maps on Chrome in DevMode (where the
plugin
adds __gwt_ObjectId to any JS object passed to Java to preserve object
identity). We fix it by overriding Object.prototype.hasOwnProperty and
Revision: 6910
Author: j...@google.com
Date: Mon Nov 16 08:35:40 2009
Log: Merge trunk r6909 into this branch
Fixes JSNI uses of JSOs as maps in Chrome DevMode.
svn merge --ignore-ancestry -c6909 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
Lex, can you take this? I think Joel is on the road.
http://gwt-code-reviews.appspot.com/102818
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Sure thing, looking now.
And here I'd hoped never to have to think too much about XML namespaces.
http://gwt-code-reviews.appspot.com/102818
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 6912
Author: sco...@google.com
Date: Mon Nov 16 09:48:58 2009
Log: Restore behavior where hosted mode linking will not overwrite a newer
compiled selection script.
And generally, older resources won't overwrite newer ones.
Review by: spoon (desk)
LGTM.
http://gwt-code-reviews.appspot.com/102818
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 6913
Author: rj...@google.com
Date: Mon Nov 16 10:04:26 2009
Log: AttributeParsing was pretty much working by accident, and not at all
for the
deprecated urn:with mechanism. I'm not 100% certain there weren't
non-deprecated
paths that were broken too.
Attribute parsing is still too
Thanks for the patch :).
I have been planning on updating the sample for some time now but just never
got around to doing it.
In addition to porting it to use ClientBundle, I was planning on adding
appcache support and implementing an offline mode. Maybe ill block off an
afternoon and finish
Revision: 6914
Author: sco...@google.com
Date: Mon Nov 16 10:54:36 2009
Log: tr...@6911 was merged into this branch
gwt-user should not reference the dev collections, this causes server
failures.
svn merge --ignore-ancestry -c6911
https://google-web-toolkit.googlecode.com/svn/trunk/ .
tr...@6913
http://gwt-code-reviews.appspot.com/102818
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Comment by mark.renouf:
This patch will make GAE/Eclipse happy for now, seems to work with no side
effects. Patch and build with 'ant dist-dev'.
Index: dev/core/src/com/google/gwt/dev/DevModeBase.java
===
---
Comment by mark.renouf:
This patch will make GAE/Eclipse happy for now, seems to work with no side
effects. Patch and build with 'ant dist-dev'.
{{{
Index: dev/core/src/com/google/gwt/dev/DevModeBase.java
===
---
Revision: 6915
Author: rj...@google.com
Date: Mon Nov 16 11:27:22 2009
Log: Merges tr...@6913 into releases/2.0
UiBinder attribute parsing was pretty much working by accident
svn merge --ignore-ancestry -c 6913
https://google-web-toolkit.googlecode.com/svn/trunk .
releases/2...@6915
http://gwt-code-reviews.appspot.com/102818
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 6916
Author: sco...@google.com
Date: Mon Nov 16 11:29:17 2009
Log: SOYC artifacts should be private.
Review by: spoon
http://code.google.com/p/google-web-toolkit/source/detail?r=6916
Modified:
/trunk/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
Revision: 6917
Author: sco...@google.com
Date: Mon Nov 16 11:37:20 2009
Log: Fixes a race condition creating StandardGeneratorContext's diskCache.
Review by: bob (virtual)
http://code.google.com/p/google-web-toolkit/source/detail?r=6917
Modified:
Reviewers: jat,
Description:
From external GWT issue 4216:
-
System.out.println(DateTimeFormat.getFormat(SS).format(new
Date(-631151998945))) displays 0-93 instead of the expected 05 or
06.
That time is 1.055 seconds after midnight January 1, 1950.
-
Please review this at
Revision: 6918
Author: sco...@google.com
Date: Mon Nov 16 11:37:29 2009
Log: Remove unused method from ModuleSpace.
Review by: jat (desk)
http://code.google.com/p/google-web-toolkit/source/detail?r=6918
Modified:
/trunk/dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java
Revision: 6919
Author: sco...@google.com
Date: Mon Nov 16 11:37:40 2009
Log: Fixes workDir directory contention between multiple concurrent hosted
mode sessions.
- each StandardLinkerContext gets a unique directory in the workDir
- each session gets its own linker stack
- outputing files into
Revision: 6920
Author: sco...@google.com
Date: Mon Nov 16 11:48:59 2009
Log: trunk c6917-c6919 were merged into this branch
Fixes a race condition creating StandardGeneratorContext's diskCache.
Remove unused method from ModuleSpace.
Fixes workDir directory contention between multiple
http://gwt-code-reviews.appspot.com/102819/diff/1/7#newcode80
Line 80:
On 2009/11/16 19:51:53, amitmanjhi wrote:
use ConcurrentHashMap? Can avoid the lock.
I don't believe so, as you have to hold the lock across
containsKey/get/put.
Wouldn't putIfAbsent(..) work?
--
LGTM
http://gwt-code-reviews.appspot.com/100813
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 6921
Author: b...@google.com
Date: Mon Nov 16 12:30:06 2009
Log: Fix memory leak in XMLHttpRequest.clearOnReadyStateChange().
Resolves http://code.google.com/p/google-web-toolkit/issues/detail?id=4133
Patch by: bobv
Review by: rjrjr
Reported by: lyle.sitzman
Revision: 6923
Author: jlaba...@google.com
Date: Mon Nov 16 12:53:32 2009
Log: Fixes a regex expression in RunStyleSelenium to allow users to specify
the path.
Patch by: jlabanca
Review by: fabbott
http://code.google.com/p/google-web-toolkit/source/detail?r=6923
Added:
Revision: 6925
Author: jlaba...@google.com
Date: Mon Nov 16 12:57:41 2009
Log: tr...@6923 were merged into this branch
Allows path to executable in RunStyleSelenium.
svn merge --ignore-ancestry -c6923
https://google-web-toolkit.googlecode.com/svn/trunk .
Patch by: jlabanca
Reviewers: jasonparekh1,
Message:
Jason, can you take this?
Description:
Fixes bad code gen when css class names in a ui:style block have dashes
in them, by adoptiung a convention that {foo.bar-baz} == {foo.barBaz}.
Please review this at http://gwt-code-reviews.appspot.com/100815
Affected
On Mon, Nov 16, 2009 at 3:10 PM, Amit Manjhi amitman...@google.com wrote:
use ConcurrentHashMap? Can avoid the lock.
I don't believe so, as you have to hold the lock across
containsKey/get/put.
Wouldn't putIfAbsent(..) work?
Since gets never block, it seems like this can't be used to
LGTM
On Mon, Nov 16, 2009 at 1:19 PM, John Tamplin j...@google.com wrote:
On Mon, Nov 16, 2009 at 3:10 PM, Amit Manjhi amitman...@google.comwrote:
use ConcurrentHashMap? Can avoid the lock.
I don't believe so, as you have to hold the lock across
containsKey/get/put.
Wouldn't
Comment by rj...@google.com:
@alex.dobjanschi, that's not an accident. It sounds like you want to create
your own CssResource and pass it into your template via ui:with
For more information:
http://code.google.com/p/google-web-toolkit/wiki/UiBinder
--
Revision: 6928
Author: rj...@google.com
Date: Mon Nov 16 13:42:23 2009
Log: Fixes typos noticed by Keith Rogers. Thanks, Keith.
http://code.google.com/p/google-web-toolkit/source/detail?r=6928
Modified:
/wiki/UiBinder.wiki
===
--- /wiki/UiBinder.wiki Mon Nov
Comment by rj...@google.com:
@keith.rogers79 Fixed, thanks.
For more information:
http://code.google.com/p/google-web-toolkit/wiki/UiBinder
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Comment by rj...@google.com:
@alex.dobjanschi, you might find
com.google.gwt.resources.css.InterfaceGenerator handy.
For more information:
http://code.google.com/p/google-web-toolkit/wiki/UiBinder
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Committed to trunk at r6926, releases/2.0 at r6927.
http://gwt-code-reviews.appspot.com/102819
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 6929
Author: r...@google.com
Date: Mon Nov 16 13:52:38 2009
Log: Fix formatting of milliseconds in pre-1970 (i.e., negative) dates
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=6929
Modified:
Revision: 6930
Author: amitman...@google.com
Date: Mon Nov 16 14:42:51 2009
Log: Patch to update the generated README.txt, created when using the
webAppCreator
script
Suggestion by: bruce
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Looks like this covers issue 4052, no?
- Amir
On Mon, Nov 16, 2009 at 1:15 PM, rj...@google.com wrote:
Reviewers: jasonparekh1,
Message:
Jason, can you take this?
Description:
Fixes bad code gen when css class names in a ui:style block have dashes
in them, by adoptiung a convention that
Yup, thanks. And 4053?
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 6931
Author: amitman...@google.com
Date: Mon Nov 16 14:53:46 2009
Log: Merge tr...@6930 into this branch.
svn merge --ignore-ancestry -c6930
https://google-web-toolkit.googlecode.com/svn/trunk/ .
Patch by: amitmanjhi
http://code.google.com/p/google-web-toolkit/source/detail?r=6931
I haven't looked at the patch, but it sure sounds like it!
On Mon, Nov 16, 2009 at 2:52 PM, Ray Ryan rj...@google.com wrote:
Yup, thanks. And 4053?
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 6932
Author: rj...@google.com
Date: Mon Nov 16 15:06:51 2009
Log: Fixes bad code gen when css class names in a ui:style block have
dashes in them,
by adopting a convention that {foo.bar-baz} == {foo.barBaz}.
Addresses issue 4052, issue 4053
Review by jasonparekh
tr...@6932. Holding off on releases/2.0 until RC1 is out of the way.
http://gwt-code-reviews.appspot.com/100815
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 6933
Author: j...@google.com
Date: Mon Nov 16 15:15:53 2009
Log: Update MissingPlugin app to final Safari URL, remove Snow Leopard
sniffing
since the regular Safari disk image now works, update legacy HTML page (for
people running from older GWT builds) to just point to the
Revision: 6934
Author: j...@google.com
Date: Mon Nov 16 15:49:37 2009
Log: Merge trunk r6933 into this branch
Update MissingPlugin app and associated legacy HTML page.
svn merge --ignore-ancestry -c6933 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
Revision: 6936
Author: j...@google.com
Date: Mon Nov 16 16:00:09 2009
Log: Merge trunk r6935 into this branch
Fix JSONObject with Chrome DevMode.
svn merge --ignore-ancestry -c6935 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
Revision: 6937
Author: br...@google.com
Date: Mon Nov 16 17:08:00 2009
Log: Updates the help hyperlink to point to the forum. Removes the shadow
style which was creating annoying horz scrollbars. Replaces tabs with
spaces in ui.xml.
Change by: bruce
Review by: jat (desk)
Revision: 6939
Author: j...@google.com
Date: Mon Nov 16 17:14:30 2009
Log: Update version number in MissingPlugin app.
Patch by: jat
Review by: bruce (verbal)
http://code.google.com/p/google-web-toolkit/source/detail?r=6939
Modified:
/trunk/plugins/MissingPlugin/war/WEB-INF/appengine-web.xml
Revision: 6938
Author: jlaba...@google.com
Date: Mon Nov 16 17:08:41 2009
Log: Updating IE installer to use HKCU and major.minor.patch.build syntax.
Patch by: jlabanca
Review by: cramsdale
http://code.google.com/p/google-web-toolkit/source/detail?r=6938
Modified:
Revision: 6940
Author: br...@google.com
Date: Mon Nov 16 17:17:36 2009
Log: MissingPlugin tweaks via svn merge -c6937 --ignore-ancestry
http://google-web-toolkit.googlecode.com/svn/trunk/ .
http://code.google.com/p/google-web-toolkit/source/detail?r=6940
Modified:
Revision: 6941
Author: j...@google.com
Date: Mon Nov 16 17:21:38 2009
Log: Merge trunk r6939 into this branch
Update MissingPlugin app version.
svn merge --ignore-ancestry -c6939 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
Revision: 6942
Author: jlaba...@google.com
Date: Mon Nov 16 18:48:07 2009
Log: Reverting r6935 because it breaks firefox tests in web mode.
Patch by: jlabanca
http://code.google.com/p/google-web-toolkit/source/detail?r=6942
Modified:
/trunk/user/src/com/google/gwt/json/client/JSONObject.java
Revision: 6944
Author: sco...@google.com
Date: Mon Nov 16 18:58:22 2009
Log: Cleanup of CompileStrategy which no longer cares about RunStyle at all.
Review by: jlabanca (desk)
http://code.google.com/p/google-web-toolkit/source/detail?r=6944
Modified:
Revision: 6946
Author: jlaba...@google.com
Date: Mon Nov 16 18:58:42 2009
Log: Reverting r6936 because it causes FF tests to fail.
Patch by: jlabanca
http://code.google.com/p/google-web-toolkit/source/detail?r=6946
Modified:
/releases/2.0/branch-info.txt
Revision: 6947
Author: sco...@google.com
Date: Mon Nov 16 18:58:49 2009
Log: JUnitShell should never refresh modules; it's not necesary and can
lead to race conditions.
Review by: jlabanca (desk)
http://code.google.com/p/google-web-toolkit/source/detail?r=6947
Modified:
Revision: 6948
Author: sco...@google.com
Date: Mon Nov 16 18:58:59 2009
Log: Cleanup of ModuleDef loading.
- Script.getJsReadyFunction() is never called.
- Removed code to parse JS ready functions; it was throwing an error for me
in some cases.
- Removed ObjAttrCvt which is no longer used for
Revision: 6949
Author: sco...@google.com
Date: Mon Nov 16 18:59:09 2009
Log: GWTShell now reuses dev mode linking code to populate its generated
resources directory.
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=6949
Modified:
Revision: 6950
Author: br...@google.com
Date: Mon Nov 16 19:02:31 2009
Log: Getting started notes
http://code.google.com/p/google-web-toolkit/source/detail?r=6950
Added:
/wiki/GWT_2_0_RC.wiki
===
--- /dev/null
+++ /wiki/GWT_2_0_RC.wiki Mon Nov 16
Revision: 6954
Author: br...@google.com
Date: Mon Nov 16 19:44:49 2009
Log: Added getting started instructions
http://code.google.com/p/google-web-toolkit/source/detail?r=6954
Modified:
/wiki/GWT_2_0_RC.wiki
===
--- /wiki/GWT_2_0_RC.wiki Mon Nov 16
Revision: 6955
Author: br...@google.com
Date: Mon Nov 16 19:48:40 2009
Log: Unprettyprinted
http://code.google.com/p/google-web-toolkit/source/detail?r=6955
Modified:
/wiki/GWT_2_0_RC.wiki
===
--- /wiki/GWT_2_0_RC.wiki Mon Nov 16 19:44:49 2009
+++
Comment by srdrucker:
Please add information about using with the Eclipse plug-in.
For more information:
http://code.google.com/p/google-web-toolkit/wiki/GWT_2_0_RC
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
65 matches
Mail list logo
