[gwt-contrib] [google-web-toolkit] r7527 committed - Bring back UiBinderUtilTest after fixing IE6 failure in...

2010-02-03 Thread codesite-noreply
Revision: 7527 Author: rj...@google.com Date: Wed Feb 3 14:30:31 2010 Log: Bring back UiBinderUtilTest after fixing IE6 failure in testDetach. Was checking for null parentNode instead of parentElement, and on ie6 you still have the former after the latter dumps you. Test was rolled back in svn t

[gwt-contrib] Re: Comment on LightweightCollections in google-web-toolkit

2010-02-03 Thread codesite-noreply
Comment by spoon.reloaded: The declaration for printEach() should be simplified to: `public void printEach(Array arrToPrint) {` For more information: http://code.google.com/p/google-web-toolkit/wiki/LightweightCollections -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r7526 committed - Adds explicit pure Java test support to GWTTestCase, via a setter....

2010-02-03 Thread codesite-noreply
Revision: 7526 Author: guillaume.ry...@google.com Date: Wed Feb 3 10:33:14 2010 Log: Adds explicit pure Java test support to GWTTestCase, via a setter. Calling setForcePureJava(true) on a GWTTestCase forces running the test in pure Java mode (non-GWT). This feature has the same effect than retu

[gwt-contrib] [google-web-toolkit] r7525 committed - Received Manuel Carrasco Moñino's CLA electronically.

2010-02-03 Thread codesite-noreply
Revision: 7525 Author: jlaba...@google.com Date: Wed Feb 3 13:33:59 2010 Log: Received Manuel Carrasco Moñino's CLA electronically. http://code.google.com/p/google-web-toolkit/source/detail?r=7525 Modified: /CLA-SIGNERS === --- /CLA-SIGNERSFri Dec

[gwt-contrib] Make HandlerManager survive exceptions

2010-02-03 Thread rjrjr
Reviewers: Ray Ryan, Message: Is there any reason to limit this to RuntimeException rather than Exception? I think it would be better to capture all exceptions thrown during event dispatch and then re-throw them in an umbrella exception. This way it will reach the app's UncaughtExceptionHandler

[gwt-contrib] Re: RR : Record selected annotations in Java AST

2010-02-03 Thread scottb
From the point of view of saving memory & cpu, a white list makes sense to me. http://gwt-code-reviews.appspot.com/134810/diff/1/3 File dev/core/src/com/google/gwt/dev/jjs/ast/JAnnotation.java (right): http://gwt-code-reviews.appspot.com/134810/diff/1/3#newcode62 Line 62: * Returns a mutable li

[gwt-contrib] Re: HTMLTable.iterator() should be genericized

2010-02-03 Thread jgw
On 2010/02/03 19:22:11, jlabanca wrote: LGTM. http://gwt-code-reviews.appspot.com/137808 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] HTMLTable.iterator() should be genericized

2010-02-03 Thread jlabanca
Reviewers: jgw, Description: In incubator, HTMLTable is a copy of the HTMLTable in gwt trunk, and its very outdated. HTMLTable.iterator() currently returns a non-type case Iterator. Fix: Change the return type to Iterator. Note that in the long term, we are replacing PagingScrollTable wit

Re: [gwt-contrib] Re: Questions on JsArray*

2010-02-03 Thread Scott Blum
Hey, this is pretty sweet. We should get this into GWT I think! On Wed, Feb 3, 2010 at 10:26 AM, Thomas Broyer wrote: > my JsCollections module: http://code.google.com/p/gwt-in-the-air/ > > http://code.google.com/p/gwt-in-the-air/source/browse/trunk/src/net/ltgt/gwt/jscollections/client/JsArray

[gwt-contrib] Re: Restore UiBinderUtilTest

2010-02-03 Thread jgw
On 2010/02/02 22:41:23, Ray Ryan wrote: Review, please LGTM, sir! http://gwt-code-reviews.appspot.com/136802 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r7524 committed - Merge tr...@7358 into this branch...

2010-02-03 Thread codesite-noreply
Revision: 7524 Author: r...@google.com Date: Wed Feb 3 07:25:42 2010 Log: Merge tr...@7358 into this branch Fix issue 4425: Invalid String.charAt(int) when using escape string syntax http://code.google.com/p/google-web-toolkit/source/detail?r=7524 Modified: /releases/2.0/branch-info.txt /r

[gwt-contrib] Re: Questions on JsArray*

2010-02-03 Thread Thomas Broyer
On Feb 2, 8:16 pm, Tom wrote: > Hi, > > I have some questions and proposals around the JsArray-classes because > they are handy when working with JSNI but I believe they could be > improved a bit. > > a) Why are not all native methods provided through the wrapper. > Missing methods are: > * conc