[gwt-contrib] Re: Comment on StyleInjector in google-web-toolkit

2010-02-05 Thread codesite-noreply
Comment by northrup.james: the tradeoff is potential inlining of the resource at compile-time For more information: http://code.google.com/p/google-web-toolkit/wiki/StyleInjector -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Comment on DataBackedWidgetsDesign in google-web-toolkit

2010-02-05 Thread codesite-noreply
Comment by pstockley1: Is the new table going to support editing? If it is, I strongly encourage it to abandon the popup edit boxes used in the incubator grid and use inline data entry. The popup approach while easy to implement is really poor from a usability perspective. For more infor

[gwt-contrib] Re: Remove HTTPRequest from API

2010-02-05 Thread rjrjr
LGTM pending API checker pieces http://gwt-code-reviews.appspot.com/139804 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update Api Checker for GWT 2.1

2010-02-05 Thread amitmanjhi
LGTM http://gwt-code-reviews.appspot.com/139803 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Remove HTTPRequest from API

2010-02-05 Thread jlabanca
Reviewers: Ray Ryan, Description: HTTPRequest has been deprecated since GWT 1.5 in exchange for RequestBuilder. This patch removes it completely. See the gwt-contrib discussion for details: https://groups.google.com/group/google-web-toolkit-contributors/browse_thread/thread/477873e268f4a8a1/6fb

[gwt-contrib] Update Api Checker for GWT 2.1

2010-02-05 Thread jlabanca
Reviewers: amitmanjhi, Description: This patch updates API Checker for GWT 2.1. - Replaced gwt-user-modified and gwt-dev-modifier jars by running the createApiCheckerReferenceJars script on the 2.0.1 jars. - Updated the createApiCheckerReferenceJars script now that we no longer have platform spe

[gwt-contrib] Re: RR : Record selected annotations in Java AST

2010-02-05 Thread scottb
A few more comments. http://gwt-code-reviews.appspot.com/134810/diff/4001/4003 File dev/core/src/com/google/gwt/dev/jjs/ast/JAnnotation.java (right): http://gwt-code-reviews.appspot.com/134810/diff/4001/4003#newcode40 Line 40: public static class Property extends Is there a really compelling re

[gwt-contrib] Re: RR : Record selected annotations in Java AST

2010-02-05 Thread Lex Spoon
I was thinking JAnnotationArgument would be a marker interface, like in the patch you just posted. If it was in the hierarchy, it would have to be a subtype of expression, which looks a little weird to me. -Lex -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: RR : Record selected annotations in Java AST

2010-02-05 Thread bobv
New patch set uploaded. Should JAnnotationArgument be a mix-in interface or part of the JNode hierarchy? http://gwt-code-reviews.appspot.com/134810 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r7532 committed - Making a branch to work on CFG-based optimization.

2010-02-05 Thread codesite-noreply
Revision: 7532 Author: sp...@google.com Date: Fri Feb 5 11:56:49 2010 Log: Making a branch to work on CFG-based optimization. http://code.google.com/p/google-web-toolkit/source/detail?r=7532 Added: /branches/gflow -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: History methods NPE when iframe not included

2010-02-05 Thread jgw
On 2010/02/05 16:24:02, jlabanca wrote: LGTM. http://gwt-code-reviews.appspot.com/138805 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] History methods NPE when iframe not included

2010-02-05 Thread jlabanca
Reviewers: jgw, Description: When the History iframe is absent, History is disabled in IE and impl will be set to null. Using some of the methods in History will result in an NPE, only in IE. This affects PopupPanel, which adds a history handler automatically and throws an NPE in IE if the Hist

[gwt-contrib] [google-web-toolkit] r7531 committed - Merging tr...@7479 into this branch.

2010-02-05 Thread codesite-noreply
Revision: 7531 Author: j...@google.com Date: Fri Feb 5 08:10:59 2010 Log: Merging tr...@7479 into this branch. http://code.google.com/p/google-web-toolkit/source/detail?r=7531 Added: /releases/2.0/user/src/com/google/gwt/user/theme/chrome/public/gwt/chrome/images/splitPanelThumb.png /rele

[gwt-contrib] Re: RR : Record selected annotations in Java AST

2010-02-05 Thread BobV
Thanks for the reviews. I'll have a new version of the patch for you to look at on Monday. -- Bob Vawter Google Web Toolkit Team -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] GWT build requirements and packaging for Fedora

2010-02-05 Thread James Laska
On Fri, Feb 5, 2010 at 10:23 AM, John Tamplin wrote: > On Fri, Feb 5, 2010 at 10:05 AM, James Laska wrote: >> >> You noted that the modified libraries are documented, I gather this is >> in the README file in the same directory?  Looking in 'tools/lib' for >> README files I see the following spec

Re: [gwt-contrib] GWT build requirements and packaging for Fedora

2010-02-05 Thread John Tamplin
On Fri, Feb 5, 2010 at 10:05 AM, James Laska wrote: > You noted that the modified libraries are documented, I gather this is > in the README file in the same directory? Looking in 'tools/lib' for > README files I see the following special handling instructions: > > * gwt-2.0.0/tools/lib/protobu

Re: [gwt-contrib] GWT build requirements and packaging for Fedora

2010-02-05 Thread James Laska
Greetings John, Just the feedback I was in need of, thanks for taking the time to respond! On Thu, Feb 4, 2010 at 8:05 PM, John Tamplin wrote: > On Wed, Feb 3, 2010 at 8:25 AM, jlaska wrote: >> >> I am looking into packaging GWT for Fedora.  According to the Fedora >> packaging guidelines, all

Re: [gwt-contrib] Re: html5 + gwt ... or gears?

2010-02-05 Thread Bart Guijt
What Joel said :-) (I started gwt-mobile-webkit) However, I am far from done: The AppCache behaviour is rather 'undefined' when an iframe is involved which is dynamically inserted by Javascript. According to a thread on WHATWG (http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2009-July/0213

Re: [gwt-contrib] Re: GWT Incubator Status Update and Schedule

2010-02-05 Thread John LaBanca
> > I only realized now that we are depending on the ProgressBar > in incubator... so if I read this right it might get scrapped from GWT :- It depends on whether we can implement it without using a ResizeTimer in a way that makes sense. Really, the only problem with ProgressBar is positioning t

[gwt-contrib] Re: GWT Incubator Status Update and Schedule

2010-02-05 Thread stuckagain
Hi, I only realized now that we are depending on the ProgressBar in incubator... so if I read this right it might get scrapped from GWT :- S. David On Jan 12, 7:04 pm, John LaBanca wrote: > Incubator Users - > > The Google Web Toolkit Incubator project began as a proving grounds for new > widge

[gwt-contrib] Re: html5 + gwt ... or gears?

2010-02-05 Thread Joel Webber
Karl-Heinz, We are planning on adding built-in support for the HTML5 AppCache, but have not done so yet. I believe there are some projects already in existence working to do this, such as "gwt-mobile-webkit" ( http://code.google.com/p/gwt-mobile-webkit/). I haven't used this project personally, bu

[gwt-contrib] Re: GWT 2.0.1: is the history support iframe now mandatory ?

2010-02-05 Thread Joel Webber
I just clarified the issue a bit and assigned it. Thanks for catching this. On Feb 5, 6:00 am, "Konstantin.Scheglov" wrote: >   I've added this issue yesterday, found during running tests for GWT > Designer. > > http://code.google.com/p/google-web-toolkit/issues/detail?id=4584 > > On Feb 4, 6:36 

[gwt-contrib] Re: GWT 2.0.1: is the history support iframe now mandatory ?

2010-02-05 Thread Joel Webber
I just clarified the issue a bit and assigned it. Thanks for catching this. On Feb 5, 6:00 am, "Konstantin.Scheglov" wrote: >   I've added this issue yesterday, found during running tests for GWT > Designer. > > http://code.google.com/p/google-web-toolkit/issues/detail?id=4584 > > On Feb 4, 6:36 

[gwt-contrib] Re: GWT 2.0.1: is the history support iframe now mandatory ?

2010-02-05 Thread Konstantin.Scheglov
I've added this issue yesterday, found during running tests for GWT Designer. http://code.google.com/p/google-web-toolkit/issues/detail?id=4584 On Feb 4, 6:36 pm, Joel Webber wrote: > It shouldn't be -- if you kick off History's static initializer, it will > GWT.create(HistoryImpl.class), an

[gwt-contrib] Re: GWT 2.0.1: is the history support iframe now mandatory ?

2010-02-05 Thread stuckagain
Hi, I tracked it down to the PopupPanel changes in http://code.google.com/p/google-web-toolkit/source/browse/trunk/user/src/com/google/gwt/user/client/ui/PopupPanel.java?r=7391 For a diff see: http://code.google.com/p/google-web-toolkit/source/diff?spec=svn7391&r=7391&format=side&path=/trunk/user