On 2010/02/17 20:37:04, jat wrote:
LGTM.
http://gwt-code-reviews.appspot.com/144807
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jgw,
Description:
This patch uses getBoundingClientRect on modern WebKit browsers for
getAbsoluteTop and getAbsoluteLeft. Sadly, we still support Safari3 so I
had to do this via runtime check (so we can use the old crazy impl for
Safari3). However, this is still well worth the change
On 2010/02/18 14:14:04, knorton wrote:
LGTM.
http://gwt-code-reviews.appspot.com/148802
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: Lex,
Description:
turns out that the insistence on concreteType.isStatic() prevents
top-level concrete types, because it's false for top-level types (where
explicit static is forbidden). Scott and Lex are nervous about making
isStatic() true for top-level types, but we can just test
Reviewers: jgw,
Description:
As of r7589, incubator no longer compiles against GWT trunk because
Gen2Widget overrides createHandlerManager() but returns the deprecated
HandlerManager from incubator.
Proposed Fix:
=
I propose that we rename Gen2Widget#createHandlerManager() to
LGTM, with nits.
http://gwt-code-reviews.appspot.com/149801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM, with nits.
http://gwt-code-reviews.appspot.com/149801/diff/1/3
File user/test/com/google/gwt/user/client/AsyncProxyTest.java (right):
http://gwt-code-reviews.appspot.com/149801/diff/1/3#newcode204
Line 204: final Test proxy = GWT.create(TopLevelProxy.class);
Unnecessary final.
Revision: 7593
Author: sp...@google.com
Date: Thu Feb 18 05:22:43 2010
Log: Reitveld: http://gwt-code-reviews.appspot.com/144805
Prevent a NullPointerException when JsDuplicateFunctionRemover encounters
a JsNameRef that does not have a JsName.
Patch by: cromwellian
Review by: spoon
On 2010/02/18 15:56:35, jlabanca wrote:
LGTM.
http://gwt-code-reviews.appspot.com/149802
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 7594
Author: knor...@google.com
Date: Thu Feb 18 05:55:07 2010
Log: http://gwt-code-reviews.appspot.com/148802
This patch uses getBoundingClientRect on modern WebKit browsers for
getAbsoluteTop and getAbsoluteLeft. Sadly, we still support Safari3 so I
had to
do this via runtime check
committed as r1753
http://gwt-code-reviews.appspot.com/149802
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 7596
Author: r...@google.com
Date: Thu Feb 18 07:30:03 2010
Log: Add misisng files.
http://code.google.com/p/google-web-toolkit/source/detail?r=7596
Added:
/trunk/bikeshed/src/com/google/gwt/cells/client/FieldUpdater.java
Revision: 7597
Author: mlu...@google.com
Date: Thu Feb 18 07:33:27 2010
Log: Changes to AsyncFragmentLoader to replace the use of Map with
ArrayList.
The end result results in a linear time but with a reduction in initial code
size by ~10K. The linear time is not likely a concern unless the
Revision: 7598
Author: awi...@google.com
Date: Thu Feb 18 10:19:29 2010
Log: Add new method HTMLPanel.add(Widget, Element) (using
gwt.dom.client.Element)
Add overload HTMLPanel.addAndReplaceElement(Widget, Element), marked final
so that anyone actually overriding these methods does so on the
Revision: 7599
Author: j...@google.com
Date: Thu Feb 18 10:49:13 2010
Log: Fix public issue where Dictionary was seeing the special key added
by the Chrome Developer plugin to preserve identity.
Public review: http://gwt-code-reviews.appspot.com/144807/show
Issue: 4486
Patch by: jat
Review by:
Revision: 7600
Author: guillaume.ry...@google.com
Date: Thu Feb 18 11:23:28 2010
Log: Adds explicit pure Java test support to GWTTestCase, via a setter.
Calling setForcePureJava(true) on a GWTTestCase forces running the test in
pure Java mode (non-GWT). This feature has the same effect than
On Wed, Feb 17, 2010 at 6:17 PM, Lex Spoon sp...@google.com wrote:
On Tue, Feb 16, 2010 at 3:32 PM, Scott Blum sco...@google.com wrote:
On Fri, Feb 12, 2010 at 7:00 PM, Lex Spoon sp...@google.com wrote:
On Fri, Feb 12, 2010 at 9:50 AM, Alex Moffat alex.mof...@gmail.comwrote:
Where can I
Revision: 7601
Author: r...@google.com
Date: Thu Feb 18 16:05:09 2010
Log: Checkpoint tree work
http://code.google.com/p/google-web-toolkit/source/detail?r=7601
Added:
/trunk/bikeshed/src/com/google/gwt/sample/tree/client/SimpleTreeNodeView.java
18 matches
Mail list logo
