[gwt-contrib] Re: Comment on LightweightCollections in google-web-toolkit

Comment by andre.ruediger: vararg convenience factory methods would be handy. --- MutableArray ma = makeSnackArray(); --- ImmutableArray ia = ma.freeze(); +++ ImmutableArray ia = createImmutableArray("apple", "banana", "coconut", "donut"); For more information: http://code.google.com/p/goog

[gwt-contrib] Re: Comment on LightweightCollections in google-web-toolkit

Comment by andre.ruediger: vararg convenience factory methods would be handy. so {{{MutableArray? ma = makeSnackArray(); ImmutableArray? ia = ma.freeze();}}} could become {{{ImmutableArray? ia = createImmutableArray("apple", "banana", "coconut", "donut");}}} For more information: http:/

[gwt-contrib] Re: Comment on LightweightCollections in google-web-toolkit

Comment by andre.ruediger: vararg convenience factory methods would be handy. so {{{MutableArray ma = makeSnackArray(); ImmutableArray ia = ma.freeze();}}} could become {{{ImmutableArray ia = createImmutableArray("apple", "banana", "coconut", "donut");}}} For more information: http://co

[gwt-contrib] Re: Comment on LightweightCollections in google-web-toolkit

Comment by andre.ruediger: vararg convenience factory methods would be handy. so {{{ MutableArray ma = makeSnackArray(); ImmutableArray ia = ma.freeze(); }}} could become {{{ ImmutableArray ia = createImmutableArray("apple", "banana", "coconut", "donut"); }}} For more information: http:/

[gwt-contrib] UIObject methods return type improvement.

Hi, I am currently working on a project using GWT. Maybe is a good suggestion to change the return value of functions such as addStyleDependentName or addStyleName from void to the UI modified itself, so you can do things like this: DockLayoutPanel appPanel = new DockLayoutPanel(Unit.EM);

Re: [gwt-contrib] UIObject methods return type improvement.

We could argue the merits of method chaining (I'll let the compiler guys speak to whether or not this is better, worse, or indifferent for code generation) -- but the bigger problem is that we'd have to change the style of code throughout the system to make it useful, but any attempt to do so would

[gwt-contrib] Re: when-linker-added

http://gwt-code-reviews.appspot.com/150801/diff/1/5 File dev/core/src/com/google/gwt/dev/cfg/Condition.java (right): http://gwt-code-reviews.appspot.com/150801/diff/1/5#newcode44 Line 44: public final boolean isTrue(TreeLogger logger, PropertyOracle propertyOracle, Could you collapse the paramet

[gwt-contrib] Fix for issue 4596 (broken layout on tab visibility change in IE6). Changes

Reviewers: jlabanca, Description: Fix for issue 4596 (broken layout on tab visibility change in IE6). Changes LayoutPanel to provide an explicit setWidgetVisible() method, which ensures that the layout is properly updated on a visibility change. Also adds a test to catch this particular flavor of

[gwt-contrib] Fix for KeyPressEvent.getCharCode and overall key events improvements

Reviewers: jgw, Description: See original report by tbroyer (I can't upload a patch set to the original report): http://gwt-code-reviews.appspot.com/142801/show This version fixes a couple of JSNI bugs and adds more unit tests. Also reverts createKeyPressEvent so it isn't breaking. Please rev

[gwt-contrib] Re: Added the ability to customize the timeout to begin the tests.

LGTM http://gwt-code-reviews.appspot.com/153819 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r7646 committed - Fixing possible NPE in ImageSrcIE6 when an img element is copied....

Revision: 7646 Author: jlaba...@google.com Date: Wed Mar 3 05:43:42 2010 Log: Fixing possible NPE in ImageSrcIE6 when an img element is copied. http://gwt-code-reviews.appspot.com/150807 http://code.google.com/p/google-web-toolkit/source/detail?r=7646 Added: /trunk/user/test/com/google/gwt/dom

[gwt-contrib] Re: Added the ability to customize the timeout to begin the tests.

LGTM http://gwt-code-reviews.appspot.com/153819 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: when-linker-added

http://gwt-code-reviews.appspot.com/150801/diff/1/5 File dev/core/src/com/google/gwt/dev/cfg/Condition.java (right): http://gwt-code-reviews.appspot.com/150801/diff/1/5#newcode44 Line 44: public final boolean isTrue(TreeLogger logger, PropertyOracle propertyOracle, With pleasure. Maybe "Deferre

Re: [gwt-contrib] Re: when-linker-added

Is there some sort of lightweight design doc for this? I'm pretty sure I remember it being discussed somewhere, but we need a short writeup on the project wiki to capture the context. On Wed, Mar 3, 2010 at 12:17 PM, wrote: > > http://gwt-code-reviews.appspot.com/150801/diff/1/5 > File dev/core/

[gwt-contrib] [google-web-toolkit] r7647 committed - Remove extraneous right-paren when pretty-printing a @noflip CssResour...

Revision: 7647 Author: gwt.mirror...@gmail.com Date: Wed Mar 3 06:58:58 2010 Log: Remove extraneous right-paren when pretty-printing a @noflip CssResource rule. http://code.google.com/p/google-web-toolkit/source/detail?r=7647 Modified: /trunk/user/src/com/google/gwt/resources/css/CssGenerat

[gwt-contrib] [google-web-toolkit] r7648 committed - Added the ability to customize the timeout to begin the tests....

Revision: 7648 Author: gwt.mirror...@gmail.com Date: Wed Mar 3 10:18:02 2010 Log: Added the ability to customize the timeout to begin the tests. http://gwt-code-reviews.appspot.com/153819/show http://code.google.com/p/google-web-toolkit/source/detail?r=7648 Modified: /trunk/user/src/com/google

[gwt-contrib] Re: Fix for issue 4596 (broken layout on tab visibility change in IE6). Changes

LGTM http://gwt-code-reviews.appspot.com/153820 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix for issue 4596 (broken layout on tab visibility change in IE6). Changes

(copied conversation I started in the wrong place) Sure, I understand completely how hard it is to work a coherent layout system into the hack we call CSS/Html, same reason there's setHeight() and setCellHeight(). But adding this creates a new non-symmetry, where a child must be aware of its par

[gwt-contrib] [google-web-toolkit] r7649 committed - Fix for issue 4596 (broken layout on tab visibility change in IE6). Ch...

Revision: 7649 Author: j...@google.com Date: Wed Mar 3 07:46:03 2010 Log: Fix for issue 4596 (broken layout on tab visibility change in IE6). Changes LayoutPanel to provide an explicit setWidgetVisible() method, which ensures that the layout is properly updated on a visibility change. Also add

Re: [gwt-contrib] Including a CSS resource into another one

> The @Source annotation, and presumably the src attribute of ui:style, accepts multiple css files. -- Bob Vawter Google Web Toolkit Team -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix for issue 4596 (broken layout on tab visibility change in IE6). Changes

On 2010/03/03 18:32:18, kozura wrote: Sure, I understand completely how hard it is to work a coherent layout system into the hack we call CSS/Html, same reason there's setHeight() and setCellHeight(). But adding this creates a new non-symmetry, where a child must be aware of its parent conte

[gwt-contrib] Re: Fix for issue 4596 (broken layout on tab visibility change in IE6). Changes

Committed at r7649. http://gwt-code-reviews.appspot.com/153820 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix for issue 4596 (broken layout on tab visibility change in IE6). Changes

Well, I've seen your arguments on resize/visibility events in other forums, and must defer to your judgment on what is possible in the various browsers and GWT infrastructure! Just annoying to have to add another nasty bit, especially one that creates new confusing user visible API. My parting t

[gwt-contrib] NoDeployTest timeout is too short

Reviewers: jat, Description: The RPC timeout in NoDeployTest is too short, which makes the test flaky. This patch increases the timeout to 5000ms. Please review this at http://gwt-code-reviews.appspot.com/157802 Affected files: user/test/com/google/gwt/module/client/NoDeployTest.java Index

[gwt-contrib] Re: NoDeployTest timeout is too short

LGTM http://gwt-code-reviews.appspot.com/157802 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r7651 committed - Created wiki page through web user interface. (Formatting in progress....

Revision: 7651 Author: rj...@google.com Date: Wed Mar 3 15:01:26 2010 Log: Created wiki page through web user interface. (Formatting in progress.) http://code.google.com/p/google-web-toolkit/source/detail?r=7651 Added: /wiki/RequestFactoryPlusPaths.wiki ===

[gwt-contrib] [google-web-toolkit] r7652 committed - Edited wiki page through web user interface.

Revision: 7652 Author: rj...@google.com Date: Wed Mar 3 15:11:02 2010 Log: Edited wiki page through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=7652 Modified: /wiki/RequestFactoryPlusPaths.wiki === --- /wiki/RequestFactory

[gwt-contrib] RR: RequestFactory, third time's the charm

More musings on ORM and databinding. I think we're going to build this one, or at least prototype it. http://code.google.com/p/google-web-toolkit/wiki/RequestFactoryPlusPaths or https://wave.google.com/wave/#restored:wave:

[gwt-contrib] [google-web-toolkit] r7653 committed - Edited wiki page through web user interface.

Revision: 7653 Author: rj...@google.com Date: Wed Mar 3 15:13:21 2010 Log: Edited wiki page through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=7653 Modified: /wiki/RequestFactoryPlusPaths.wiki === --- /wiki/RequestFactory

[gwt-contrib] [google-web-toolkit] r7654 committed - Added Values interface

Revision: 7654 Author: rj...@google.com Date: Wed Mar 3 15:29:14 2010 Log: Added Values interface http://code.google.com/p/google-web-toolkit/source/detail?r=7654 Modified: /wiki/RequestFactoryPlusPaths.wiki === --- /wiki/RequestFactoryPlusPaths.wiki Wed Ma

[gwt-contrib] [google-web-toolkit] r7655 committed - Edited wiki page through web user interface.

Revision: 7655 Author: rj...@google.com Date: Wed Mar 3 15:29:49 2010 Log: Edited wiki page through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=7655 Modified: /wiki/RequestFactoryPlusPaths.wiki === --- /wiki/RequestFactory

Re: [gwt-contrib] Re: when-linker-added

On Wed, Mar 3, 2010 at 12:25 PM, Bruce Johnson wrote: > Is there some sort of lightweight design doc for this? I'm pretty sure I > remember it being discussed somewhere, but we need a short writeup on the > project wiki to capture the context. > Sure, will do. The discussions preceding this pat

[gwt-contrib] [google-web-toolkit] r7656 committed - Edited wiki page through web user interface.

Revision: 7656 Author: rj...@google.com Date: Wed Mar 3 15:30:21 2010 Log: Edited wiki page through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=7656 Modified: /wiki/RequestFactoryPlusPaths.wiki === --- /wiki/RequestFactory

[gwt-contrib] [google-web-toolkit] r7657 committed - Edited wiki page through web user interface.

Revision: 7657 Author: rj...@google.com Date: Wed Mar 3 15:32:57 2010 Log: Edited wiki page through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=7657 Modified: /wiki/RequestFactoryPlusPaths.wiki === --- /wiki/RequestFactory

[gwt-contrib] [google-web-toolkit] r7658 committed - Edited wiki page through web user interface.

Revision: 7658 Author: rj...@google.com Date: Wed Mar 3 15:34:30 2010 Log: Edited wiki page through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=7658 Modified: /wiki/RequestFactoryPlusPaths.wiki === --- /wiki/RequestFactory

[gwt-contrib] [google-web-toolkit] r7659 committed - Edited wiki page through web user interface.

Revision: 7659 Author: rj...@google.com Date: Wed Mar 3 15:35:10 2010 Log: Edited wiki page through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=7659 Modified: /wiki/RequestFactoryPlusPaths.wiki === --- /wiki/RequestFactory

[gwt-contrib] [google-web-toolkit] r7660 committed - Edited wiki page through web user interface.

Revision: 7660 Author: rj...@google.com Date: Wed Mar 3 15:36:27 2010 Log: Edited wiki page through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=7660 Modified: /wiki/RequestFactoryPlusPaths.wiki === --- /wiki/RequestFactory

[gwt-contrib] [google-web-toolkit] r7661 committed - Edited wiki page through web user interface.

Revision: 7661 Author: rj...@google.com Date: Wed Mar 3 15:37:27 2010 Log: Edited wiki page through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=7661 Modified: /wiki/RequestFactoryPlusPaths.wiki === --- /wiki/RequestFactory

[gwt-contrib] [google-web-toolkit] r7662 committed - Edited wiki page through web user interface.

Revision: 7662 Author: rj...@google.com Date: Wed Mar 3 15:37:51 2010 Log: Edited wiki page through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=7662 Modified: /wiki/RequestFactoryPlusPaths.wiki === --- /wiki/RequestFactory

[gwt-contrib] [google-web-toolkit] r7663 committed - Edited wiki page through web user interface.

Revision: 7663 Author: rj...@google.com Date: Wed Mar 3 15:39:01 2010 Log: Edited wiki page through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=7663 Modified: /wiki/RequestFactoryPlusPaths.wiki === --- /wiki/RequestFactory

[gwt-contrib] Comment on RequestFactoryPlusPaths in google-web-toolkit

Comment by cromwell...@google.com: Two Questions: 1) Would Open Graph Native Language help? (OGNL). If we have enhanced GWT.create() with @GwtCreate, you could write through("ognl expression") which would invoke a generator to parse the OGNL expression and replace it with Java code. 2) Th

[gwt-contrib] Re: Comment on RequestFactoryPlusPaths in google-web-toolkit

Comment by rj...@google.com: These sound like questions I would ask you. OGNL is kind of heavy, I think. It wants to be able to execute methods with arguments and all kinds of things. But yeah, moving this away from runtime and to compile time sounds great. But my brain is full. For mor

[gwt-contrib] Re: Comment on RequestFactoryPlusPaths in google-web-toolkit

Comment by rj...@google.com: Hmmm. On the other hand, so far paths seem to be entirely for server side consumption. Client side you subscribe to the entity field at the last hop on the path, I hope. So you declare me.boss.displayName on the client. That goes to the server and comes back a