[gwt-contrib] Re: Once again allow Dates from doubles, for JSON happiness

2010-03-13 Thread scottb
LGTM, if you sort Date, and double-check that this trick works in hosted mode correctly. http://gwt-code-reviews.appspot.com/202801 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removes trivially-delegating clinits, plus some

2010-03-13 Thread Brendan Kenny
Ah! The enum clinits were driving me crazy, to the point that I was considering reverting a bunch of code to get rid of them. This is great, thanks. On Mar 12, 10:11 pm, sco...@google.com wrote: > Reviewers: Lex, cromwellian, > > Message: > Hey guys, > > I was working on a patch to JsInlining and

[gwt-contrib] Re: Once again allow Dates from doubles, for JSON happiness

2010-03-13 Thread rjrjr
Done and done, although I noticed a difference between our dates and JRE dates. if (GWT.isScript()) { d = dateForDouble(12345.67); } else { // In dev mode, we're using real JRE dates d = new Date((long) 12345.67); } The JRE version's toString is Wed Dec 31 16:00:12 PST 1969, wh

[gwt-contrib] Re: Once again allow Dates from doubles, for JSON happiness

2010-03-13 Thread rjrjr
(Presuming so and submitting.) http://gwt-code-reviews.appspot.com/202801 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Once again allow Dates from doubles, for JSON happiness

2010-03-13 Thread Ray Cromwell
If it delegate to JS Date.toString() I would presume so. The JS Date and JRE Date have other differences, like the maximum date is effectively 2^53, or about 23,000 AD/BC, after that, the JS date fails. On Fri, Mar 12, 2010 at 8:52 PM, wrote: > Reviewers: scottb, > > Description: > Once again a