lgtm
http://gwt-code-reviews.appspot.com/197801/diff/1/4
File plugins/wireshark/packet-gwtcs.c (right):
http://gwt-code-reviews.appspot.com/197801/diff/1/4#newcode490
Line 490: len = tvb_get_ntohl(tvb, offset);
Out of curiousity, are the fields above not important to print out?
http://gwt-code
Thanks.
http://gwt-code-reviews.appspot.com/197801/diff/1/4
File plugins/wireshark/packet-gwtcs.c (right):
http://gwt-code-reviews.appspot.com/197801/diff/1/4#newcode490
Line 490: len = tvb_get_ntohl(tvb, offset);
On 2010/03/15 14:57:13, zundel wrote:
Out of curiousity, are the fields above no
Revision: 7727
Author: rj...@google.com
Date: Sat Mar 13 13:43:15 2010
Log: Once again allow Dates from doubles, for JSON happiness
Review at http://gwt-code-reviews.appspot.com/202801
Review by: sco...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=7727
Modified:
/trunk
Revision: 7728
Author: jlaba...@google.com
Date: Mon Mar 15 05:16:42 2010
Log: Fixing a checkstyle error in the emul version of date.
http://code.google.com/p/google-web-toolkit/source/detail?r=7728
Modified:
/trunk/user/super/com/google/gwt/emul/java/util/Date.java
/trunk/user/test/com/google
Revision: 7729
Author: j...@google.com
Date: Mon Mar 15 05:52:23 2010
Log: Add quick-and-dirty wireshark packet dissector for GWT code server
protocol.
Public review: http://gwt-code-reviews.appspot.com/191801
Patch by: jat
Review by: zundel
http://code.google.com/p/google-web-toolkit/source/d
Is this the right place to raise issues I've found with deRPC and GWT
2.0.3?
I posted one thing last week (http://groups.google.com/group/google-
web-toolkit-contributors/browse_thread/thread/
631b8c3177930913/688dd476a8d0e359?lnk=gst&q=Eric+B.
+Ridge#688dd476a8d0e359) that thus far is unanswered.
Revision: 7730
Author: b...@google.com
Date: Mon Mar 15 07:01:19 2010
Log: Add a fast-exit path for SchedulerImpl.runRepeatingTasks()
Resolves issue 4627
Patch by: andrew.teirney
Review by: bobv
http://code.google.com/p/google-web-toolkit/source/detail?r=7730
Modified:
/trunk/user/src/com/goog
Revision: 7731
Author: amitman...@google.com
Date: Mon Mar 15 08:44:11 2010
Log: Sort & format.
Patch by: amitmanjhi
Review by: rjrjr
http://code.google.com/p/google-web-toolkit/source/detail?r=7731
Modified:
/trunk/bikeshed/src/com/google/gwt/requestfactory/shared/RequestFactory.java
/tru
LGTM.
Really, though, we should remove FragmentLoaderCreator.
http://gwt-code-reviews.appspot.com/159811/diff/1/2
File dev/core/src/com/google/gwt/dev/jjs/impl/FragmentLoaderCreator.java
(left):
http://gwt-code-reviews.appspot.com/159811/diff/1/2#oldcode114
Line 114: private void generateOnEr
Thanks. Totally agree that finding a way to remove FragmentLoader
creator would be ideal. For posterity, Lex & I discussed having an
explicit node for RunAsync in the GWT Java AST representing. Then we
wouldn't have to use separately-generated classes; we do so currently so
that our ControlFlow
ping
http://gwt-code-reviews.appspot.com/111808
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Mon, Mar 15, 2010 at 4:08 PM, wrote:
> ping
>
> http://gwt-code-reviews.appspot.com/111808
>
I don't really know enough about the issue this patch is trying to address
or the related code to really review it.
Just from looking at the socket code, what exactly are you trying to
accomplish by
This will be very helpful, Bob!
One question about globs. Also, test coverage would be good.
http://gwt-code-reviews.appspot.com/160801/diff/3001/4005
File dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java (right):
http://gwt-code-reviews.appspot.com/160801/diff/3001/4005#newcode253
L
Revision: 7732
Author: gwt.mirror...@gmail.com
Date: Mon Mar 15 14:17:17 2010
Log: A few runAsync-related code size improvements.
1) Removes the clinit, AsyncLoader__Supers, and loading fields from
generated AsyncLoaders. PRETTY mode Showcase's initial fragment drops from
500k to 480k. Prob
Reviewers: cromwellian,
Description:
Support runAsync with the cross-site linker.
Please review this at http://gwt-code-reviews.appspot.com/213801
Affected files:
M
dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java
M dev/core/src/com/google/gwt/core/linker/IFra
That's great news, and will really help with efforts to make our linkers
more sane. Out of curiosity, what's the strategy for loading fragments into
the enclosing namespace (and yes, that's the sound of me being too lazy to
dig into the patch)?
On Mon, Mar 15, 2010 at 6:17 PM, wrote:
> Reviewers
Revision: 7733
Author: amitman...@google.com
Date: Mon Mar 15 16:32:41 2010
Log: Initial RPC code that does an update, adds the JSON js library and
uses it.
Patch by: amitmanjhi
Review by: rjrjr (desk review)
http://code.google.com/p/google-web-toolkit/source/detail?r=7733
Added:
/trunk/bik
Revision: 7734
Author: rj...@google.com
Date: Mon Mar 15 17:25:20 2010
Log: Add missing eclipse step
http://code.google.com/p/google-web-toolkit/source/detail?r=7734
Modified:
/trunk/bikeshed/eclipse.README
===
--- /trunk/bikeshed/eclipse.README Fri Mar
18 matches
Mail list logo
