On Wed, Mar 17, 2010 at 4:06 PM, John Tamplin j...@google.com wrote:
While that may work for some trivial cases, in many cases you will need more
nuanced control over what gets collapsed, considering locale inheritance and
aliases.
That sounds like a pre-GWT-compile tool that auto-generates a
On 2010/03/16 15:48:26, jlabanca wrote:
LGTM. This thing's getting complicated, but I don't see any way around
it.
http://gwt-code-reviews.appspot.com/220801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: kjin,
Description:
Fix flaxy MessageTransport test.
Review by: k...@google.com
Please review this at http://gwt-code-reviews.appspot.com/234801
Affected files:
M
dev/core/test/com/google/gwt/dev/shell/remoteui/MessageTransportTest.java
Index:
On Thu, Mar 18, 2010 at 12:11 PM, Lex Spoon sp...@google.com wrote:
Yes, that's what I was thinking for complex cases. For simple cases, can't
users already specify en and get a permutation with all the Englishes
combined?
Perhaps I misunderstand, though. Is the plan to stop using en and
Depending on the string name of an enum looks suboptimal.
What are you referring to?
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Thu, Mar 18, 2010 at 12:32 PM, BobV b...@google.com wrote:
Depending on the string name of an enum looks suboptimal.
What are you referring to?
A deferred binding option is a selection from an enum. Normally the name of
an enum is not significant. It's only used in debuggers and for
Reviewers: jlabanca,
Description:
Fix for issue 4532. Removes the CSS expressions from PopupImplIE6 that
were
interfering with layout on IE7.
Please review this at http://gwt-code-reviews.appspot.com/238801/show
Affected files:
M user/src/com/google/gwt/user/client/ui/impl/PopupImplIE6.java
On Thu, Mar 18, 2010 at 12:20 PM, John Tamplin j...@google.com wrote:
On Thu, Mar 18, 2010 at 12:11 PM, Lex Spoon sp...@google.com wrote:
Yes, that's what I was thinking for complex cases. For simple cases,
can't users already specify en and get a permutation with all the
Englishes
Revision: 7744
Author: rda...@google.com
Date: Thu Mar 18 08:02:42 2010
Log: Fix flaxy MessageTransport test.
Review at http://gwt-code-reviews.appspot.com/234801
Review by: k...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=7744
Modified:
Thank you for the feedback.
It was trivial to hook up the findClientOracleData to work with the existing
process
Excellent.
- NPE in the WebModeClientOracle.readStreamAsObject finally block if
objectInputStream can't be created (ie: if the format is invalid)
Will fix.
- If the GWT
Reviewers: Ray Ryan,
Description:
Use reflection on the server side to have a shared code for handling all
GET
requests. The output of these requests is assumed to be a List of
Entity.
This list is then converted automatically to a JSON string and sent over
the
wire.
Patch by: amitmanjhi
I had a look at JsonpRequest and JsonpRequestBuilder provided by GWT
2.0 for cross domain HTTP requests. Very nice, worked right away.
However, there is one serious flaw...
Like many other JSONP implementations, GWT's JsonRequest generates a
unique callback name for each single jsonp request
If your looking for a reliable and secure cross-domain RPC
implementation then maybe you should take a look at easyXDM.
It supports RPC with no server-side requirements using one of several
available transport stacks.
.
Give it a twirl, http://easyxdm.net/v2.0.0/example/methods.html, run
the test
Comment by j...@google.com:
I've run through this with IE7, IE8, Microsoft's IE JS Leak Detector, and
Chrome, and I'm not seeing any evidence of it leaking, on IE at least. On
my Vista box, memory grows steadily as I add more items, then mostly
recovers as I clear or reset. There is a
Reviewers: fabbott,
Description:
Array implementation for Lightweight Collections. Pure Java
implementation only.
This is part of an incremental review. Not likely to land until other
parts are reviewed.
Please review this at http://gwt-code-reviews.appspot.com/232801
Affected files:
A
Reviewers: jat,
Description:
The attached patch provides correct unicode support for all of the
Charachter.is*(char/int) methods.
The included tables are only compiled into the JavaScript if any of the
methods are used. The tables (and accompanying code) increases the
compiled JavaScript by a
It's completely a style thing. Closure Compiler's externs files only
allow printInt to take two parameters. This code wouldn't be able to
trigger the incorrect behavior as far as I know.
http://gwt-code-reviews.appspot.com/225802
--
On Mar 17, 2010, at 1:54 PM, j...@google.com wrote:
It's completely a style thing. Closure Compiler's externs files
only allow
printInt to take two parameters. This code wouldn't be able to
trigger the
incorrect behavior as far as I know.
Ok, LGTM, though perhaps file a bug against
Hi,
I am reposting this question here as the user list got no reply and I
guess it is more a dev question:
I am experimenting with compiling GWT code with a standard JDK so I
can use the same code to generate HTML on both the client and the
server. So far it seem to be working OK but will only
LGTM
http://gwt-code-reviews.appspot.com/234801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: Ray Ryan,
Description:
Fix the bug where you cannot use up arrow to enter the suggestions box
Please review this at http://gwt-code-reviews.appspot.com/239801/show
Affected files:
D samples/hello/war/WEB-INF/classes/marker
D samples/showcase/war/WEB-INF/classes/marker
M
On 2010/03/18 17:54:20, unnurg wrote:
Hmm - not sure why those marker classes showed up in the CL - looking
into what I did wrong there...
http://gwt-code-reviews.appspot.com/239801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
That's definitely a valid point, and I understand how it would defeat
caching. However, I believe using a hash for the callback name would make it
impossible to properly deal with two requests to the same URL, because there
would be no way to distinguish which AsyncCallback should get which
Not sure if this has been discussed already, but you should consider
developing these in a branch until the landing plan for the changes is
clear.
On Thu, Mar 18, 2010 at 9:50 AM, rchan...@google.com wrote:
Reviewers: fabbott,
Description:
Array implementation for Lightweight Collections.
John,
The background behind that weird type hierarchy is that it stems from a time
before overlay types existed. Originally c.g.g.user.client.Element was a
simple opaque handle that had to be passed to the DOM.*() methods to get
anything done (same for Event). After the compiler got overlay type
HtmlUnit runs dev mode, where the class files have been bytecode rewritten
to allow this. But we've talked about the exact same goals John brings up
here, and I think it's a good idea worth supporting. It goes along with
being able to run stock JUnit TestCases in a JVM without having to bring up
It doesn't come up with HTMLUnit because from the GWT point of view HTMLUnit
is just another browser. Prod mode is a non-issue, and for dev mode we have
the moral equivalent of a browser plugin for it.
On Thu, Mar 18, 2010 at 11:45 AM, Joel Webber j...@google.com wrote:
John,
The background
LGTM
http://gwt-code-reviews.appspot.com/238801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
+1 to both Ray and Scott's answers.
On Thu, Mar 18, 2010 at 11:59 AM, Ray Ryan rj...@google.com wrote:
It doesn't come up with HTMLUnit because from the GWT point of view
HTMLUnit is just another browser. Prod mode is a non-issue, and for dev mode
we have the moral equivalent of a browser
Perhaps eclipse deleted them. I forget why they exist exactly, something
to do with eclipse and our canned configs for the demos.
@jlabanca, can you take the review? You know that world better than I
do.
On 2010/03/18 17:56:50, unnurg wrote:
On 2010/03/18 17:54:20, unnurg wrote:
Hmm - not
On 2010-03-18, at 12:15 PM, BobV wrote:
- If the GWT module base path URL isn't absolute, getRequestModuleBasePath
fails. We use relative base paths to simplify our hosted mode development.
Can you describe this setup in more detail? What is the canonical URL
that the request's url
On 2010-03-18, at 12:15 PM, BobV wrote:
The code that you posted is about creating a payload for a object that
has custom serialization. What does looking at the fields of the
InvokeCustomFieldSerializerCommand object show?
I can reproduce this in a barebones project. It looks like it's this
Revision: 7745
Author: j...@google.com
Date: Thu Mar 18 10:07:14 2010
Log: Fix for issue 4532. Removes the CSS expressions from PopupImplIE6 that
were
interfering with layout on IE7.
Review at http://gwt-code-reviews.appspot.com/238801
On Mar 18, 4:03 pm, Matt Mastracci matt...@mastracci.com wrote:
I can reproduce this in a barebones project. It looks like it's this class
we're using to avoid RPC pulling in all the subclasses of HashMap. We have
similar classes for ArrayList and HashSet, but those all have custom
On 2010/03/18 19:03:29, jlabanca wrote:
LGTM
Committed at r7745.
http://gwt-code-reviews.appspot.com/238801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe from this group, send email to
google-web-toolkit-contributors+unsubscribegooglegroups.com or
Sure, discussion and comments are welcome.
I am developing all this in a branch. The idea is to keep reviewing the
changes until we are all satisfied with it. I just thought it made more
sense to publish small changes rather than posting a huge patch for review
at the end. I can do either or
Comments below. Plus, could a TODO to MethodName.java saying that the
plan is to eliminate it in preference to reflecting on the
tool-generated RequestFactory interface for this info?
http://gwt-code-reviews.appspot.com/240801/diff/1/3
File
Revision: 7746
Author: jlaba...@google.com
Date: Thu Mar 18 11:37:10 2010
Log: Remove the glass panel from DOM when Popup#removeFromParent is called.
http://gwt-code-reviews.appspot.com/220801
Review by: j...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=7746
Modified:
The module changes look great. Most of the implementation looks great,
though I saw a few places we might be able to simplify it.
The main issue is that I don't believe that sharded builds will take
full advantage of the collapsing. We need for Precompile to emit the
number of *collapsed*
On Thu, Mar 18, 2010 at 7:25 PM, sp...@google.com wrote:
The main issue is that I don't believe that sharded builds will take
full advantage of the collapsing. We need for Precompile to emit the
number of *collapsed* permutations, but it looks like it emits the
number before collapsing.
http://gwt-code-reviews.appspot.com/240801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe from this group, send email to
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with
the words REMOVE ME as the subject.
Addressed your comments.
http://gwt-code-reviews.appspot.com/240801/diff/1/3
File
bikeshed/src/com/google/gwt/sample/expenses/gen/ReportRequestImpl.java
(right):
http://gwt-code-reviews.appspot.com/240801/diff/1/3#newcode63
http://gwt-code-reviews.appspot.com/240801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe from this group, send email to
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with
the words REMOVE ME as the subject.
LGTM
http://gwt-code-reviews.appspot.com/240801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe from this group, send email to
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with
the words REMOVE ME as the subject.
Revision: 7747
Author: amitman...@google.com
Date: Thu Mar 18 15:14:08 2010
Log: Use reflection on the server side to have a shared code for handling
all GET
requests. The output of these requests is assumed to be a List of Entity.
This list is then converted automatically to a JSON string
Hi John,
if your ultimate goal is to get an crawlable/indexable GWT app, you may also
want to look at http://code.google.com/web/ajaxcrawling - you can use
HtmlUnit or another headless browser technology to create an HTML snapshot
server-side and pass that to the crawler.
kathrin
On Thu, Mar
46 matches
Mail list logo
