[gwt-contrib] Re: Simplifies ActivityManager a bit, and adds a JRE unit test -- not (issue389802)

2010-04-27 Thread Amit Manjhi
Sure, I can take a look at it tomorrow morning. On Tue, Apr 27, 2010 at 9:11 PM, wrote: > Ray, any chance of you getting to this tonight? If not, Amit, maybe you > can take it in the morning? > > > http://gwt-code-reviews.appspot.com/389802/show > -- http://groups.google.com/group/Google-Web-T

[gwt-contrib] Re: Simplifies ActivityManager a bit, and adds a JRE unit test -- not (issue389802)

2010-04-27 Thread rjrjr
http://gwt-code-reviews.appspot.com/389802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Simplifies ActivityManager a bit, and adds a JRE unit test -- not (issue389802)

2010-04-27 Thread rjrjr
Ray, any chance of you getting to this tonight? If not, Amit, maybe you can take it in the morning? http://gwt-code-reviews.appspot.com/389802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Simplifies ActivityManager a bit, and adds a JRE unit test -- not (issue389802)

2010-04-27 Thread rjrjr
Reviewers: cromwellian, Description: Simplifies ActivityManager a bit, and adds a JRE unit test -- not least to prove that they're possible. Review by: cromwell...@google.com Please review this at http://gwt-code-reviews.appspot.com/389802/show Affected files: M /bikeshed/src/com/google/gwt/

[gwt-contrib] Re: Fixed inclusion of json2.js in the html files (issue394802)

2010-04-27 Thread Ray Ryan
LGTM -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: We no longer restrict properties to a tinay arbitrary white list, but (issue422801)

2010-04-27 Thread rjrjr
http://gwt-code-reviews.appspot.com/422801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fixed inclusion of json2.js in the html files (issue394802)

2010-04-27 Thread amitmanjhi
Reviewers: Ray Ryan, Description: Fixed inclusion of json2.js in the html files Patch by: amitmanjhi Review by: rjrjr (desk review) Please review this at http://gwt-code-reviews.appspot.com/394802/show Affected files: M trunk/bikeshed/war/ExpensesCustomized.html M trunk/bikeshed/war/Expen

[gwt-contrib] We no longer restrict properties to a tinay arbitrary white list, but (issue422801)

2010-04-27 Thread rjrjr
Reviewers: amitmanjhi, Description: We no longer restrict properties to a tinay arbitrary white list, but we're still ignoring the property list the client requests -- we just send everything. Except "password," as I've seen too many systems accidentally expose passwords. We'll get to a real solu

[gwt-contrib] [google-web-toolkit] r7991 committed - Restore missing file from Rodrigo's rollback...

2010-04-27 Thread codesite-noreply
Revision: 7991 Author: r...@google.com Date: Tue Apr 27 07:18:58 2010 Log: Restore missing file from Rodrigo's rollback Review by: rchan...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=7991 Added: /branches/2.1/bikeshed/test/com/google/gwt/collections/ObjectArrayTest.j

[gwt-contrib] [google-web-toolkit] r7989 committed - Updated the app code to use UiBinder for Employee/Report details and E...

2010-04-27 Thread codesite-noreply
Revision: 7989 Author: amitman...@google.com Date: Mon Apr 26 14:40:26 2010 Log: Updated the app code to use UiBinder for Employee/Report details and Employee edits. Patch by: amitmanjhi Review by: rjrjr (desk review) http://code.google.com/p/google-web-toolkit/source/detail?r=7989 Added:

[gwt-contrib] [google-web-toolkit] r7988 committed - Adding util to the source path in App.gwt.xml.

2010-04-27 Thread codesite-noreply
Revision: 7988 Author: jlaba...@google.com Date: Mon Apr 26 13:43:11 2010 Log: Adding util to the source path in App.gwt.xml. http://code.google.com/p/google-web-toolkit/source/detail?r=7988 Modified: /branches/2.1/bikeshed/src/com/google/gwt/app/App.gwt.xml ===

[gwt-contrib] [google-web-toolkit] r7987 committed - Reverting CL15463571...

2010-04-27 Thread codesite-noreply
Revision: 7987 Author: rchan...@google.com Date: Mon Apr 26 12:38:54 2010 Log: Reverting CL15463571 http://gwt-code-reviews.appspot.com/363801/show Review by: j...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=7987 Deleted: /branches/2.1/bikeshed/src/com/google/gwt/coll

[gwt-contrib] [google-web-toolkit] r7986 committed - Fix accidental checkstyle break in uibinder test land

2010-04-27 Thread codesite-noreply
Revision: 7986 Author: gwt.mirror...@gmail.com Date: Tue Apr 27 13:53:13 2010 Log: Fix accidental checkstyle break in uibinder test land http://code.google.com/p/google-web-toolkit/source/detail?r=7986 Modified: /branches/2.1/user/test/com/google/gwt/uibinder/test/client/Specific.java

[gwt-contrib] [google-web-toolkit] r7985 committed - Some files in the branch got truncated rather than deleted

2010-04-27 Thread codesite-noreply
Revision: 7985 Author: gwt.mirror...@gmail.com Date: Mon Apr 26 11:09:26 2010 Log: Some files in the branch got truncated rather than deleted http://code.google.com/p/google-web-toolkit/source/detail?r=7985 Deleted: /branches/2.1/bikeshed/src/com/google/gwt/app/place/PlaceChanged.java /branche

[gwt-contrib] [google-web-toolkit] r7984 committed - Unifies temp local tracking under a shared base visitor....

2010-04-27 Thread codesite-noreply
Revision: 7984 Author: sco...@google.com Date: Mon Apr 26 10:59:53 2010 Log: Unifies temp local tracking under a shared base visitor. - All temps now definitely get their own JDeclarationStatement inserted into the AST at the appropriate point. - Temp locals are never reused anymore; however,

[gwt-contrib] [google-web-toolkit] r7983 committed - ServletValidator disable external DTD resolution....

2010-04-27 Thread codesite-noreply
Revision: 7983 Author: sco...@google.com Date: Mon Apr 26 10:57:24 2010 Log: ServletValidator disable external DTD resolution. Copied some code from ReflectiveParser that should disable external entities when reading web.xml. http://gwt-code-reviews.appspot.com/371801/show Review by: rdayal

[gwt-contrib] [google-web-toolkit] r7982 committed - MutableArray and ImmutableArray JSNI implementation....

2010-04-27 Thread codesite-noreply
Revision: 7982 Author: rchan...@google.com Date: Mon Apr 26 10:16:20 2010 Log: MutableArray and ImmutableArray JSNI implementation. Organized tests into client-side and sever-side tests and test suites. (at http://gwt-code-reviews.appspot.com/363801/show) Review by: r...@google.com http://code.g

[gwt-contrib] [google-web-toolkit] r7980 committed - Add paging/scrolling for tables...

2010-04-27 Thread codesite-noreply
Revision: 7980 Author: r...@google.com Date: Mon Apr 26 09:03:43 2010 Log: Add paging/scrolling for tables Review at http://gwt-code-reviews.appspot.com/400801 Review by: jlaba...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=7980 Added: /branches/2.1/bikeshed/src/co

[gwt-contrib] Re: MutableArray and ImmutableArray JSNI implementation. (issue363801)

2010-04-27 Thread rchandia
http://gwt-code-reviews.appspot.com/363801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Templating the Expenses sample. (issue398802)

2010-04-27 Thread jgw
On 2010/04/27 17:30:52, jlabanca wrote: LGTM, but you're going to have some merge conflicts with the ViewData nuking patch I just committed. http://gwt-code-reviews.appspot.com/398802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Templating the Expenses sample. (issue398802)

2010-04-27 Thread jlabanca
Reviewers: jgw, Description: Templating the Expenses sample. Please review this at http://gwt-code-reviews.appspot.com/398802/show Affected files: M /bikeshed/src/com/google/gwt/sample/bikeshed/style/client/common.css M /bikeshed/src/com/google/gwt/sample/expenses/gwt/ExpensesCommon.gwt.xm

[gwt-contrib] Re: Beginnings of GWT implementation of java.util.logging (issue341803)

2010-04-27 Thread fredsa
http://gwt-code-reviews.appspot.com/341803/diff/26001/27009 File user/src/com/google/gwt/logging/client/HasWidgetsLogHandler.java (right): http://gwt-code-reviews.appspot.com/341803/diff/26001/27009#newcode65 user/src/com/google/gwt/logging/client/HasWidgetsLogHandler.java:65: if (formatter inst

[gwt-contrib] Re: Test patch. (issue420801)

2010-04-27 Thread scottb
LGTM http://gwt-code-reviews.appspot.com/420801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: ServletValidate disable external DTDs (issue371801)

2010-04-27 Thread Rajeev Dayal
If that's the main use case, then I agree. The reason I brought it up was because App Engine also does its own validation of the web.xml file, so it seemed like we were doing double-work here. On Mon, Apr 26, 2010 at 3:33 PM, Scott Blum wrote: > I think that would just make things more complicat

[gwt-contrib] Test patch. (issue420801)

2010-04-27 Thread fabbott
Reviewers: fabbott, Description: Test patch. Please review this at http://gwt-code-reviews.appspot.com/420801/show Affected files: M /bikeshed/README Index: /bikeshed/README === --- /bikeshed/README(revision 7979) +++ /bik

[gwt-contrib] [google-web-toolkit] r7979 committed - The gflow constant analyzer assumes that parameters...

2010-04-27 Thread codesite-noreply
Revision: 7979 Author: sp...@google.com Date: Mon Apr 26 12:07:45 2010 Log: The gflow constant analyzer assumes that parameters could initially hold anything, rather than assuming they haven't been initialized. This caused problems for code like: foo(String param) { if (something) { param = null

[gwt-contrib] [google-web-toolkit] r7978 committed - Updates the list of aggressive optimizations to be those...

2010-04-27 Thread codesite-noreply
Revision: 7978 Author: gwt.mirror...@gmail.com Date: Tue Apr 27 08:23:57 2010 Log: Updates the list of aggressive optimizations to be those added within the last year. Review at http://gwt-code-reviews.appspot.com/406801 Review by: sco...@google.com http://code.google.com/p/google-web-toolkit/so

[gwt-contrib] Re: For compatibility with linkers that don't yet understand soft (issue353801)

2010-04-27 Thread spoon
Committed at r7925. http://gwt-code-reviews.appspot.com/353801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: How to serialize client side objects to string?

2010-04-27 Thread mmoossen
Dear all! i tried the described RPC prefetching mechanism and i am facing one problem: first, on the server-side to serialize/RPC.encode(...) i need the serialization policy, but i need the strong name to get it from the RemoteService. so i am just using a dummy serialization policy that seems to