[gwt-contrib] Re: 1.3.1 gwt-maven-plugin in 2.1.0 M1 ??

2010-05-21 Thread nicolas.deloof
That's fine, I just wanted to ensure changes would be sent back to codehaus Jira to avoid some sort of fork - we allready hardly merged the codehaus googlecode gwt-maven plugins ! I'd be pleased to help if you plan to support some SDK features in an official GWT Maven plugin The codeHaus plugin

[gwt-contrib] Re: JsParserException better error reporting (issue546801)

2010-05-21 Thread spoon
Very nice. LGTM. http://gwt-code-reviews.appspot.com/546801/diff/2001/3001 File dev/core/src/com/google/gwt/core/ext/linker/impl/StandardLinkerContext.java (right): http://gwt-code-reviews.appspot.com/546801/diff/2001/3001#newcode422

[gwt-contrib] STS RPC failures

2010-05-21 Thread Aaron Steele
I'm seeing a strange issue with STS where launching a web application from within STS succeeds, but then RPCs fail with the following errors: http://goo.gl/hAkP The project I'm running is from /samples/expenses.roo and was created using the Roo shell (script expenses.roo). If I try running the

Re: [gwt-contrib] STS RPC failures

2010-05-21 Thread Rajeev Dayal
I wonder about the version of Roo that you're using. If you navigate down into your STS folder, do you see a roo-related directory there? What is the name of that directory? I think you need to be using the milestone version of roo, which is located at sts dir/roo dir/bin/roo.{sh, bat}. On Fri,

Re: [gwt-contrib] STS RPC failures

2010-05-21 Thread Rajeev Dayal
The roo directory should be roo-1.1.0.M1; so you should be using Roo 1.1.0.M1 to generate the app, as opposed to Roo 1.0.2. On Fri, May 21, 2010 at 2:22 PM, Rajeev Dayal rda...@google.com wrote: I wonder about the version of Roo that you're using. If you navigate down into your STS folder, do

[gwt-contrib] Added benchmark task to ant in user/ (issue547801)

2010-05-21 Thread rchandia
Reviewers: Lex, Description: Added benchmark task to ant in user/ Please review this at http://gwt-code-reviews.appspot.com/547801/show Affected files: M /build.xml M /common.ant.xml M /user/build.xml A /user/test/com/google/gwt/emultest/EmulSuiteBenchmark.java A

Re: [gwt-contrib] STS RPC failures

2010-05-21 Thread Aaron Steele
Similar results using Roo 1.1.0.M1 to generate the app (as opposed to Roo 1.0.2): http://goo.gl/SD8sx $ springsource/roo-1.1.0.M1/bin/roo.sh roo script --file expenses.roo What am I missing? FWIW, when launching from STS (Run as-Web Application), it launches a Finder window and prompts me to

Re: [gwt-contrib] STS RPC failures

2010-05-21 Thread Rajeev Dayal
[by the way, the second link you posted is broken] Hm, this is odd. What actions are you taking (in the UI) when the RPC exceptions happen? The dialog that pops up for you to select your WAR directory is expected; the default value is what you should choose. Can you send a text listing of the

Re: [gwt-contrib] STS RPC failures

2010-05-21 Thread Rajeev Dayal
Oh, also, did you enable AspectJ weaving (when STS asked you about this)? On Fri, May 21, 2010 at 3:50 PM, Rajeev Dayal rda...@google.com wrote: [by the way, the second link you posted is broken] Hm, this is odd. What actions are you taking (in the UI) when the RPC exceptions happen? The

[gwt-contrib] Improvements to GWT benchmarking. Report now provides averaged results and error statistics to i... (issue548801)

2010-05-21 Thread rchandia
Reviewers: tobyr, Description: Improvements to GWT benchmarking. Report now provides averaged results and error statistics to identify and combat mesurement noise. Please review this at http://gwt-code-reviews.appspot.com/548801/show Affected files: M

[gwt-contrib] [google-web-toolkit] r8201 committed - Fixed the module definitions so that it pulls in its dependencies corr...

2010-05-21 Thread codesite-noreply
Revision: 8201 Author: amitman...@google.com Date: Fri May 21 11:31:55 2010 Log: Fixed the module definitions so that it pulls in its dependencies correctly. Removed auth. Bumped up the appEngine version number. Review by: rj...@google.com

[gwt-contrib] Re: RR : Reimplement DevMode JavaScriptObject support (issue473801)

2010-05-21 Thread scottb
My brain hurts now. http://gwt-code-reviews.appspot.com/473801/diff/5001/6004 File dev/core/src/com/google/gwt/dev/shell/JsValueGlue.java (right): http://gwt-code-reviews.appspot.com/473801/diff/5001/6004#newcode63 dev/core/src/com/google/gwt/dev/shell/JsValueGlue.java:63: if (desiredType !=

[gwt-contrib] [google-web-toolkit] r8202 committed - JsParserException better error reporting....

2010-05-21 Thread codesite-noreply
Revision: 8202 Author: sco...@google.com Date: Fri May 21 13:07:23 2010 Log: JsParserException better error reporting. http://gwt-code-reviews.appspot.com/546801/show Review by: spoon http://code.google.com/p/google-web-toolkit/source/detail?r=8202 Added:

[gwt-contrib] Fixes pathological slowness in remote UI logger (GPE) (issue550801)

2010-05-21 Thread scottb
Reviewers: rdayal, jat, mmendez, Description: Before: all logging to remote UI occurred in a synchronous, blocking manner. After: except for creating top-level loggers, all sub-branches and log events happen asynchronously and are flushed on a background thread. Please review this at

[gwt-contrib] Re: Fixes pathological slowness in remote UI logger (GPE) (issue550801)

2010-05-21 Thread jat
This is definitely something that Rajeev should look at since I didn't have much to do with this part of it. On a relatively superficial look everything looks ok, but it seems like there should be tests that explicitly cover all the cases of trying to log branches/messages to a logger before the