[gwt-contrib] Re: Comment on TroubleshootingOOPHM in google-web-toolkit

2010-05-26 Thread codesite-noreply
Comment by audiobrian: The reason of the breakpoints issue, is that maybe you has configured a JRE and not a JDK. But now I have a question for you. Why you're using Tomcat with GWT? Greetings. For more information: http://code.google.com/p/google-web-toolkit/wiki/TroubleshootingOOPHM --

Re: [gwt-contrib] STS RPC failures

2010-05-26 Thread Aaron Steele
> What version of the DataNucleus libraries to you have installed? Here's what's in the auto-generated project pom.xml file: datanucleus-appengine - 1.0.7.final datanucleus-core - 1.1.6 datanucleus-jpa - 1.1.5 datanucleus-rdbms - 1.1.6 datanucleus-enhancer- 1.1.4 maven-datanucleus-plugin - 1.1.4

Re: [gwt-contrib] Re: Replacing CurrencyCell with generic NumberCell that uses NumberFormat. (issue568801)

2010-05-26 Thread Ray Ryan
On Wed, May 26, 2010 at 12:41 PM, John LaBanca wrote: > Do you agree that we would still have a NumberParser even with the >> renderers? >> > > Uh, what? > > > *NumberParser => NumberCell > I'm not sure I do, actually. It may be easy enough to do new ValueCell(new NumberParser()) that we could

[gwt-contrib] Re: RR : Reimplement DevMode JavaScriptObject support (issue473801)

2010-05-26 Thread bobv
Ready for another look. By adding an actual @SingleJsoImpl annotation to act as a hint for devmode, the impact on I18N's CurrencyData is pretty much a one-liner. http://gwt-code-reviews.appspot.com/473801/diff/5001/6004 File dev/core/src/com/google/gwt/dev/shell/JsValueGlue.java (right): http:

Re: [gwt-contrib] Re: Replacing CurrencyCell with generic NumberCell that uses NumberFormat. (issue568801)

2010-05-26 Thread John LaBanca
FYI - jat only reviewed the NumberCell class Thanks, John LaBanca jlaba...@google.com On Wed, May 26, 2010 at 3:41 PM, John LaBanca wrote: > Do you agree that we would still have a NumberParser even with the >> renderers? >> > > Uh, what? > > > *NumberParser => NumberCell > > Thanks, > John L

Re: [gwt-contrib] Re: Replacing CurrencyCell with generic NumberCell that uses NumberFormat. (issue568801)

2010-05-26 Thread John LaBanca
> > Do you agree that we would still have a NumberParser even with the > renderers? > Uh, what? *NumberParser => NumberCell Thanks, John LaBanca jlaba...@google.com On Wed, May 26, 2010 at 3:39 PM, Ray Ryan wrote: > On Wed, May 26, 2010 at 12:29 PM, John LaBanca wrote: > >> Hmmm... are you

Re: [gwt-contrib] Re: Replacing CurrencyCell with generic NumberCell that uses NumberFormat. (issue568801)

2010-05-26 Thread Ray Ryan
On Wed, May 26, 2010 at 12:29 PM, John LaBanca wrote: > Hmmm... are you suggesting a ValueCell/ValueInputCell that defers to a > Renderer/Parser? Assuming you mean that we would have subclasses for each > type as we do with ValueBox, I agree. But that means that we'll have a > DateCell and Numb

[gwt-contrib] Re: Replacing CurrencyCell with generic NumberCell that uses NumberFormat. (issue568801)

2010-05-26 Thread John LaBanca
Hmmm... are you suggesting a ValueCell/ValueInputCell that defers to a Renderer/Parser? Assuming you mean that we would have subclasses for each type as we do with ValueBox, I agree. But that means that we'll have a DateCell and NumberCell anyway, so this patch can go in and we can add a ValueCel

[gwt-contrib] Re: Replacing CurrencyCell with generic NumberCell that uses NumberFormat. (issue568801)

2010-05-26 Thread jat
LGTM http://gwt-code-reviews.appspot.com/568801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Replacing CurrencyCell with generic NumberCell that uses NumberFormat. (issue568801)

2010-05-26 Thread Ray Ryan
Presuming you buy into the Renderer and Parser interfaces in trunk/bikeshed/src/com/google/gwt/input, could they be used to unify NumberCell and DateCell? input is still in bikeshed so we'd need to have the whole new-public-api conversation. Maybe this CL can be the catalyst. On Wed, May 26, 2010

[gwt-contrib] Replacing CurrencyCell with generic NumberCell that uses NumberFormat. (issue568801)

2010-05-26 Thread jlabanca
Reviewers: Dan Rice, Description: Replacing CurrencyCell with generic NumberCell that uses NumberFormat. Please review this at http://gwt-code-reviews.appspot.com/568801/show Affected files: M /bikeshed/src/com/google/gwt/sample/bikeshed/stocks/StocksCommon.gwt.xml M /bikeshed/src/com/goog

[gwt-contrib] Re: Fixes a bug in the compile report dashboard where entries with same sizes were (issue566801)

2010-05-26 Thread spoon
LGTM with nits. No need to rereview if you like the suggested changes. These changes will make SOYC a lot easier to understand. http://gwt-code-reviews.appspot.com/566801/diff/1/3 File dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java (right): http://gwt-code-reviews.appspot.com/56

Re: [gwt-contrib] STS RPC failures

2010-05-26 Thread Chris Ramsdale
One initial problem is that it's failing to find the right DataNucleus libraries: ERROR DataNucleus.Plugin - Bundle "org.datanucleus.store.appengine" requires "org.datanucleus" version "[1.0.4, 1.1.5.final)" but the resolved bundle has version "1.0.7.final" which is outside the expected range. Wh

[gwt-contrib] [google-web-toolkit] r8214 committed - Redeclare interface method in the enum to work around a javac bug....

2010-05-26 Thread codesite-noreply
Revision: 8214 Author: igork...@google.com Date: Wed May 26 06:47:24 2010 Log: Redeclare interface method in the enum to work around a javac bug. See http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6724345 for details. Review at http://gwt-code-reviews.appspot.com/564801 http://code.google.co

[gwt-contrib] [google-web-toolkit] r8213 committed - Package annotations to avoid recompilation...

2010-05-26 Thread codesite-noreply
Revision: 8213 Author: gwt.mirror...@gmail.com Date: Wed May 26 09:12:50 2010 Log: Package annotations to avoid recompilation Review at http://gwt-code-reviews.appspot.com/563801 Review by: sp...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8213 Modified: /branches/2.1

[gwt-contrib] Fixes a bug in the compile report dashboard where entries with same sizes were (issue566801)

2010-05-26 Thread kprobst
Reviewers: Lex, Description: Fixes a bug in the compile report dashboard where entries with same sizes were being swallowed. It also now attributes fields to the corresponding packages, and gives additional hints about what is broken down and what isn't. Please review this at http://gwt-code-re

Re: [gwt-contrib] Tabless

2010-05-26 Thread Joel Webber
Well... HorizontalPanel is still useful in some instances, and we have no way of providing the same behavior in a general way because CSS layout is a bloody mess. I'd be ok with deprecating the others (StackPanel, TabPanel, VerticalPanel, and DockPanel) though. Le 26 mai 2010 11:36, Ray Ryan a éc

[gwt-contrib] Re: Redeclare interface method in the enum to work around a javac bug. (issue564801)

2010-05-26 Thread fabbott
Looks good to me; thanks, Igor! http://gwt-code-reviews.appspot.com/564801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Tabless

2010-05-26 Thread Ray Ryan
Joel, can we @Deprecate all the redundant non-flow panels yet? It's getting harder and harder for people to discover the right thing to do. On Wed, May 26, 2010 at 7:15 AM, Joel Webber wrote: > The FlowPanel (just a simple that leaves its children's styles > unmodified) already allows you to d

[gwt-contrib] Re: Package annotations to avoid recompilation (issue563801)

2010-05-26 Thread spoon
LGTM http://gwt-code-reviews.appspot.com/563801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8212 committed - Added benchmark task to ant in user/...

2010-05-26 Thread codesite-noreply
Revision: 8212 Author: rchan...@google.com Date: Wed May 26 04:38:31 2010 Log: Added benchmark task to ant in user/ Review at http://gwt-code-reviews.appspot.com/547801 Review by: sp...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8212 Added: /branches/2.1/user/test/c

Re: [gwt-contrib] Tabless

2010-05-26 Thread Joel Webber
The FlowPanel (just a simple that leaves its children's styles unmodified) already allows you to do this. For the vertical case, this tends to happen naturally with block-level children. The horizontal case is trickier, however. Using float:left captures some, but definitely not all cases (vertic

[gwt-contrib] Package annotations to avoid recompilation (issue563801)

2010-05-26 Thread rchandia
Reviewers: Lex, Description: Package annotations to avoid recompilation Review by: sp...@google.com Please review this at http://gwt-code-reviews.appspot.com/563801/show Affected files: M /dev/core/src/com/google/gwt/core/ext/soyc/package-info.java M /user/src/com/google/gwt/uibinder/client

[gwt-contrib] Re: Added benchmark task to ant in user/ (issue547801)

2010-05-26 Thread spoon
LGTM http://gwt-code-reviews.appspot.com/547801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Tabless

2010-05-26 Thread Ivo
The next GWT Developments, will have alternatives to the VerticalPanel and HorizontalPanel, using no table tags?? http://en.wikipedia.org/wiki/Tableless_web_design For instance, the HorizontalPanel could have a alternative named HorizontalFlowPanel, that instead of generate this code: ce

Re: [gwt-contrib] Has anyone heard what is happening with Scala support using Jribble?

2010-05-26 Thread Grzegorz Kossakowski
2010/5/20 oatkinson > I heard some rumblings about creating a new vm language that was > basically a "puddle of java" called jribble. It was supposed to > allows support for making GWT work on scala code. I have not seen > much more about it. Has anyone heard anything? I would really love > t

[gwt-contrib] Cross domain transport/RPC with <15ms transits with *no* server side dependencies for IE6+,Opera 9+, Firefox 3+ Safari 4+ and Chrome 2+.

2010-05-26 Thread Sean Kinsey
Just to let you know - as of v2.3.0, easyXDM can now offer transport/ RPC with <15ms transits with *no* server side dependencies for IE6+,Opera 9+, Firefox 3+, Safari 4+ and Chrome 2+. All you need is to include easyXDM in the two documents. For GWT this could be used in the following manner Brow

[gwt-contrib] [google-web-toolkit] r8211 committed - Added null checks to MenuItem.setSubMenu(null) so it doesn't throw an ...

2010-05-26 Thread codesite-noreply
Revision: 8211 Author: jlaba...@google.com Date: Wed May 26 03:15:17 2010 Log: Added null checks to MenuItem.setSubMenu(null) so it doesn't throw an NPE. Also made sure that the Accessibility HASPOPUP state is set to false when the submenu is removed. http://code.google.com/p/google-web-tool

[gwt-contrib] Re: Added benchmark task to ant in user/ (issue547801)

2010-05-26 Thread rchandia
http://gwt-code-reviews.appspot.com/547801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors