[gwt-contrib] Re: List.subList not fully compatibile with java.util.List interface. (issue620802)

Here are some more comments about the things that rice pointed out. http://gwt-code-reviews.appspot.com/620802/diff/8001/9002 File user/test/com/google/gwt/emultest/java/util/ListTestBase.java (right): http://gwt-code-reviews.appspot.com/620802/diff/8001/9002#newcode199

[gwt-contrib] Re: UiBinder. Code style for constant parsers.

Pretty much everything we've done so far has been limited to automatically exposing the Java-level APIs in all their ugliness. The h/v alignment values are implemented somewhat manually, but for things like enums I really like the idea that they can be exposed completely automatically. On

[gwt-contrib] UiBinder. Parser for TextAlignConstant (issue612803)

Reviewers: jgw, Description: It uses friendly names. I will post patch with adding support for names like this for horizontal/vertical alignments (in addition, not replace to keep compatibility with existing code) later. Please review this at http://gwt-code-reviews.appspot.com/612803/show

[gwt-contrib] Re: List.subList not fully compatibile with java.util.List interface. (issue620802)

I think we need a few more tests to be sure that sublists are working as intended. If things are problematic after adding more tests, another approach that might help would be to move the fromIndex and toIndex fields into AbstractList -- then fix every list operation to respect those bounds

[gwt-contrib] Escaping HTML strings from the client as a good practice to avoid XSS vulnerabilities in apps th... (issue619803)

Reviewers: mmendez, Description: Escaping HTML strings from the client as a good practice to avoid XSS vulnerabilities in apps the build off of the default app. Review by: mmen...@google.com Please review this at http://gwt-code-reviews.appspot.com/619803/show Affected files: M

[gwt-contrib] Re: List.subList not fully compatibile with java.util.List interface. (issue620802)

LGTM but would like to see more tests if possible http://gwt-code-reviews.appspot.com/620802/diff/8001/9002 File user/test/com/google/gwt/emultest/java/util/ListTestBase.java (right): http://gwt-code-reviews.appspot.com/620802/diff/8001/9002#newcode199

[gwt-contrib] Re: Any ETA for 2.1?

Le 21 juin 2010 14:29, Chris Ramsdale cramsd...@google.com a écrit : While this shouldn't be taken as a binding set of dates, we are looking to wrap up a 2.1 RC in late Q3, with GA release in early Q4. On 21 juin, 20:50, Joel Webber j...@google.com wrote: We're also working to get the new

[gwt-contrib] Re: List.subList not fully compatibile with java.util.List interface. (issue620802)

On 2010/06/21 21:54:34, markovuksanovic wrote: in javadoc is says The semantics of the list returned by this method become undefined if the backing list (i.e., this list) is structurally modified in any way other than via the returned list. (Structural modifications are those that change

[gwt-contrib] Re: List.subList not fully compatibile with java.util.List interface. (issue620802)

Thanks for the explanations. I'll add some tests and if necessary override the remove method. http://gwt-code-reviews.appspot.com/620802/diff/8001/9002 File user/test/com/google/gwt/emultest/java/util/ListTestBase.java (right):

[gwt-contrib] Re: Escaping HTML strings from the client as a good practice to avoid XSS vulnerabilities in apps th... (issue619803)

Sorry to step in without being invited (though I was earlier told that it should be expected when developing in the open), but... (see below) http://gwt-code-reviews.appspot.com/619803/diff/1/2 File user/src/com/google/gwt/user/tools/RpcServerTemplate.javasrc (right):

[gwt-contrib] Early feedback on PlaceController/ActivityManager

Aside from not being plugged with the History (yet), the one thing that bothers me (a little), something that I have in my current (very own) PlaceManager that isn't in PlaceController/ActivityManager, and contrary to History-binding has an impact on the API, is plumbing between PlaceController

[gwt-contrib] [google-web-toolkit] r8292 committed - Adding AbstractListViewAdapter#getViews() to get the views associated ...

Revision: 8292 Author: jlaba...@google.com Date: Tue Jun 22 05:03:01 2010 Log: Adding AbstractListViewAdapter#getViews() to get the views associated with an adapter. Also adding some tests for com.google.gwt.view.client. Review at http://gwt-code-reviews.appspot.com/601801 Review by:

[gwt-contrib] [google-web-toolkit] r8293 committed - Escaping HTML strings from the client as a good practice to avoid XSS ...

Revision: 8293 Author: jlaba...@google.com Date: Tue Jun 22 05:23:16 2010 Log: Escaping HTML strings from the client as a good practice to avoid XSS vulnerabilities in apps the build off of the default app. Review at http://gwt-code-reviews.appspot.com/619803 Review by: mmen...@google.com

[gwt-contrib] [google-web-toolkit] r8294 committed - Reduce Eclipse warnings to a dull roar...

Revision: 8294 Author: r...@google.com Date: Tue Jun 22 06:26:45 2010 Log: Reduce Eclipse warnings to a dull roar Review at http://gwt-code-reviews.appspot.com/640802 Review by: j...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8294 Modified:

[gwt-contrib] Re: Adding AbstractListViewAdapter#getViews() to get the views associated with an adapter. Also add... (issue601801)

committed as r8292 http://gwt-code-reviews.appspot.com/601801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Escaping HTML strings from the client as a good practice to avoid XSS vulnerabilities in apps th... (issue619803)

committed as r8293 http://gwt-code-reviews.appspot.com/619803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Support composition as well as extension. (issue653801)

LGTM if you update com/google/gwt/rpc/server/RpcServlet with this same pattern as well. http://gwt-code-reviews.appspot.com/653801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Set and MutableSet. Bytecode implementation. (issue636801)

http://gwt-code-reviews.appspot.com/636801/diff/1/4 File /bikeshed/src/com/google/gwt/collections/MutableSet.java (right): http://gwt-code-reviews.appspot.com/636801/diff/1/4#newcode23 /bikeshed/src/com/google/gwt/collections/MutableSet.java:23: public final class MutableSetE extends SetE { On

[gwt-contrib] Adding a null check to ShowcaseGenerator so that we don't try to write to a public resource that... (issue646802)

Reviewers: jgw, Description: Adding a null check to ShowcaseGenerator so that we don't try to write to a public resource that has already been created. This fixes a bug when multiple examples reference the same raw source files. Please review this at

Re: [gwt-contrib] Re: Improving event handling, as initiated in 1.6

Just to let everyone know, I've finally gotten around to picking up this task again, and have updated the linked wave with my proposals. Please feel free to chime in; I could use the feedback. Le 11 juin 2010 11:13, Thomas Broyer t.bro...@gmail.com a écrit : On Thu, Jun 10, 2010 at 11:59 PM,

[gwt-contrib] [google-web-toolkit] r8299 committed - Better implementation for getHandlers (the old one threw an exception ...

Revision: 8299 Author: unn...@google.com Date: Tue Jun 22 10:23:10 2010 Log: Better implementation for getHandlers (the old one threw an exception in Web mode) Review at http://gwt-code-reviews.appspot.com/651801 Review by: fre...@google.com

[gwt-contrib] [google-web-toolkit] r8300 committed - Work around Safari 5 failures where right-shift of a non-integer is no...

Revision: 8300 Author: j...@google.com Date: Tue Jun 22 11:13:30 2010 Log: Work around Safari 5 failures where right-shift of a non-integer is not coerced to an integer. See https://bugs.webkit.org/show_bug.cgi?id=40367 and http://trac.webkit.org/changeset/60990 for details. Patch by: jat

[gwt-contrib] [google-web-toolkit] r8301 committed - Optimized MutableArray creation. Added Benchmark to facilitate compari...

Revision: 8301 Author: rchan...@google.com Date: Mon Jun 14 11:58:23 2010 Log: Optimized MutableArray creation. Added Benchmark to facilitate comparison using a single graph. Review at http://gwt-code-reviews.appspot.com/613801 Review by: r...@google.com

[gwt-contrib] Added a guard against IndexOutOfBoundsException (issue613802)

Reviewers: jlabanca, Description: Added a guard against IndexOutOfBoundsException Review by: jlaba...@google.com Please review this at http://gwt-code-reviews.appspot.com/613802/show Affected files: M bikeshed/src/com/google/gwt/app/client/CellListPlacePickerView.java Index:

[gwt-contrib] [google-web-toolkit] r8302 committed - Added a guard against IndexOutOfBoundsException...

Revision: 8302 Author: amitman...@google.com Date: Tue Jun 22 14:48:58 2010 Log: Added a guard against IndexOutOfBoundsException Review at http://gwt-code-reviews.appspot.com/613802 Review by: jlaba...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8302 Modified: