Reviewers: Ray Ryan,
Description:
It uses just designTime and dt names, nothing specific for GWT
Designer.
Please review this at http://gwt-code-reviews.appspot.com/693801/show
Affected files:
user/src/com/google/gwt/uibinder/elementparsers/BeanParser.java
I'm only half through the review, but a number of its links are broken.
E.g. I can't see CellBrowser. Maybe try re-uploading?
I'm a bit uncomfortable doing this review without a clearer
understanding of the ViewData mechanism, which really isn't documented
at all. Can you punch up the design
Done.
On Tue, Jul 13, 2010 at 9:15 PM, sco...@google.com wrote:
http://gwt-code-reviews.appspot.com/691801/diff/1/2
File dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java (right):
http://gwt-code-reviews.appspot.com/691801/diff/1/2#newcode497
Revision: 8378
Author: rj...@google.com
Date: Tue Jul 13 09:51:15 2010
Log: Speed up UiBinderTest by having all tests share one instance of the
test app. Also clean up some deprecation warnings.
Review at http://gwt-code-reviews.appspot.com/687801
Review by: robertvaw...@google.com
Revision: 8379
Author: unn...@google.com
Date: Tue Jul 13 14:36:41 2010
Log: Minor changes to the codelab, and making it so that the remote logging
is disabled by default
Review by: fre...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8379
Modified:
Revision: 8380
Author: sco...@google.com
Date: Tue Jul 13 15:21:54 2010
Log: Implement GWT.isProdMode()
http://gwt-code-reviews.appspot.com/692801/show
Review by: tobyr
http://code.google.com/p/google-web-toolkit/source/detail?r=8380
Modified:
Revision: 8381
Author: gwt.mirror...@gmail.com
Date: Wed Jul 14 09:32:15 2010
Log: Do some cleanup on BuildTypeMap.
Review at http://gwt-code-reviews.appspot.com/691801
http://code.google.com/p/google-web-toolkit/source/detail?r=8381
Modified:
So, is that a LGTM as-is, a request to move the now-separate classes
into static nested ones, or a hold for more discussion?
On 2010/07/12 21:19:29, scottb wrote:
Actually, I may have jumped the gun on that. Making it static nested
will
have an impact on command line callers who are
http://gwt-code-reviews.appspot.com/686801/diff/1/3
File user/src/com/google/gwt/i18n/tools/ArgHandlerValueChooser.java
(right):
http://gwt-code-reviews.appspot.com/686801/diff/1/3#newcode49
user/src/com/google/gwt/i18n/tools/ArgHandlerValueChooser.java:49:
private Class? extends Localizable
LGTM
http://gwt-code-reviews.appspot.com/686801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: Ray Ryan,
Description:
Passing a ViewDataUpdater into Cell#onBrowserEvent so that cells can
update view data after the event has passed. Some editable cells did
not fully use view data, but now they use it to store their current
state. Also adding view data support to all cell
Revision: 8382
Author: rj...@google.com
Date: Wed Jul 14 07:07:23 2010
Log: Attributes required by @UiConstructor are no longer enforced when a
field is created via @UiField(provided=true)
Review at http://gwt-code-reviews.appspot.com/690801
Review by: son...@google.com
On Wed, Jul 14, 2010 at 3:11 PM, fabb...@google.com wrote:
So, is that a LGTM as-is, a request to move the now-separate classes
into static nested ones, or a hold for more discussion?
From me, and LGTM as-is. But it's worth kicking a discussion to Amit to see
if we could move them to be
LGTM
http://gwt-code-reviews.appspot.com/689801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
14 matches
Mail list logo
