[gwt-contrib] Re: ActivityManager support for RunAsync

2010-07-19 Thread Ben Harris
GIN trunk has AsyncProviders which are a nicer solution. On Jul 19, 9:40 am, jarrod jarrod.carl...@gmail.com wrote: I thought it might be helpful if, in the upcoming 2.1 release, ActivityManager and ActivityMapper could easily accommodate the use of RunAsync for code splitting. To make this

[gwt-contrib] Re: Adds Java classes for JSON serialization/deserialization to complement (issue696801)

2010-07-19 Thread zundel
Thanks for all the feedback. My responses to the comments from the Rays, Thomas, John and Scott: - We need functionality in the compiler to create JSON output to create a performance analysis tool. We are just using JSON as an exported data format, so being able to serialize a POJO isn't a big

[gwt-contrib] Add first-class support for [array].length in the compiler. (issue702801)

2010-07-19 Thread tobyr
Reviewers: scottb, Description: Add first-class support for [array].length in the compiler. Review by: sco...@google.com Please review this at http://gwt-code-reviews.appspot.com/702801/show Affected files: M dev/core/src/com/google/gwt/dev/jjs/ast/JVisitor.java M

[gwt-contrib] Re: Add first-class support for [array].length in the compiler. (issue702801)

2010-07-19 Thread tobyr
http://gwt-code-reviews.appspot.com/702801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add first-class support for [array].length in the compiler. (issue702801)

2010-07-19 Thread tobyr
http://gwt-code-reviews.appspot.com/702801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Revert Revert Adds UiBinder support for Grid, (issue703801)

2010-07-19 Thread rjrjr
Bob, you might want to use git magic to diff this directly against 8387. The delta from there is quite small. http://gwt-code-reviews.appspot.com/703801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Revert Revert Adds UiBinder support for Grid, (issue703801)

2010-07-19 Thread rjrjr
Bob, you might want to use git magic to diff this directly against 8387. The delta from there is q http://gwt-code-reviews.appspot.com/703801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Revert Revert Adds UiBinder support for Grid, (issue703801)

2010-07-19 Thread bobv
LGTM, with nits. http://gwt-code-reviews.appspot.com/703801/diff/1/2 File user/src/com/google/gwt/uibinder/elementparsers/GridParser.java (right): http://gwt-code-reviews.appspot.com/703801/diff/1/2#newcode2 user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:2: * Copyright 2009

[gwt-contrib] Re: Revert Revert Adds UiBinder support for Grid, (issue703801)

2010-07-19 Thread markovuksanovic
Some comments. http://gwt-code-reviews.appspot.com/703801/diff/1/2 File user/src/com/google/gwt/uibinder/elementparsers/GridParser.java (right): http://gwt-code-reviews.appspot.com/703801/diff/1/2#newcode2 user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:2: * Copyright 2009

[gwt-contrib] Re: Revert Revert Adds UiBinder support for Grid, (issue703801)

2010-07-19 Thread rjrjr
http://gwt-code-reviews.appspot.com/703801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Revert Revert Adds UiBinder support for Grid, (issue703801)

2010-07-19 Thread rjrjr
http://gwt-code-reviews.appspot.com/703801/diff/1/2 File user/src/com/google/gwt/uibinder/elementparsers/GridParser.java (right): http://gwt-code-reviews.appspot.com/703801/diff/1/2#newcode2 user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:2: * Copyright 2009 Google Inc. On

[gwt-contrib] Moving the Cookbook examples into Showcase. Also updates a few examples in Showcase that used de... (issue704801)

2010-07-19 Thread jlabanca
Reviewers: Dan Rice, Description: Moving the Cookbook examples into Showcase. Also updates a few examples in Showcase that used deprecated code. The process for including raw source code in an example is now much easier thanks to ContentWidget#registerSource(). Examples that were using custom

[gwt-contrib] [google-web-toolkit] r8390 committed - Adds Java classes for JSON serialization/deserialization to complement...

2010-07-19 Thread codesite-noreply
Revision: 8390 Author: zun...@google.com Date: Mon Jul 19 11:45:38 2010 Log: Adds Java classes for JSON serialization/deserialization to complement com.google.gwt.json.client classes for the client side API. Review at http://gwt-code-reviews.appspot.com/696801

[gwt-contrib] [google-web-toolkit] r8391 committed - Revert Revert Adds UiBinder support for Grid,...

2010-07-19 Thread codesite-noreply
Revision: 8391 Author: rj...@google.com Date: Mon Jul 19 12:11:32 2010 Log: Revert Revert Adds UiBinder support for Grid, fixes bug that broke having subclasses of Grid in ui.xml files. Restores r8387 Review at http://gwt-code-reviews.appspot.com/703801 Review by: robertvaw...@google.com

[gwt-contrib] [google-web-toolkit] r8392 committed - Stop including backtraces whenever an annotation class is either...

2010-07-19 Thread codesite-noreply
Revision: 8392 Author: bowdi...@google.com Date: Mon Jul 19 12:48:16 2010 Log: Stop including backtraces whenever an annotation class is either undefined or not really an annotation. The backtrace doesn't help the end user, and it feels more like a compiler exception than a user code /

[gwt-contrib] Re: Add first-class support for [array].length in the compiler. (issue702801)

2010-07-19 Thread scottb
@spoon: question for you embedded in comments. @tobyr: mostly LG, just a few things. http://gwt-code-reviews.appspot.com/702801/diff/7001/8001 File dev/core/src/com/google/gwt/dev/jjs/ast/JArrayLength.java (right): http://gwt-code-reviews.appspot.com/702801/diff/7001/8001#newcode26

[gwt-contrib] [google-web-toolkit] r8393 committed - Once again rolls back GridParser, due to an as yet...

2010-07-19 Thread codesite-noreply
Revision: 8393 Author: rj...@google.com Date: Mon Jul 19 13:29:17 2010 Log: Once again rolls back GridParser, due to an as yet undiagnosed backward incompatibility. http://code.google.com/p/google-web-toolkit/source/detail?r=8393 Deleted:

[gwt-contrib] Re: Add first-class support for [array].length in the compiler. (issue702801)

2010-07-19 Thread spoon
http://gwt-code-reviews.appspot.com/702801/diff/7001/8006 File dev/core/src/com/google/gwt/dev/jjs/impl/ExpressionAnalyzer.java (right): http://gwt-code-reviews.appspot.com/702801/diff/7001/8006#newcode163 dev/core/src/com/google/gwt/dev/jjs/impl/ExpressionAnalyzer.java:163: canThrowException =

[gwt-contrib] Re: Revert Revert Adds UiBinder support for Grid, (issue703801)

2010-07-19 Thread rjrjr
http://gwt-code-reviews.appspot.com/703801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Revert Revert Adds UiBinder support for Grid, (issue703801)

2010-07-19 Thread rjrjr
Ignore this, please. Rietveld appears to be confused by the latest patch. I'll start a new issue. http://gwt-code-reviews.appspot.com/703801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re-re-reintroduces GridParser. Now we are careful not to emit a call (issue697802)

2010-07-19 Thread rjrjr
Reviewers: robertvawter, Description: Re-re-reintroduces GridParser. Now we are careful not to emit a call to resize(int, int) unless there is an actual reason to, thus minimizing the chance that we'll break a custom Grid subclass, and eliminating any change to the code generated by a simple

[gwt-contrib] Re: Re-re-reintroduces GridParser. Now we are careful not to emit a call (issue697802)

2010-07-19 Thread rjrjr
Hey, Bob. Third time's the charm. This should be a very small delta if you compare it directly against r8391. http://gwt-code-reviews.appspot.com/697802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Using ValueStore without RequestFactory

2010-07-19 Thread jarrod
I've spent some time looking through the new RequestFactory and ValueStore packages in GWT 2.1-M2. I am excited to see data binding and validation creeping into the core GWT code. However, I have a bit of a concern that the current implementation is too specific to JPA- based applications. Will

[gwt-contrib] Fix garbage collection issue with logging in Dev Mode (issue667802)

2010-07-19 Thread unnurg
Reviewers: Ray Ryan, Description: Fix garbage collection issue with logging in Dev Mode Please review this at http://gwt-code-reviews.appspot.com/667802/show Affected files: M user/src/com/google/gwt/logging/client/LogConfiguration.java Index:

[gwt-contrib] Re: Fix garbage collection issue with logging in Dev Mode (issue667802)

2010-07-19 Thread unnurg
http://gwt-code-reviews.appspot.com/667802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors