Reviewers: jat,
Description:
No longer require RPCs to contain a 'Content-Length' HTTP request
header, thus
enabling support for XHR with 'Transfer-Encoding: Chunked'.
Review by: j...@google.com
Please review this at http://gwt-code-reviews.appspot.com/727801/show
Affected files:
M user/src/
http://gwt-code-reviews.appspot.com/714801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/638802/diff/1/2
File user/src/com/google/gwt/logging/LogImpl.gwt.xml (right):
http://gwt-code-reviews.appspot.com/638802/diff/1/2#newcode11
user/src/com/google/gwt/logging/LogImpl.gwt.xml:11:
correct indentation
http://gwt-code-reviews.appspot.com/6388
Reviewers: Ray Ryan,
Description:
Partial commit towards making instance methods real. Merged the
execution paths
for the syncRequest and RequestObject.
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Please review this at http://gwt-code-reviews.appspot.com/726801/show
Affected files:
Revision: 8435
Author: rj...@google.com
Date: Wed Jul 28 16:58:39 2010
Log: Fix 1.6 style @Overrides, and quiet a warning.
http://code.google.com/p/google-web-toolkit/source/detail?r=8435
Modified:
/trunk/dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java
==
Revision: 8434
Author: to...@google.com
Date: Wed Jul 28 16:37:27 2010
Log: Ensure bridgeMethods is initialized, even when constructed from other
subtypes, such as MissingTypeBinding.
Review at http://gwt-code-reviews.appspot.com/708802
http://code.google.com/p/google-web-toolkit/source/detai
Revision: 8433
Author: gwt.mirror...@gmail.com
Date: Wed Jul 28 18:21:23 2010
Log: Turn off logging in bikeshed, till Unnur commits her bytecode
rewriting fix. At
the moment, dev mode refresh is broken.
Patch by: amitmanjhi,unnurg
Review by: unnurg
http://code.google.com/p/google-web-toolkit/
Revision: 8432
Author: rj...@google.com
Date: Wed Jul 28 13:10:14 2010
Log: Rolls back UiBinder AbsolutePanelParser due to breakage of existing
code.
http://code.google.com/p/google-web-toolkit/source/detail?r=8432
Deleted:
/trunk/user/src/com/google/gwt/uibinder/elementparsers/AbsolutePan
Revision: 8431
Author: gwt.mirror...@gmail.com
Date: Wed Jul 28 18:16:13 2010
Log: Make javax.validation available to gwt clients.
This is a first step towards supporting JSR-303 in the GWT client.
Review at http://gwt-code-reviews.appspot.com/711801
Review by: sp...@google.com
http://code.goog
Revision: 8430
Author: rj...@google.com
Date: Wed Jul 28 11:49:56 2010
Log: Adds UiBinder parser for AbsolutePanel.
Patch by konstantin.scheg...@gmail.com
Review by rj...@google.com
http://gwt-code-reviews.appspot.com/715802/show
Review by: robertvaw...@google.com
http://code.google.com/p/googl
Reviewers: fredsa,
Description:
Split LogManager class into an set of Impl classes so that any
LogManager calls
in code will compile out cleanly when logging is disabled
Please review this at http://gwt-code-reviews.appspot.com/638802/show
Affected files:
M user/src/com/google/gwt/logging/Lo
Reviewers: scottb,
Description:
Put in a new fix for DevMode logging that uses bytecode rewriting rather
than swapping out
the LogManager and should work with App Engine apps
Review by: sco...@google.com
Please review this at http://gwt-code-reviews.appspot.com/725801/show
Affected files:
M
Reviewers: scottb,
Description:
Ensure bridgeMethods is initialized, even when constructed from other
subtypes, such as MissingTypeBinding.
Please review this at http://gwt-code-reviews.appspot.com/708802/show
Affected files:
M
dev/core/src/org/eclipse/jdt/internal/compiler/lookup/BinaryTy
On 2010/07/28 22:25:06, Lex wrote:
I thought so at first, but it's using find(). So it should still
match. Perhaps it matches too many
The caret in the regex "^(function |[A-Za-z0-9_$]+=function)" only
matches the beginning of a string. So I don't think using find() changes
anything.
htt
On Wed, Jul 28, 2010 at 6:15 PM, wrote:
> Oh, sorry. I made this comment somewhere else. The problem is the
> endStatements() method doesn't use the regex to recognize the other
> declaration style.
>
Ah, yes! Well at the least this code should be moved to a subroutine. I
believe the version wit
Oh, sorry. I made this comment somewhere else. The problem is the
endStatements() method doesn't use the regex to recognize the other
declaration style.
In addition, I believe the current regex don't match the declaration
emitted by the cross-linker. The dot in the name prevent a match.
http://g
LGTM
http://gwt-code-reviews.appspot.com/720801/diff/1/4
File user/src/com/google/gwt/cell/client/EditTextCell.java (right):
http://gwt-code-reviews.appspot.com/720801/diff/1/4#newcode231
user/src/com/google/gwt/cell/client/EditTextCell.java:231: } else if
("blur".equals(type)) {
That's pretty
Thanks. A broader fix for this and most other types has been on the verge of
being committed for something like a week now. Stay tuned.
On Wed, Jul 28, 2010 at 2:10 PM, wrote:
> Reviewers: ,
>
> Description:
> If you create a Record that needs to transfer a Boolean type, it fails.
> Here is the
LGTM
http://gwt-code-reviews.appspot.com/724801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/669801/diff/20001/21006
File dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java
(right):
http://gwt-code-reviews.appspot.com/669801/diff/20001/21006#newcode62
dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java:62: if
(code.startsW
Looks good with a few concerns.
After we try this out, we should go back and make sure we're covering
all of the use cases.
http://gwt-code-reviews.appspot.com/710802/diff/1/3
File user/src/com/google/gwt/cell/client/Cell.java (right):
http://gwt-code-reviews.appspot.com/710802/diff/1/3#newcod
http://gwt-code-reviews.appspot.com/698802/diff/1/5
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DayFilterWidget.ui.xml
(right):
http://gwt-code-reviews.appspot.com/698802/diff/1/5#newcode17
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DayFilterWidget
http://gwt-code-reviews.appspot.com/716801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jlabanca,
Description:
First pass at keyboard navigation (currently only for CellTable)
Please review this at http://gwt-code-reviews.appspot.com/710802/show
Affected files:
M user/src/com/google/gwt/cell/client/AbstractCell.java
M user/src/com/google/gwt/cell/client/Cell.java
I'll update the change with your recommendations.
http://gwt-code-reviews.appspot.com/720801/diff/1/4
File user/src/com/google/gwt/cell/client/EditTextCell.java (right):
http://gwt-code-reviews.appspot.com/720801/diff/1/4#newcode231
user/src/com/google/gwt/cell/client/EditTextCell.java:231: } e
Reviewers: Ray Ryan,
Description:
Fix warnings and checkstyle errors
Please review this at http://gwt-code-reviews.appspot.com/724801/show
Affected files:
M dev/core/src/com/google/gwt/dev/jdt/TypeRefVisitor.java
M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
M user/
Reviewers: ,
Description:
If you create a Record that needs to transfer a Boolean type, it fails.
Here is the patch to fix it.
Please review this at http://gwt-code-reviews.appspot.com/703802/show
Affected files:
user/src/com/google/gwt/valuestore/shared/impl/RecordJsoImpl.java
Index: user/
http://gwt-code-reviews.appspot.com/669801/diff/20001/21006
File dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java
(right):
http://gwt-code-reviews.appspot.com/669801/diff/20001/21006#newcode62
dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java:62: if
(code.startsW
http://gwt-code-reviews.appspot.com/669801/diff/20001/21006
File dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java
(right):
http://gwt-code-reviews.appspot.com/669801/diff/20001/21006#newcode62
dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java:62: if
(code.startsW
http://gwt-code-reviews.appspot.com/720801/diff/1/4
File user/src/com/google/gwt/cell/client/EditTextCell.java (right):
http://gwt-code-reviews.appspot.com/720801/diff/1/4#newcode231
user/src/com/google/gwt/cell/client/EditTextCell.java:231: } else if
("blur".equals(type)) {
Are there really no
LGTM
http://gwt-code-reviews.appspot.com/711801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8427
Author: drfibona...@google.com
Date: Wed Jul 28 13:15:35 2010
Log: Fixed typo
http://code.google.com/p/google-web-toolkit/source/detail?r=8427
Modified:
/wiki/CssResourceCookbook.wiki
===
--- /wiki/CssResourceCookbook.wiki Wed May 20 14:49
Fixing typo in reviewer rjrjr's email.
http://gwt-code-reviews.appspot.com/723801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr_oogle.com,
Description:
Renaming ListView.Delegate to ListView.DataProvider. setDataProvider()
and setPager() now update their delegates automatically. Adding
overloads for setDataProvider() and setPager() to optionally choose not
to initialize the delegates when they are set.
committed as r8425
http://gwt-code-reviews.appspot.com/721801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8426
Author: gwt.mirror...@gmail.com
Date: Wed Jul 28 10:19:37 2010
Log: Call GZIPOutputStream.finish() from RpcServlet.processPost() to ensure
the data received by the browser is properly formatted.
Patch by: bobv
Review by: tms
Review at http://gwt-code-reviews.appspot.com/722801
Revision: 8425
Author: jlaba...@google.com
Date: Wed Jul 28 08:02:11 2010
Log: Resubmitting this change because I accidentally included changes from
another patch the first time I submitted.
Fixing a bug in AbstractListViewAdapter where it does not inform new views
of the current data size.
Revision: 8424
Author: jlaba...@google.com
Date: Wed Jul 28 07:12:59 2010
Log: Rolling back this change because it included changes from a different
patch.
Review at http://gwt-code-reviews.appspot.com/721801
http://code.google.com/p/google-web-toolkit/source/detail?r=8424
Modified:
/trunk/
Revision: 8423
Author: jlaba...@google.com
Date: Wed Jul 28 06:51:41 2010
Log: Fixing a bug in AbstractListViewAdapter where it does not inform new
views of the current data size. We now cache the data size and pass it to
views as they are added.
Review at http://gwt-code-reviews.appspot.com
[apologies i forgot about gwt-contributors group, i initially posted
this on gwt users group]
this is a courtesy message to inform the GWT team of a potential issue
that you might like to investigate:
http://code.google.com/p/google-web-toolkit/issues/detail?id=5167
i've been tracking this issue
Revision: 8422
Author: amitman...@google.com
Date: Tue Jul 27 18:10:49 2010
Log: 3 small things:
(a) fix checkstyle failures in bikeshed,
(b) invoke checkstyle in bikeshed when checkstyle is run in trunk,
(c) remove unnecessary @Override
Patch by: amitmanjhi,unnurg
Review by: unnurg,amitmanjhi
h
Revision: 8421
Author: amitman...@google.com
Date: Tue Jul 27 17:24:40 2010
Log: Rollback update to Jetty7 since it is causing classloader problems in
conjunction with Spring. Will update to Jetty 7.1.6 after fixing these
problems.
Patch by: jat
Review by: amitmanjhi
http://code.google.com/p/go
Thanks for that summary. Very cool project!
Nathan Wells
On Wed, Jul 28, 2010 at 10:54 AM, ggeorg wrote:
> Yes hdcookbook project is a framework that helps seting up a blu-ray
> java developemnt enevironment (Blu-ray discs use JavaME for building
> menus based on Xlets kind of Applets, the name
LGTM to me to, w/ minor nits that don't need any further review.
http://gwt-code-reviews.appspot.com/719801/diff/18002/26011
File
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
(right):
http://gwt-code-reviews.appspot.com/719801/diff/18002/26011#newcode68
dev/core/s
Yes hdcookbook project is a framework that helps seting up a blu-ray
java developemnt enevironment (Blu-ray discs use JavaME for building
menus based on Xlets kind of Applets, the name comes from JavaTV).
GRIN is the scene graph that comes with hdcookbook framework and it is
used for the UI. It is
http://gwt-code-reviews.appspot.com/711801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: tms,
Description:
Call GZIPOutputStream.finish() from RpcServlet.processPost() to ensure
the data received by the browser is properly formatted.
Patch by: bobv
Review by: tms
Please review this at http://gwt-code-reviews.appspot.com/722801/show
Affected files:
M user/src/com/googl
Review requested.
http://gwt-code-reviews.appspot.com/698802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: Ray Ryan,
Description:
Begin to convert DynaTableRF sample to using UiBinder.
Next step will be to add app-wide event bus to disentangle widget
relationships.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/698802/show
Affected files:
M
On 2010/07/28 07:11:01, zundel wrote:
still LGTM
http://gwt-code-reviews.appspot.com/719801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I'm a little confused... It seems like the project you link to has
more to do with tv's and dvd's... is the browser the "screen" in this
case? Also, what is Javelin? the Grin page links to it but it looks
like an non-existent project?
On Jul 27, 6:56 pm, ggeorg wrote:
> OK, I will prepare a first
LGTM
http://gwt-code-reviews.appspot.com/721801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: Dan Rice,
Description:
Fixing a bug in AbstractListViewAdapter where it does not inform new
views of the current data size. We now cache the data size and pass it
to views as they are added.
Please review this at http://gwt-code-reviews.appspot.com/721801/show
Affected files:
M us
http://gwt-code-reviews.appspot.com/719801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
54 matches
Mail list logo
