Revision: 8542
Author: fre...@google.com
Date: Fri Aug 13 16:13:23 2010
Log: Add mouse position information to ClickEvent and DoubleClickEvent.
Manually verified that this
information is indeed available on some older and some more modern
browsers, sampling Mac/Linux/Win
where possible:
- Chr
Oui, requeste.
Merci
On Aug 13, 2010 5:38 PM, wrote:
> I only quickly read through the list of added files and some of the
> files' content, but I can say I really like it the way it is (with
> PlaceTokenizer instead of the static fromToken method described in the
> Wave)
>
> There's a nit thoug
I only quickly read through the list of added files and some of the
files' content, but I can say I really like it the way it is (with
PlaceTokenizer instead of the static fromToken method described in the
Wave)
There's a nit though, which should be probably fixed rather sooner than
later ;-)
h
Reviewers: Keith,
Description:
Change to CompilationStateBuilder to prevent recursive invalidation on
changed units.
Previously, changing any unit would not only force that unit to be
recompiled, but we would then transitively invalidate any units
depending on that unit. So changing one file co
LGTM
http://gwt-code-reviews.appspot.com/741801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8540
Author: j...@google.com
Date: Fri Aug 13 12:36:25 2010
Log: Split BigDecimal/BigInteger tests out of EmulSuite.
Suggested by: scottb
Review by: scottb
http://code.google.com/p/google-web-toolkit/source/detail?r=8540
Added:
/trunk/user/test/com/google/gwt/emultest/BigDecimalSuite
Reviewers: Ray Ryan,
Description:
Public: Support classes for a future generating GWT validators.
This classes are incomplete with plenty of TODO's.
Review by: rj...@google.com
Please review this at http://gwt-code-reviews.appspot.com/766802/show
Affected files:
A user/src/com/google/gwt/val
Nothing has changed in the ui area since John last looked, so we're good
there.
On Fri, Aug 13, 2010 at 2:25 PM, wrote:
> On 2010/08/13 17:50:40, Ray Ryan wrote:
>
>> Okay, Rayc, this is ready for review.
>>
>
> On 2010/08/13 17:43:18, Ray Ryan wrote:
>> >
>>
>
> LGTM, but John might want to lo
Revision: 8539
Author: amitman...@google.com
Date: Fri Aug 13 10:45:41 2010
Log: Incorporated Ray's feedback on
http://code.google.com/p/google-web-toolkit/source/detail?r=8533
Fixed the comment in RequestFactoryJreSuite and added a test to
RecordKeyTest.
Patch by: amitmanjhi
Review by: rjrj
Revision: 8538
Author: gwt.mirror...@gmail.com
Date: Fri Aug 13 13:25:52 2010
Log: Removes vestiges of TypeOracle support for local types.
TypeOracle hasn't supported local types for a while, this change removes
traces of it.
http://gwt-code-reviews.appspot.com/761801/show
Review by: jat
htt
http://gwt-code-reviews.appspot.com/767801/diff/1/5
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DynaTableWidget.java
(right):
http://gwt-code-reviews.appspot.com/767801/diff/1/5#newcode125
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DynaTableWidget.
LGTM
http://gwt-code-reviews.appspot.com/768801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/768801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
On Thu, Aug 12, 2010 at 4:17 PM, wrote:
> Reviewers: Ray Ryan,
>
> Description:
> Public: Fix gwt compile errors in javax.validation.
> I changed InputStreams to Strings and Local to GwtLocale.
> For the Validation class, I completely gutted it,
> bootstraping validation in GWT will not us
Revision: 8537
Author: amitman...@google.com
Date: Fri Aug 13 07:48:52 2010
Log: Override annotation and formatting
Patch by: amitmanjhi
Review by: rjrjr (tbr)
http://code.google.com/p/google-web-toolkit/source/detail?r=8537
Modified:
/trunk/user/test/com/google/gwt/requestfactory/client/imp
Okay, Rayc, this is ready for review.
On 2010/08/13 17:43:18, Ray Ryan wrote:
http://gwt-code-reviews.appspot.com/717801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/717801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: Ray Ryan,
Description:
Incorporated Ray's feedback on
http://code.google.com/p/google-web-toolkit/source/detail?r=8533
Fixed the comment in RequestFactoryJreSuite and added a test to
RecordKeyTest.
Patch by: amitmanjhi
Review by: rjrjr
Please review this at http://gwt-code-reviews.a
Revision: 8536
Author: ncha...@google.com
Date: Fri Aug 13 06:36:43 2010
Log: Public: Fix gwt compile errors in javax.validation.
I changed InputStreams to Strings and Local to GwtLocale.
For the Validation class, I completely gutted it,
bootstraping validation in GWT will not use this class.
Re
Appears I spoke too soon, getting a submit-queue test failure
On Fri, Aug 13, 2010 at 12:06 PM, wrote:
> Ok, I've addressed Bob's minor "nits" there (thanks Bob for catching)...
>
> I shall proceed to submit this puppy.
>
> Thanks for the great review guys
>
> Jason
>
>
> http://gwt-code
http://gwt-code-reviews.appspot.com/766801/diff/1/4
File user/test/com/google/gwt/requestfactory/RequestFactoryJreSuite.java
(right):
http://gwt-code-reviews.appspot.com/766801/diff/1/4#newcode26
user/test/com/google/gwt/requestfactory/RequestFactoryJreSuite.java:26:
* Suite of UiBinder tests th
Ok, I've addressed Bob's minor "nits" there (thanks Bob for catching)...
I shall proceed to submit this puppy.
Thanks for the great review guys
Jason
http://gwt-code-reviews.appspot.com/750801/diff/10002/45012
File user/src/com/google/gwt/rpc/linker/CastableTypeDataImpl.java
(right):
htt
http://gwt-code-reviews.appspot.com/750801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Done!
On Fri, Aug 13, 2010 at 4:00 PM, wrote:
> @johan -
>
> Can you sign a Contributor License Agreement so we can include your
> code:
> http://code.google.com/legal/individual-cla-v1.0.html
>
> If you scroll to the bottom, you can sign it electronically.
>
> - John
>
>
> http://gwt-code-revie
Hi,
Not sure if I understand that part.
As far as I can see it is handled by the ClippedImageImpl classes or
did it change in 2.1 ? Anyways, as long as I see the correct image I
am a happy man.
David
On Fri, Aug 13, 2010 at 4:03 PM, John Tamplin wrote:
> On Fri, Aug 13, 2010 at 4:14 AM, stucka
Reviewers: Ray Ryan,
Message:
This isn't ready for review quite yet, but it's a first cut of being
able to edit records and have them persist on the server.
Description:
Initial support for round-trip edits in the DynaTableRF sample.
Patch by: bobv
Review by: rjrjr
Please review this at http:/
On 2010/08/12 22:32:53, fredsa wrote:
LGTM.
http://gwt-code-reviews.appspot.com/763801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Fri, Aug 13, 2010 at 4:14 AM, stuckagain wrote:
> Is there an officially supported way to create a tag as HTML
> text from an ImageResource ?
>
Note that if it the image is bundled with others, it won't be an IMG tag.
--
John A. Tamplin
Software Engineer (GWT), Google
--
http://groups.go
@johan -
Can you sign a Contributor License Agreement so we can include your
code:
http://code.google.com/legal/individual-cla-v1.0.html
If you scroll to the bottom, you can sign it electronically.
- John
http://gwt-code-reviews.appspot.com/757801/show
--
http://groups.google.com/group/Google
On 2010/08/11 21:21:12, johan.rydberg wrote:
LGTM. Will commit momentarily.
http://gwt-code-reviews.appspot.com/757801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Fri, Aug 13, 2010 at 6:31 AM, Thomas Broyer wrote:
> AbstractImagePrototype.create(myImageResource).getHTML()
Yes.
There is no getHTML() method on the ImageResource interface because
the choice of how to render the data is ultimately part of the UI
toolkit.
--
Bob Vawter
Google Web Toolkit
LGTM with nits.
http://gwt-code-reviews.appspot.com/750801/diff/10002/45012
File user/src/com/google/gwt/rpc/linker/CastableTypeDataImpl.java
(right):
http://gwt-code-reviews.appspot.com/750801/diff/10002/45012#newcode24
user/src/com/google/gwt/rpc/linker/CastableTypeDataImpl.java:24: *
Add a p
Miroslav,
Thomas already gave me a workable solution.
I want to use ImageResources in widgets that expose a setHTML(...)
method to put something more complex in there (for example in the
ComplexButton/ToggleButton). They do not support widgets in thos
locations so I can not put an Image widget. I
Hi David
What do you mean by IMG tag, do you mean IMG with a src=/somefile on the
server ?
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 13 août, 10:14, stuckagain wrote:
> Hi,
>
> Is there an officially supported way to create a tag as HTML
> text from an ImageResource ?
AbstractImagePrototype.create(myImageResource).getHTML()
I don't know if it is "officially supported", but it's using public,
documented API in the way it
Hi,
Is there an officially supported way to create a tag as HTML
text from an ImageResource ?
Right now the only solution that I see is to create an
Image( ImageResource ) and do a toString() on it.
Many widgets from GWT support the user of setHTML, and in many cases I
need this to put an image
36 matches
Mail list logo
