http://gwt-code-reviews.appspot.com/880801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: amitmanjhi,
Description:
Simplifies the RequestObject api:
* No more clearUsed(). Requests are always usable
* No more reset(), it was basically unused, and untested
* RequestData move to an impl package
Also fixes violation reporting in AbstractProxyEditActivity,
and simplifies its l
LGTM
http://gwt-code-reviews.appspot.com/878801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Updated another patch.
On Tue, Sep 14, 2010 at 5:21 PM, wrote:
>
> http://gwt-code-reviews.appspot.com/878801/diff/1/6
> File
>
> user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java
> (right):
>
> http://gwt-code-reviews.appspot.com/878801/diff/1/6#newcode296
>
> user/src/com
http://gwt-code-reviews.appspot.com/878801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
What Bob said. You can write much, much faster unit tests using just
CompStateBuilder, since it's easy to build a very small world that only
contains just what you need. If you don't care about speed, it's probably
less work to go with ModuleDefLoader.
Some of the UiBinder tests are really great
Reviewers: amitmanjhi, kjin, Frank,
Description:
Back in the day, Exceptions couldn't be serialized. So we had to do
hacky things to support JUnit, since we needed to transmit exceptions
across the wire.
Better days are here, and Exceptions are now Serializable. So I'm
pulling out some very ar
http://gwt-code-reviews.appspot.com/878801/diff/1/6
File
user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java
(right):
http://gwt-code-reviews.appspot.com/878801/diff/1/6#newcode296
user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:296:
Long.class);
Shoul
Reviewers: rjrjr, robertvawter,
Description:
Initial implementation of a general purpose Find service based on an
EntityProxyId. Added tests that also check with predicates.
Patch by: amitmanjhi
Review by: rjrjr, robertvawter
Please review this at http://gwt-code-reviews.appspot.com/878801/sho
LGTM
ErrorPanel didn't work out, eh?
Delegate map is required for interpreting violation paths?
http://gwt-code-reviews.appspot.com/877801/diff/2001/3003
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/AddressEditor.java
(right):
http://gwt-code-reviews.appspot.c
It is possible to tease out the two different cases?
http://gwt-code-reviews.appspot.com/876801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8779
Author: rj...@google.com
Date: Tue Sep 14 13:25:34 2010
Log: Fix bad @Overrides, and make a more sane default value for
LoadExpensesDB.html
http://code.google.com/p/google-web-toolkit/source/detail?r=8779
Modified:
/trunk/samples/dynatablerf/src/com/google/gwt/sample/dynatab
Comment by onyeje.bose:
Great document.
However, the links to browse the Bikeshed classes like Cell, are not
working.
For more information:
http://code.google.com/p/google-web-toolkit/wiki/DataBackedWidgetsDesign
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Message:
Can you take a look at the overall API and use patterns? I still need
to write tests for pushing validation errors around, but I think this
implementation is close to where it will wind up.
Description:
Implement round-trip validation with RequestFactory and the Edito
Revision: 8778
Author: unn...@google.com
Date: Tue Sep 14 11:43:19 2010
Log: Add the option to use JSON rather than GWT RPC in remote logging
Review at http://gwt-code-reviews.appspot.com/830802
Review by: fre...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8778
Added:
LGTM
http://gwt-code-reviews.appspot.com/842803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: fredsa, rchandia,
Description:
Add error message when non-static inner class throws
NoSuchMethodException
Please review this at http://gwt-code-reviews.appspot.com/876801/show
Affected files:
M dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java
Index: dev/core/src/com/google
Revision: 8777
Author: sco...@google.com
Date: Tue Sep 14 11:34:22 2010
Log: Optimize server-side LinkedHashMap_CustomFieldSerializer.
1) Don't keep trying reflection if it's not working.
2) Cache the reflective Field needed for accessOrder.
3) Reuse KEY objects instead of making new ones each ti
This is ready for review.
http://gwt-code-reviews.appspot.com/875801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: cromwellian,
Description:
Gets the code splitter to be effective even in draft compile mode.
Review by: cromwell...@google.com
Please review this at http://gwt-code-reviews.appspot.com/875801/show
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/impl/FragmentLoaderCreator.jav
Revision: 8776
Author: rchan...@google.com
Date: Tue Sep 14 11:13:50 2010
Log: Support and validation of null values in JSON Requests
Review at http://gwt-code-reviews.appspot.com/871801
Review by: cromwell...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8776
Modified:
Revision: 8775
Author: j...@google.com
Date: Tue Sep 14 10:54:41 2010
Log: Fix for issue 4694. Adds a 'visibility' property to layout layers,
along with
a hack to LayoutImplIE8 that ensures relative units are recalculated
correctly on visibility change. Also changes LayoutPanel and TabLayoutPan
On 2010/09/14 15:17:21, jlabanca wrote:
LGTM
http://gwt-code-reviews.appspot.com/869801/diff/1/5
File user/src/com/google/gwt/layout/client/LayoutImplIE8.java (right):
http://gwt-code-reviews.appspot.com/869801/diff/1/5#newcode177
user/src/com/google/gwt/layout/client/LayoutImplIE8.java:177
http://gwt-code-reviews.appspot.com/842803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/842803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8774
Author: gwt.mirror...@gmail.com
Date: Tue Sep 14 12:42:39 2010
Log: Fixes a couple of build breaks in the samples/expenses app.
Review at http://gwt-code-reviews.appspot.com/872801
Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8774
Modifi
Revision: 8773
Author: unn...@google.com
Date: Tue Sep 14 09:19:20 2010
Log: Add stack trace display to the rest of the log handlers in dev mode
Review at http://gwt-code-reviews.appspot.com/861801
Review by: fre...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8773
Add
LGTM
http://gwt-code-reviews.appspot.com/872801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Description:
Fixes a couple of build breaks in the samples/expenses app.
Review by: rj...@google.com
Please review this at http://gwt-code-reviews.appspot.com/872801/show
Affected files:
M
samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseDetails
Done - also made firebug and console handlers show the stack traces,
which I forgot from your previous comments. DevModeHandler does not
show them (through the formatter) since we pass the exception to GWT.log
and it is handled there.
On 2010/09/14 18:15:54, fredsa wrote:
LGTM
http://gwt-cod
LGTM
http://gwt-code-reviews.appspot.com/861801/diff/7001/8008
File user/src/com/google/gwt/logging/impl/FormatterImpl.java (right):
http://gwt-code-reviews.appspot.com/861801/diff/7001/8008#newcode35
user/src/com/google/gwt/logging/impl/FormatterImpl.java:35: * LEVEL:
Wrap these two lines in j
Reviewers: cromwellian,
Description:
Support and validation of null values in JSON Requests
Review by: cromwell...@google.com
Please review this at http://gwt-code-reviews.appspot.com/871801/show
Affected files:
M user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java
M
LGTM
http://gwt-code-reviews.appspot.com/829802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: scottb,
Description:
Reduce DevMode memory footprint by using a WeakInterner for potentially
duplicated strings
Please review this at http://gwt-code-reviews.appspot.com/870801/show
Affected files:
M dev/build.xml
M dev/core/src/com/google/gwt/core/ext/typeinfo/JAbstractMethod.j
committed as r8772
http://gwt-code-reviews.appspot.com/859801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thanks John,
I am familiar with the lazy loading and code splitting and use it a
lot as it's an important issue in my gwt app's.
That's one of the reasons that SimpleComposite came to existence.
> Many API methods depend on the widget being initialized. We would have to
> cache a lot of values p
Thomas, this looks like a better design but I'm having trouble with the
patch. I think it's gotten too far behind trunk.
http://gwt-code-reviews.appspot.com/845802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jlabanca,
Description:
Fix for issue 4694. Adds a 'visibility' property to layout layers, along
with
a hack to LayoutImplIE8 that ensures relative units are recalculated
correctly on visibility change. Also changes LayoutPanel and
TabLayoutPanel
to ensure that they use this new layer p
LGTM
http://gwt-code-reviews.appspot.com/869801/diff/1/5
File user/src/com/google/gwt/layout/client/LayoutImplIE8.java (right):
http://gwt-code-reviews.appspot.com/869801/diff/1/5#newcode177
user/src/com/google/gwt/layout/client/LayoutImplIE8.java:177: // only
way to correctly ensure that layou
>
> Having lazy behavior in this LazyPanel, why not put it in other widgets
> like the Composite ;)
Many API methods depend on the widget being initialized. We would have to
cache a lot of values prior to initialization, or we'd have to have a really
aggressive initialization policy, which could
committed as r8766
http://gwt-code-reviews.appspot.com/837801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/839802/diff/3001/4010
File user/src/com/google/gwt/core/CrossSiteIframeLinker.gwt.xml (right):
http://gwt-code-reviews.appspot.com/839802/diff/3001/4010#newcode18
user/src/com/google/gwt/core/CrossSiteIframeLinker.gwt.xml:18:
This file could be dropped f
Reviewers: unnurg,
Message:
This is a small change to the xsiframe linker. These hoops are a legacy
from the xs linker that is no longer needed. Since xsiframe has an
iframe, the code can be directly installed instead of being passed
around in a string.
Description:
The cross-site iframe linker
Revision: 8771
Author: b...@google.com
Date: Tue Sep 14 03:12:23 2010
Log: Updates RequestFactory's Receiver type with onViolation() and
onFailure() methods, making it an abstract type.
Patch by: bobv
Review by: amitmanjhi, rjrjr
Review at http://gwt-code-reviews.appspot.com/855802
http://cod
> I've noticed that c.g.g.editor.rebind.model.EditorModelTest has a
> nested RealJavaResource class that reads a Java file from the
> classpath so you can use an existing class with CompilerStateBuilder.
> This is similar to what ModuleDefLoader would do, just without the
> super-source override. I
Hi,
I'm working on a generator for ActivityMapper (as I described in the
Wave:
https://wave.google.com/wave/waveref/googlewave.com/w+eva-sERfA/~/conv+root/b+WkpUtoC1A
) and am wondering how to write the unit test, more specifically how
to get a TypeOracle.
I see two possible approaches:
1. use a
Having lazy behavior in this LazyPanel, why not put it in other
widgets like the Composite ;)
On Sep 14, 11:32 am, Thomas Broyer wrote:
> On Sep 14, 9:47 am, dflorey wrote:
>
> > I remember there once has been a LazyPanel in the incubator especially
> > for use within TabPanels.
>
> The one that
Thanks for your reply. Yes, I know that html5 support is a mess.
I guess I'll split up my stuff into separate projects supporting a
single feature/property like webDB (requires native webDB / gears
detection property), css3 transforms etc.
Thanks for the link, very impressive!
Daniel
On Sep 14, 1
On Sep 14, 9:47 am, dflorey wrote:
> I remember there once has been a LazyPanel in the incubator especially
> for use within TabPanels.
The one that graduated into GWT proper? ;-)
http://google-web-toolkit.googlecode.com/svn/javadoc/2.0/com/google/gwt/user/client/ui/LazyPanel.html
--
http://g
On Sep 13, 6:04 pm, dflorey wrote:
> I'm working on a HTML5 widget library that will emulate html5 when it
> is not supported by the browser (html5 form elements etc.)
> I don't know what is the best approach to take advantage of deferred
> binding to use the native/emulated classes.
> Is it bett
I just uploaded the latest version of SimpleComposite in the issue:
http://code.google.com/p/google-web-toolkit/issues/detail?id=2508
On Sep 14, 9:47 am, dflorey wrote:
> I remember there once has been a LazyPanel in the incubator especially
> for use within TabPanels.
> Can you by chance provi
I remember there once has been a LazyPanel in the incubator especially
for use within TabPanels.
Can you by chance provide your SimpleComposite src?
Thanks,
Daniel
On Sep 12, 5:04 pm, Ed wrote:
> > I've never used lazy-loading within my
> > composites and never felt the need for it;
>
> Lucky ba
>> What is important is that we can have the eclipse plugin/browser
>> plugins without the need for an active internet connection.
>
> You can do that, though it takes a bit of work -- basically mirror the
> directory off the server and unpack it, then point the Eclipse update
> site at the unpacke
On Tue, Sep 14, 2010 at 3:00 AM, David wrote:
> But anyway, indeed if this is not deemed important to the GWT team I
> can understand.
We have certainly talked about it - I think it has just been a matter
of competing priorities.
> What is important is that we can have the eclipse plugin/browser
Hi,
We are not allowed to bring in software on some external media. All
software we use must be downloaded by a department so that they can
track all software being used and the lawyers can check if the license
agreements are acceptable.
In order to download something I need a URL.
But anyway, i
55 matches
Mail list logo
