[gwt-contrib] - Set GWT version to 2.1.0 (issue1019801)

Reviewers: drfibonacci, cromwellian, Description: - Set GWT version to 2.1.0 - Added gwt version property - Set gwt-servlet scope to runtime. Please review this at http://gwt-code-reviews.appspot.com/1019801/show Affected files: M samples/expenses/pom.xml Index: samples/expenses/pom.xml ==

[gwt-contrib] Re: Removed stale information in the Expenses Sample App README-MAVEN.txt (issue1003801)

http://gwt-code-reviews.appspot.com/1003801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] GWT 2.1 RC1 javadoc

Thomas - You're blog is awesome, but "Sure-footed bighorn sheep take a stroll on the face of the Buffalo Bill Dam" are even cooler. Thanks, John LaBanca jlaba...@google.com On Fri, Oct 15, 2010 at 8:

Re: [gwt-contrib] GWT 2.1 RC1 javadoc

On Sat, Oct 16, 2010 at 1:59 AM, John Tamplin wrote: > On Fri, Oct 15, 2010 at 7:32 PM, Thomas Broyer wrote: >> Thanks John! > > Sorry, I keep getting failures on the big commit.  I will try again > later tonight, and if that doesn't work I will break it up into > multiple commits. No problem.

Re: [gwt-contrib] GWT 2.1 RC1 javadoc

On Fri, Oct 15, 2010 at 7:32 PM, Thomas Broyer wrote: > Thanks John! Sorry, I keep getting failures on the big commit. I will try again later tonight, and if that doesn't work I will break it up into multiple commits. -- John A. Tamplin Software Engineer (GWT), Google -- http://groups.google

Re: [gwt-contrib] GWT 2.1 RC1 javadoc

On Sat, Oct 16, 2010 at 12:17 AM, John Tamplin wrote: > On Fri, Oct 15, 2010 at 5:58 PM, Thomas Broyer wrote: >> Could anyone please update the online 2.1 javadoc at >> http://google-web-toolkit.googlecode.com/svn/javadoc/2.1/index.html to >> RC1 ? > > I was waiting on one more commit, but since

[gwt-contrib] Cleanup for EnumsTest and EnumsWithNameObfuscationTest suites, make sure they always run with co... (issue1018801)

Reviewers: cromwellian, Description: Cleanup for EnumsTest and EnumsWithNameObfuscationTest suites, make sure they always run with correct configuration property Please review this at http://gwt-code-reviews.appspot.com/1018801/show Affected files: A user/test/com/google/gwt/dev/jjs/EnumsSui

Re: [gwt-contrib] GWT 2.1 RC1 javadoc

On Fri, Oct 15, 2010 at 5:58 PM, Thomas Broyer wrote: > Could anyone please update the online 2.1 javadoc at > http://google-web-toolkit.googlecode.com/svn/javadoc/2.1/index.html to > RC1 ? > > (to tell the truth, I'm updating my blog posts about places and > activities and either I keep the links

[gwt-contrib] GWT 2.1 RC1 javadoc

Hi, Could anyone please update the online 2.1 javadoc at http://google-web-toolkit.googlecode.com/svn/javadoc/2.1/index.html to RC1 ? (to tell the truth, I'm updating my blog posts about places and activities and either I keep the links to the M3 javadoc, which means there's a mismatch between th

[gwt-contrib] Re: Checkpoint patch on the way to making samples/expenses bookmarkable via (issue1013801)

http://gwt-code-reviews.appspot.com/1013801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Checkpoint patch on the way to making samples/expenses bookmarkable via (issue1013801)

Fix copyright header and LGTM http://gwt-code-reviews.appspot.com/1013801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enum Ordinalization Optimization (issue1015801)

http://gwt-code-reviews.appspot.com/1015801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Checkpoint patch on the way to making samples/expenses bookmarkable via (issue1013801)

Ready to submit http://gwt-code-reviews.appspot.com/1013801/diff/1/2 File samples/expenses/src/main/java/com/google/gwt/sample/expenses/ExpensesCommon.gwt.xml (right): http://gwt-code-reviews.appspot.com/1013801/diff/1/2#newcode18 samples/expenses/src/main/java/com/google/gwt/sample/expenses/Ex

[gwt-contrib] Re: Checkpoint patch on the way to making samples/expenses bookmarkable via (issue1013801)

http://gwt-code-reviews.appspot.com/1013801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Checkpoint patch on the way to making samples/expenses bookmarkable via (issue1016801)

Please ignore, redundant with http://gwt-code-reviews.appspot.com/1013801. Not sure what happened. http://gwt-code-reviews.appspot.com/1016801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Checkpoint patch on the way to making samples/expenses bookmarkable via (issue1016801)

Reviewers: bobv, Description: Checkpoint patch on the way to making samples/expenses bookmarkable via activities and places. Introduces some place classes (not yet used), but mainly reorganizes the code: * Refactors SlidingPanel out of ExpensesShell * Refactors a Factory class to be in charge o

[gwt-contrib] Enum Ordinalization Optimization (issue1015801)

Reviewers: scottb, cromwellian, Description: Enum Ordinalization Optimization Please review this at http://gwt-code-reviews.appspot.com/1015801/show Affected files: M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java M dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java

[gwt-contrib] Re: Updating release notes in preparation for GWT 2.1. Since we now maintain the release notes histo... (issue1014801)

LGTM http://gwt-code-reviews.appspot.com/1014801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Updating release notes in preparation for GWT 2.1. Since we now maintain the release notes histo... (issue1014801)

Reviewers: rchandia, Description: Updating release notes in preparation for GWT 2.1. Since we now maintain the release notes history on the Google project hosting website, the distributed release notes now contains a link so we do not have to maintain both sets of release notes. Please review t

[gwt-contrib] Checkpoint CL on the way to making samples/expenses bookmarkable via (issue1013801)

Reviewers: bobv, Description: Checkpoint CL on the way to making samples/expenses bookmarkable via activities and places. Introduces some place classes (not yet used), but mainly reorganizes the code: * Refactors SlidingPanel out of ExpensesShell * Refactors a Factory class to be in charge of i

[gwt-contrib] [google-web-toolkit] r9081 committed - Remove setHtml(SafeHtml) and other Html-related methods from Label....

Revision: 9081 Author: p...@google.com Date: Fri Oct 15 07:45:24 2010 Log: Remove setHtml(SafeHtml) and other Html-related methods from Label. This removes setHtml, setTextOrHtml, and getTextOrHtml from Label, and adds the appropriate tests. Review at http://gwt-code-reviews.appspot.com/10118

[gwt-contrib] Re: Fixing a bug in CellBrowser where losing an open node causes an exception the next time the Cell... (issue1012801)

committed as r9080 http://gwt-code-reviews.appspot.com/1012801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Remove setHtml(SafeHtml) and other Html-related methods from Label. (issue1011801)

LGTM++ http://gwt-code-reviews.appspot.com/1011801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9080 committed - Fixing a bug in CellBrowser where losing an open node causes an except...

Revision: 9080 Author: gwt.mirror...@gmail.com Date: Fri Oct 15 09:53:49 2010 Log: Fixing a bug in CellBrowser where losing an open node causes an exception the next time the CellBrowser is clicked. The code that nullifies the focusedKey in a node should be in the loop the trimes the tree down

[gwt-contrib] Re: Remove setHtml(SafeHtml) and other Html-related methods from Label. (issue1011801)

http://gwt-code-reviews.appspot.com/1011801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing a bug in CellBrowser where losing an open node causes an exception the next time the Cell... (issue1012801)

LGTM http://gwt-code-reviews.appspot.com/1012801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9079 committed - Remove PermutationWorker top level event; obscures individual permutat...

Revision: 9079 Author: sco...@google.com Date: Fri Oct 15 05:47:13 2010 Log: Remove PermutationWorker top level event; obscures individual permutation compiles. Review by: zun...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=9079 Modified: /trunk/dev/core/src/com/goo

[gwt-contrib] Re: Removed stale information in the Expenses Sample App README-MAVEN.txt (issue1003801)

http://gwt-code-reviews.appspot.com/1003801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removed stale information in the Expenses Sample App README-MAVEN.txt (issue1003801)

http://gwt-code-reviews.appspot.com/1003801/diff/3001/4001 File samples/expenses/README-MAVEN.txt (right): http://gwt-code-reviews.appspot.com/1003801/diff/3001/4001#newcode27 samples/expenses/README-MAVEN.txt:27: Go to the Run menu item and select Run -> Debug as -> Web Application. On 2010/10/

[gwt-contrib] [google-web-toolkit] r9078 committed - Fixes to Expsenses sample pom.xml...

Revision: 9078 Author: gwt.mirror...@gmail.com Date: Fri Oct 15 05:42:32 2010 Log: Fixes to Expsenses sample pom.xml - Upgraded to latest GAE so that GPE can use a currently-shipping GAE SDK version - Downgraded Datanucleus Enhancer for GAE compatibility - Explicit Xalan dependency - Other sun

[gwt-contrib] Re: Removed stale information in the Expenses Sample App README-MAVEN.txt (issue1003801)

couple nits http://gwt-code-reviews.appspot.com/1003801/diff/3001/4001 File samples/expenses/README-MAVEN.txt (right): http://gwt-code-reviews.appspot.com/1003801/diff/3001/4001#newcode27 samples/expenses/README-MAVEN.txt:27: Go to the Run menu item and select Run -> Debug as -> Web Application

[gwt-contrib] Fixing a bug in CellBrowser where losing an open node causes an exception the next time the Cell... (issue1012801)

Reviewers: pdr, Description: Fixing a bug in CellBrowser where losing an open node causes an exception the next time the CellBrowser is clicked. The code that nullifies the focusedKey in a node should be in the loop the trimes the tree down to size. Please review this at http://gwt-code-reviews

[gwt-contrib] Re: Remove setHtml(SafeHtml) and other Html-related methods from Label. (issue1011801)

http://gwt-code-reviews.appspot.com/1011801/diff/1/3 File user/src/com/google/gwt/user/client/ui/Label.java (right): http://gwt-code-reviews.appspot.com/1011801/diff/1/3#newcode360 user/src/com/google/gwt/user/client/ui/Label.java:360: getElement().setInnerText(getText()); You'll have to overrid

[gwt-contrib] Re: Adding SafeHtml versions of addItem/insertItem to Tree and TreeItem. (issue1010801)

committed as r9077 http://gwt-code-reviews.appspot.com/1010801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Remove setHtml(SafeHtml) and other Html-related methods from Label. (issue1011801)

Reviewers: jlabanca, Description: Remove setHtml(SafeHtml) and other Html-related methods from Label. This removes setHtml, setTextOrHtml, and getTextOrHtml from Label, and adds the appropriate tests. Please review this at http://gwt-code-reviews.appspot.com/1011801/show Affected files: M u

[gwt-contrib] [google-web-toolkit] r9077 committed - Adding SafeHtml versions of addItem/insertItem to Tree and TreeItem....

Revision: 9077 Author: gwt.mirror...@gmail.com Date: Fri Oct 15 04:43:56 2010 Log: Adding SafeHtml versions of addItem/insertItem to Tree and TreeItem. Review at http://gwt-code-reviews.appspot.com/1010801 Review by: p...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=907

[gwt-contrib] JsonRequestProcessor can't execute validation groups

Namely this: violations = validator.validate(entityInstance); we can't do violations = validator.validate(entityInstance, SomeGroup.class); I'm bringing it up, I don't have a solution for this right now but I feel we should have at least have a way to disable the validator inside the processor

[gwt-contrib] [google-web-toolkit] r9075 committed - Add missing Javadoc for Cell packages...

Revision: 9075 Author: r...@google.com Date: Thu Oct 14 16:36:33 2010 Log: Add missing Javadoc for Cell packages Review at http://gwt-code-reviews.appspot.com/1005801 Review by: jlaba...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=9075 Modified: /trunk/user/src/com/g

Re: [gwt-contrib] Re: Not using dvsDataMap on child entities

Not to mention that it's right there, it's in dvsDataMap, the only problem is that it's sending the copy from the wrong map, that's it. On Fri, Oct 15, 2010 at 11:01 AM, Patrick Julien wrote: > Do you have any idea on how I could get to the modified sub-entity? I > have no way of reaching it ri

Re: [gwt-contrib] Re: Not using dvsDataMap on child entities

Do you have any idea on how I could get to the modified sub-entity? I have no way of reaching it right now. Even if this is outside your design for request factory it kind of conflicts with the design of editors. Editors want to get an object graph and that's what we would want to send back since

Re: [gwt-contrib] Re: Not using dvsDataMap on child entities

On Thu, Oct 14, 2010 at 8:17 PM, Patrick Julien wrote: > As a follow up this, the internal persist() method isn't called on > these modified entities either. Chained persistence is explicitly outside the RequestFactory design because RequestFactory doesn't know anything about persistence. Introdu

[gwt-contrib] Re: Adding SafeHtml versions of addItem/insertItem to Tree and TreeItem. (issue1010801)

LGTM On 2010/10/15 12:19:40, jlabanca wrote: http://gwt-code-reviews.appspot.com/1010801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes to Expsenses sample pom.xml (issue1007801)

LGTM http://gwt-code-reviews.appspot.com/1007801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Adding SafeHtml versions of addItem/insertItem to Tree and TreeItem. (issue1010801)

Reviewers: pdr, Description: Adding SafeHtml versions of addItem/insertItem to Tree and TreeItem. Please review this at http://gwt-code-reviews.appspot.com/1010801/show Affected files: M user/src/com/google/gwt/user/client/ui/Tree.java M user/src/com/google/gwt/user/client/ui/TreeItem.java