Reviewers: pdr,
Description:
Fix handling of search order where particular regions have different
default scripts than the base language, such as pa_PK and zh_TW.
Patch by: jat
Review by: pdr
Please review this at http://gwt-code-reviews.appspot.com/1022801/show
Affected files:
M user/src/c
Reviewers: pdr,
Description:
Add LocalizedNames API.
Patch by: jat
Review by: pdr
Please review this at http://gwt-code-reviews.appspot.com/1023801/show
Affected files:
A user/src/com/google/gwt/i18n/client/DefaultLocalizedNames.java
A user/src/com/google/gwt/i18n/client/DefaultLocalizedN
Reviewers: scottb,
Description:
Fix for resolving overloaded enum valueOf method
Please review this at http://gwt-code-reviews.appspot.com/1024801/show
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/ast/JClassLiteral.java
M user/test/com/google/gwt/dev/jjs/test/EnumsTest.java
Inde
committed as r9082
http://gwt-code-reviews.appspot.com/1014801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1024801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Hi,
I have a Popup Panel.
PopupPanel Popup = new PopupPanel();
Popup .center();
It gets displayed correctly. But when I resize the browser when the
Pop-Up Panel is displayed, the Pop up panel either disappears/it is
behind the browser.
Please help me solve this issue.
Thanks in advance
Guru.
-
http://gwt-code-reviews.appspot.com/1013801/diff/1/2
File
samples/expenses/src/main/java/com/google/gwt/sample/expenses/ExpensesCommon.gwt.xml
(right):
http://gwt-code-reviews.appspot.com/1013801/diff/1/2#newcode18
samples/expenses/src/main/java/com/google/gwt/sample/expenses/ExpensesCommon.gwt.
I love how you deprecate core stuff, just like that. It shows how much
thought you put before introducing APIs. By now, it seems like half of
GWT API must be at deprecated state. No problem, simply slap
@Deprecated, @SuppressWarnings("deprecation") all over the place and
you 're done.
--
http://g
Thomas,
very good your post, thanks for contributing to the community.
--
*Vagner Araujo
O PLANETA É O MEU PAÍS, E A CIÊNCIA É A MINHA RELIGIÃO ! INDO AO INFINITO E
ALÉM... !!*
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
The PopupPanel doesn't auto-recenter. You can keep it centered using the
following:
final PopupPanel Popup = new PopupPanel();
Popup .center();
Window.addResizeHandler(new ResizeHandler() {
public void onResize(ResizeEvent event) {
Popup .center();
}
});
Thanks,
John LaBanca
jlaba...@goo
In the case of HandlerManager, you just need to replace it with
EventBus/SimpleEventBus. The interface is nice if you're working with
gin and it's also nice for unit testing. If you don't want to be
bothered too much, just substitute all instances of HandlerManager
with SimpleEventBus and you're
Reviewers: pdr,
Description:
Add CLDR import for region names.
Patch by: jat
Review by: pdr
Please review this at http://gwt-code-reviews.appspot.com/1025801/show
Affected files:
M
tools/cldr-import/src/com/google/gwt/tools/cldr/CurrencyDataProcessor.java
M
tools/cldr-import/src/com/g
> If you don't want to be bothered too much, just substitute all
> instances of HandlerManager with SimpleEventBus and you're done.
I dunno--per my comment in a proposed patch to SimpleEventBus, I find
using "EventBus" in all the places I used HandlerManager to be odd.
I used HandlerManager insi
Filed as an Issue:
http://code.google.com/p/google-web-toolkit/issues/detail?id=5438
On 2010/10/17 06:06:23, cromwellian wrote:
lgtm
http://gwt-code-reviews.appspot.com/1019801/diff/1/2
File samples/expenses/pom.xml (right):
http://gwt-code-reviews.appspot.com/1019801/diff/1/2#newcode11
sa
Reviewers: jlabanca,
Description:
Perform basic HMTL escaping for @example tag code
Please review this at http://gwt-code-reviews.appspot.com/1026801/show
Affected files:
M build-tools/doctool/src/com/google/doctool/custom/ExampleTaglet.java
Index: build-tools/doctool/src/com/google/doctoo
I think you're getting hung up on the name, Stephen. The only differences
between the two classes is that the move to EventBus gave us a chance to
simplify the api. They do they same thing, and for the most part an EventBus
is a drop in replacement for a HandlerManager.
HandlerManager was written
This issue still isn't fixed (svn version 9090). Will it make it for
2.1.0?
On Sep 21, 4:01 pm, monkeyboy wrote:
> Thanks John for the quick response. How can I monitor this issue, I
> mean how can I tell when it is solved cause I need this feature real
> soon. I assume it will surely be solved b
LGTM++
http://gwt-code-reviews.appspot.com/1026801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
It won't be fixed for GWT 2.1.0. We plan to add a SelectionManager that
gives you control over how user Selection updates the SelectionModel in a
future version. In the meantime, you'll have to handle selection manually
in the Cell if you want custom selection support.
I know this isn't ideal, b
Ok. Thanks for the info.
On Oct 18, 8:31 pm, John LaBanca wrote:
> It won't be fixed for GWT 2.1.0. We plan to add a SelectionManager that
> gives you control over how user Selection updates the SelectionModel in a
> future version. In the meantime, you'll have to handle selection manually
> in
Revision: 9113
Author: r...@google.com
Date: Mon Oct 18 08:37:34 2010
Log: Perform basic HMTL escaping for @example tag code
Review at http://gwt-code-reviews.appspot.com/1026801
Review by: jlaba...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9113
Modified:
/trunk/bu
Revision: 9114
Author: r...@google.com
Date: Mon Oct 18 08:41:00 2010
Log: Perform basic HMTL escaping for @example tag code
http://code.google.com/p/google-web-toolkit/source/detail?r=9114
Modified:
/releases/2.1/build-tools/doctool/src/com/google/doctool/custom/ExampleTaglet.java
LGTM
http://gwt-code-reviews.appspot.com/1024801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
When running the sample currently on the trunk under
Windows 7, as soon as the mouse cursor is hovered
over any of the displayed rows, all the rows collapse
and disappear from the panel in an animated way.
Regards, /Esfand
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thanks for the report. What browser are you seeing this in? Does it happen
as soon as you run the sample?
On Mon, Oct 18, 2010 at 9:28 AM, Esfand wrote:
> When running the sample currently on the trunk under
> Windows 7, as soon as the mouse cursor is hovered
> over any of the displayed rows, al
Reviewers: jlabanca,
Description:
Add package.html files
Add missing Javadoc
Please review this at http://gwt-code-reviews.appspot.com/1027801/show
Affected files:
M
dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java
M dev/core/src/com/google/gwt/core/linker/Cro
LGTM - but it looks like you copy and pasted "Classes used for testing
GWT." and forgot to update it.
http://gwt-code-reviews.appspot.com/1027801/diff/1/4
File dev/core/src/com/google/gwt/util/package.html (right):
http://gwt-code-reviews.appspot.com/1027801/diff/1/4#newcode3
dev/core/src/com/g
We have been using package-info.java instead, where we can also use
annotations and get refactoring support. Why do we want to switch?
http://gwt-code-reviews.appspot.com/1027801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I'm wiling to switch everything over to package-info.java. FYI,
right now I see only 12 instances of package-info.java.
Dan
On Mon, Oct 18, 2010 at 4:59 PM, wrote:
> We have been using package-info.java instead, where we can also use
> annotations and get refactoring support. Why do we want
I think we currently only use package-info.java when we need it.
Thanks,
John LaBanca
jlaba...@google.com
On Mon, Oct 18, 2010 at 5:21 PM, Daniel Rice (דניאל רייס)
wrote:
> I'm wiling to switch everything over to package-info.java. FYI,
> right now I see only 12 instances of package-info.java
If you're really up for it Dan, us ♥ consistency.
On Mon, Oct 18, 2010 at 2:24 PM, John LaBanca wrote:
> I think we currently only use package-info.java when we need it.
>
> Thanks,
> John LaBanca
> jlaba...@google.com
>
>
>
> On Mon, Oct 18, 2010 at 5:21 PM, Daniel Rice (דניאל רייס) > wrote:
>
This happens with Firefox/3.6.10 Chrome 8.0 is OK.
The sample starts OK. Everything is fine as long as
the mouse cursor is outside of the details panel.
I can event scroll forward and backward. Even after
disappearing the rows, I can scroll forward or backward
and the rows reappear.
This proble
Reviewers: conroy,
Description:
Contradiction in terms, and makes the compiler blow up.
Please review this at http://gwt-code-reviews.appspot.com/1028801/show
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/ast/JNonNullType.java
M dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java
On 2010/10/18 22:52:22, scottb wrote:
perhaps we should add a test for this too?
http://gwt-code-reviews.appspot.com/1028801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Hmm... not really sure how to recreate it. :/
On Mon, Oct 18, 2010 at 7:19 PM, wrote:
> On 2010/10/18 22:52:22, scottb wrote:
>
>
> perhaps we should add a test for this too?
>
>
> http://gwt-code-reviews.appspot.com/1028801/show
>
--
http://groups.google.com/group/Google-Web-Toolkit-Contribut
Reserving comments about coding style, may I recommend moving the
invocation of AttachEvent.fire() in Widget from the onLoad() and
onUnload() methods to the onAttach() and onDetach methods
respectively?
Reasoning? Historically, the onLoad() and onUnload() methods have been
default empty implementa
> Thoughts?
http://code.google.com/p/google-web-toolkit/source/detail?r=9062
Looks like it did not make it into 2.1 RC1:
http://code.google.com/p/google-web-toolkit/source/browse/tags/2.1.0-rc1/user/src/com/google/gwt/user/client/ui/Widget.java
- Stephen
--
http://groups.google.com/group/Goo
This was fixed.
http://code.google.com/p/google-web-toolkit/source/browse/releases/2.1/user/src/com/google/gwt/user/client/ui/Widget.java
On Mon, Oct 18, 2010 at 6:34 PM, Stephen Haberman
wrote:
>
> > Thoughts?
>
> http://code.google.com/p/google-web-toolkit/source/detail?r=9062
>
> Looks like i
> I think you're getting hung up on the name, Stephen.
Yeah, I know. :-)
I'll get used to the name, I can just foresee explaining "no, this event
bus here in Widget isn't /the/ event bus" as a idiosyncrasy to fellow
team members/GWT newbies.
> HandlerManager was written before the notion of app
39 matches
Mail list logo
