[gwt-contrib] Re: Integrating RequestFactory, MVP, Editor, etc.

On 2 nov, 00:21, Amir Kashani wrote: > I know 2.1 doesn't include any effort at linking the new frameworks > together, but it seems that there were some ideas thrown around before > feature freeze. Specifically, I've stumbled upon various classes that were > once commited as part of the Expenses

[gwt-contrib] Integrating RequestFactory, MVP, Editor, etc.

I know 2.1 doesn't include any effort at linking the new frameworks together, but it seems that there were some ideas thrown around before feature freeze. Specifically, I've stumbled upon various classes that were once commited as part of the Expenses app (com.google.gwt.samples.expenses.client.pla

[gwt-contrib] Comment on RequestFactory_2_1_1 in google-web-toolkit

Comment by cromwellian: Issue #5367 Polymorphism in RF Issue #5394 Make type references in JSON payloads compact For more information: http://code.google.com/p/google-web-toolkit/wiki/RequestFactory_2_1_1 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9174 committed - Edited wiki page RequestFactory_2_1_1 through web user interface.

Revision: 9174 Author: b...@google.com Date: Mon Nov 1 13:53:22 2010 Log: Edited wiki page RequestFactory_2_1_1 through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=9174 Modified: /wiki/RequestFactory_2_1_1.wiki === --- /wi

[gwt-contrib] [google-web-toolkit] r9173 committed - Edited wiki page RequestFactory_2_1_1 through web user interface.

Revision: 9173 Author: b...@google.com Date: Mon Nov 1 13:23:23 2010 Log: Edited wiki page RequestFactory_2_1_1 through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=9173 Modified: /wiki/RequestFactory_2_1_1.wiki === --- /wi

[gwt-contrib] Re: Fixing a bug in CellTree where we always pass null as the key for the rendered object instead of... (issue1070801)

http://gwt-code-reviews.appspot.com/1070801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing a bug in CellTree where we always pass null as the key for the rendered object instead of... (issue1070801)

On 2010/11/01 15:15:20, jlabanca wrote: LGTM for fixing this bug. Could you add a test that checks that the key system works? So, have two keys instead of the constant "the key" that's there now? http://gwt-code-reviews.appspot.com/1070801/show -- http://groups.google.com/group/Google-Web-Too

[gwt-contrib] [google-web-toolkit] r9172 committed - Edited wiki page RequestFactory_2_1_1 through web user interface.

Revision: 9172 Author: b...@google.com Date: Mon Nov 1 10:44:21 2010 Log: Edited wiki page RequestFactory_2_1_1 through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=9172 Modified: /wiki/RequestFactory_2_1_1.wiki === --- /wi

[gwt-contrib] Re: Ensure that all base URL's are absolut-ify-ed, no matter where we get them from. (issue1066801)

LGTM On Fri, Oct 29, 2010 at 5:41 PM, wrote: > http://gwt-code-reviews.appspot.com/1066801/show > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9171 committed - Created wiki page through web user interface.

Revision: 9171 Author: b...@google.com Date: Mon Nov 1 10:26:16 2010 Log: Created wiki page through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=9171 Added: /wiki/RequestFactory_2_1_1.wiki === --- /dev/null +++ /wiki/Reques

[gwt-contrib] Re: The proposed fix will disambiguate setter overloads by ranking them according (issue993801)

LGTM Really nice, just one nit below. http://gwt-code-reviews.appspot.com/993801/diff/7001/8001 File user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java (right): http://gwt-code-reviews.appspot.com/993801/diff/7001/8001#newcode185 user/src/com/google/gwt/uibinder/rebind/model/Ow

[gwt-contrib] Re: The proposed fix will disambiguate setter overloads by ranking them according (issue993801)

You better sit down for this: reviewing now. On Mon, Nov 1, 2010 at 8:51 AM, wrote: > ping. > > On 2010/10/14 19:46:03, fabiomfv wrote: > >> +1. >> > > there is the possibility of choosing incorrectly since we are not able >> > to > >> look at the parameter type 'passed in' (proposed fix 2 woul

[gwt-contrib] Re: The proposed fix will disambiguate setter overloads by ranking them according (issue993801)

ping. On 2010/10/14 19:46:03, fabiomfv wrote: +1. there is the possibility of choosing incorrectly since we are not able to look at the parameter type 'passed in' (proposed fix 2 would work on that basis, but is a higher impact change). As Ray mentioned, the safe workaround is to provid

[gwt-contrib] Re: Adding a public method AbstractHasData#getRowContainer() to give users access to the element tha... (issue1072801)

http://gwt-code-reviews.appspot.com/1072801/diff/1/2 File user/src/com/google/gwt/user/cellview/client/AbstractHasData.java (right): http://gwt-code-reviews.appspot.com/1072801/diff/1/2#newcode373 user/src/com/google/gwt/user/cellview/client/AbstractHasData.java:373: * Return the outer element t

[gwt-contrib] Re: Adding a public method AbstractHasData#getRowContainer() to give users access to the element tha... (issue1072801)

LGTM http://gwt-code-reviews.appspot.com/1072801/diff/1/2 File user/src/com/google/gwt/user/cellview/client/AbstractHasData.java (right): http://gwt-code-reviews.appspot.com/1072801/diff/1/2#newcode373 user/src/com/google/gwt/user/cellview/client/AbstractHasData.java:373: * Return the outer ele

[gwt-contrib] Adding a public method AbstractHasData#getRowContainer() to give users access to the element tha... (issue1072801)

Reviewers: rchandia, Description: Adding a public method AbstractHasData#getRowContainer() to give users access to the element that contains all rendered row values. The new public methods delegates to the abstract method getChildContainer(). Making the protected method public would be a breaking

Re: [gwt-contrib] Re: CellTree keyProvider value not used in GWT 2.1.0 RC

Thanks for catching this. I just sent a patch for review. http://gwt-code-reviews.appspot.com/1070801 Thanks, John LaBanca jlaba...@google.com On Mon, Nov 1, 2010 at 10:49 AM, yves wrote: > In the meantime I made the change in a local copy of the

[gwt-contrib] Add DataColumn class to encapsulate a column of AbstractDataTable (issue1071801)

Reviewers: zundel, daniel.libicki, Description: This is to allow using a column as if it's a java.util.List, as well as some column-related utility methods. In our offline discussion, adding it to the open source is one alternative. The concern against adding it to open source: We don't want to

[gwt-contrib] Fixing a bug in CellTree where we always pass null as the key for the rendered object instead of... (issue1070801)

Reviewers: pdr, Description: Fixing a bug in CellTree where we always pass null as the key for the rendered object instead of passing the key. Please review this at http://gwt-code-reviews.appspot.com/1070801/show Affected files: M user/src/com/google/gwt/user/cellview/client/CellTreeNodeVie

[gwt-contrib] Re: CellTree keyProvider value not used in GWT 2.1.0 RC

In the meantime I made the change in a local copy of the file CellTreeNodeView.java and compiled it with my files. => It works as expected. The change I made is : replace the line cell.render(value, null, cellBuilder) by cell.render(value, key, cellBuilder) HTH Yves On 31 oct, 18:01, yves wrote

[gwt-contrib] [google-web-toolkit] r9170 committed - Edited wiki page AutoBean through web user interface.

Revision: 9170 Author: b...@google.com Date: Mon Nov 1 07:15:16 2010 Log: Edited wiki page AutoBean through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=9170 Modified: /wiki/AutoBean.wiki === --- /wiki/AutoBean.wiki Fri Oct

[gwt-contrib] CellTree keyProvider value not used in GWT 2.1.0 RC

Hi, While developping a CellTree I found that the function render() in class CellTreeNodeView.NodeCellList calls render() of the Cell object always with a null value for the "key" parameter (cell.render(value, null, cellBuilder)). Is it a bug or is it intended to be like that ? It would be usefu

[gwt-contrib] Fwd: Fix AbstractDataTable.getValueTimeOfDay() to handle null (issue1067801)

Failed to deliver probably because I didn't join this group. Sending again. -- Forwarded message -- From: Date: Sat, Oct 30, 2010 at 11:10 AM Subject: Fix AbstractDataTable.getValueTimeOfDay() to handle null (issue1067801) To: zun...@google.com Cc: google-web-toolkit-contributors@

[gwt-contrib] Re: Fix AbstractDataTable.getValueTimeOfDay() to handle null (issue1067801)

So it was embarrassing. I submitted the Comparable change but it broke the build because it uses @Override on compareTo(), which is only supported since Java 6. I removed the @Override and committed using "--file ", trying to submit just that one fix. But svn went ahead and submitted this change

[gwt-contrib] Re: Comment on RpcDirectEval in google-web-toolkit

Comment by t.broyer: Yes, since GWT 2.0: http://code.google.com/webtoolkit/doc/latest/DevGuideServerCommunication.html#DevGuideDeRPC For more information: http://code.google.com/p/google-web-toolkit/wiki/RpcDirectEval -- http://groups.google.com/group/Google-Web-Toolkit-Contributors