Revision: 9524
Author: zun...@google.com
Date: Tue Jan 11 19:35:02 2011
Log: Adds some documentation on TypeOracle and JType
Review at http://gwt-code-reviews.appspot.com/1268801
http://code.google.com/p/google-web-toolkit/source/detail?r=9524
Modified:
/trunk/dev/core/src/com/google/gwt/core/
http://gwt-code-reviews.appspot.com/1251801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1251801/diff/11001/12009
File
user/src/com/google/gwt/user/server/rpc/XsrfTokenServiceServlet.java
(right):
http://gwt-code-reviews.appspot.com/1251801/diff/11001/12009#newcode192
user/src/com/google/gwt/user/server/rpc/XsrfTokenServiceServlet.java:192:
setCoo
http://gwt-code-reviews.appspot.com/1277801/diff/5001/6001
File plugins/npapi/NPVariantWrapper.h (right):
http://gwt-code-reviews.appspot.com/1277801/diff/5001/6001#newcode105
plugins/npapi/NPVariantWrapper.h:105: if (isInt(variant)) {
Yes, I would never expect modf to be faster than the cast, a
http://gwt-code-reviews.appspot.com/1277801/diff/5001/6001
File plugins/npapi/NPVariantWrapper.h (right):
http://gwt-code-reviews.appspot.com/1277801/diff/5001/6001#newcode105
plugins/npapi/NPVariantWrapper.h:105: if (isInt(variant)) {
On 2011/01/12 00:43:50, fabiomfv wrote:
my concern with thi
Do similar changes need to be made in Editor, and are you up for that?
Bob, are you able to take this review?
On Sun, Jan 9, 2011 at 5:01 AM, wrote:
>
> http://gwt-code-reviews.appspot.com/1272801/diff/1/3
> File user/src/com/google/gwt/autobean/server/BeanMethod.java (right):
>
> http://gwt-co
LGTM
http://gwt-code-reviews.appspot.com/1267801/diff/10001/11106
File
user/test/org/hibernate/jsr303/tck/tests/constraints/application/TckTest.gwt.xml
(right):
http://gwt-code-reviews.appspot.com/1267801/diff/10001/11106#newcode22
user/test/org/hibernate/jsr303/tck/tests/constraints/applicatio
http://gwt-code-reviews.appspot.com/1267801/diff/10001/11106
File
user/test/org/hibernate/jsr303/tck/tests/constraints/application/TckTest.gwt.xml
(right):
http://gwt-code-reviews.appspot.com/1267801/diff/10001/11106#newcode22
user/test/org/hibernate/jsr303/tck/tests/constraints/application/TckT
http://gwt-code-reviews.appspot.com/1277801/diff/5001/6001
File plugins/npapi/NPVariantWrapper.h (right):
http://gwt-code-reviews.appspot.com/1277801/diff/5001/6001#newcode105
plugins/npapi/NPVariantWrapper.h:105: if (isInt(variant)) {
my concern with this is something I chatted with Jat a coupl
http://gwt-code-reviews.appspot.com/1267801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Not sure I understand the question. what you mean by stock browser? there
are other issues that need to be addressed by the browser for us to be able
to have a fully functional plugin in android. as mentioned, the double issue
is minor in and was addressed by changed made in the android version of
LGTM
http://gwt-code-reviews.appspot.com/1269801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1269801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1269801/diff/1/5
File plugins/xpcom/JavaObject.cpp (right):
http://gwt-code-reviews.appspot.com/1269801/diff/1/5#newcode154
plugins/xpcom/JavaObject.cpp:154: if ((JS_GetStringEncodingLength(ctx,
str) == 8) && !strncmp("toString",
On 2011/01/11 21:22:30, jat wr
http://gwt-code-reviews.appspot.com/1278801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Tue, Jan 11, 2011 at 6:21 PM, Fabio Valbuena wrote:
> I have been using a 'custom' build android webkit with a couple of
> workarounds and the double issue is actually quite minor in the android
> case; I am using a change that works around the double issue.
Right, but wouldn't this allow yo
Reviewers: jat,
Description:
At application startup, assert that the specified user.agent selection
property value indeed matches the expected value for the executing
browser / user agent, thus avoid long hours debugging strange error
messages when a single user agent compile, typically created f
I have been using a 'custom' build android webkit with a couple of
workarounds and the double issue is actually quite minor in the android
case; I am using a change that works around the double issue.
On Tue, Jan 11, 2011 at 4:17 PM, wrote:
> LGTM
>
> This should solve Fabio's issue with the An
http://gwt-code-reviews.appspot.com/1277801/diff/1/3
File plugins/npapi/NPVariantWrapper.h (right):
http://gwt-code-reviews.appspot.com/1277801/diff/1/3#newcode105
plugins/npapi/NPVariantWrapper.h:105: // numerical variants out of V8.
On 2011/01/11 21:17:27, jat wrote:
Have we talked to them ab
http://gwt-code-reviews.appspot.com/1277801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1268801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/01/11 22:13:48, Konstantin.Scheglov wrote:
In reality, as I can see from patch, there are no UiBinder specific
check,
just design-time check. But probably would be good to add UiBinder
specific
check to avoid unnecessary rebinding other classes.
Yes, but the design-time check i
On 2011/01/11 18:00:42, jbrosenberg wrote:
I'm not sure I understand the larger picture, but I think there are
some issues
with this approach. Perhaps we can connect up to discuss
furtherHere are
some of the main points to consider:
1. StandardRebindOracle should not know anything spe
LGTM
http://gwt-code-reviews.appspot.com/1269801/diff/1/5
File plugins/xpcom/JavaObject.cpp (right):
http://gwt-code-reviews.appspot.com/1269801/diff/1/5#newcode154
plugins/xpcom/JavaObject.cpp:154: if ((JS_GetStringEncodingLength(ctx,
str) == 8) && !strncmp("toString",
It might be worth doing
LGTM
This should solve Fabio's issue with the Android browser as well, right?
http://gwt-code-reviews.appspot.com/1277801/diff/1/3
File plugins/npapi/NPVariantWrapper.h (right):
http://gwt-code-reviews.appspot.com/1277801/diff/1/3#newcode105
plugins/npapi/NPVariantWrapper.h:105: // numerical v
http://gwt-code-reviews.appspot.com/1269801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1269801/diff/1/4
File plugins/xpcom/FFSessionHandler.h (left):
http://gwt-code-reviews.appspot.com/1269801/diff/1/4#oldcode71
plugins/xpcom/FFSessionHandler.h:71: inline Debug::DebugStream&
operator<<(Debug::DebugStream& dbg, JSString* str) {
On 2011/01/11 21:
After a very hot local discussion :) we came to conclusion that we don't
need CCLM to maintain ModuleDefs cache and can use HARD,SOFT map for
top-level cache and ordinary map for moduleName->ModuleDef cache. I'll
upload a new patch shortly.
http://gwt-code-reviews.appspot.com/1274801/show
--
htt
Reviewers: jat, fabiomfv,
Description:
fix for NPVariant numbers. (new webkit v8 bindings give us doubles for
ints)
Issue: http://code.google.com/p/google-web-toolkit/issues/detail?id=5778
Breaking WebKit change: http://trac.webkit.org/changeset/72974
Please review this at http://gwt-code-revi
LGTM
http://gwt-code-reviews.appspot.com/1269801/diff/1/4
File plugins/xpcom/FFSessionHandler.h (left):
http://gwt-code-reviews.appspot.com/1269801/diff/1/4#oldcode71
plugins/xpcom/FFSessionHandler.h:71: inline Debug::DebugStream&
operator<<(Debug::DebugStream& dbg, JSString* str) {
Why remove
Revision: 9521
Author: p...@google.com
Date: Tue Jan 11 12:44:47 2011
Log: Creating releases/2.2
http://code.google.com/p/google-web-toolkit/source/detail?r=9521
Added:
/releases/2.2
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
They are, Rietveld is just lame
On Tue, Jan 11, 2011 at 11:09 AM, wrote:
> LGTM,
> except these should be moves not adds, to preserve history.
>
>
> http://gwt-code-reviews.appspot.com/1276801/show
>
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1268801/diff/7001/1003
File dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java (right):
http://gwt-code-reviews.appspot.com/1268801/diff/7001/1003#newcode24
dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java:24: * Returns
this type with no type ann
http://gwt-code-reviews.appspot.com/1268801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/01/11 16:21:50, scottb wrote:
Generally, can you justify this scheme? I read the article, but I
still don't
understand the advantage of this approach over say, Map
?> where
the key is weak.
Problem happens when you have reference from "value" to "key".
For example, if you try t
LGTM,
except these should be moves not adds, to preserve history.
http://gwt-code-reviews.appspot.com/1276801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
The module definitions need some more work now that the super source
files are in test-super
http://gwt-code-reviews.appspot.com/1267801/diff/10001/11106
File
user/test/org/hibernate/jsr303/tck/tests/constraints/application/TckTest.gwt.xml
(right):
http://gwt-code-reviews.appspot.com/1267801/di
Reviewers: rjrjr, Nick Chalko,
Description:
Move the validation test cases that depend on reflection out of a
client-scoped package.
This will remove a spurious compile error.
Fix MinValidatorForStringTest.
Patch by: bobv
Review by: rjrjr, nchalko
Please review this at http://gwt-code-reviews.a
http://gwt-code-reviews.appspot.com/1267801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I'm not sure I understand the larger picture, but I think there are some
issues with this approach. Perhaps we can connect up to discuss
furtherHere are some of the main points to consider:
1. StandardRebindOracle should not know anything specific about a
specific generator, so SRO is not th
Mostly LGTM.
http://gwt-code-reviews.appspot.com/1268801/diff/7001/1003
File dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java (right):
http://gwt-code-reviews.appspot.com/1268801/diff/7001/1003#newcode24
dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java:24: * Returns
this type wi
Generally, can you justify this scheme? I read the article, but I still
don't understand the advantage of this approach over say,
Map where the key is weak.
Functionally, the biggest problem is that it looks like we were holding
ModuleDefs with soft references, but now they're being held with we
Hi,
we are using a TimePicker with maxStep/minStep set to 5mn (for the
minutes only, we keep 1hour for hours).
It's works exactly as expected BUT, sometimes (often, must I say) if
we firstly click spinner down, the decrement is not of 5mn but 1mn.
Then, if we up/down, the 5 step is used.
Is this bu
Reviewers: jat,
Description:
Optimizations for server-side invocations of CustomFieldSerializers.
Please review this at http://gwt-code-reviews.appspot.com/1273801/show
Affected files:
A user/src/com/google/gwt/user/client/rpc/CustomFieldSerializer.java
M
user/src/com/google/gwt/user/cli
44 matches
Mail list logo
