I support the overall idea.
A few notes though:
I'm worried about the events in the ButtonCell example. If they're just
there to provide hooks to inject styles, then:
1. you probably don't need them if you use a "native button" appearance;
which means you're listening to events but doing
http://gwt-code-reviews.appspot.com/1365801/diff/1/dev/core/src/com/google/gwt/dev/javac/Dependencies.java
File dev/core/src/com/google/gwt/dev/javac/Dependencies.java (right):
http://gwt-code-reviews.appspot.com/1365801/diff/1/dev/core/src/com/google/gwt/dev/javac/Dependencies.java#newcode63
de
Revision: 9772
Author: b...@google.com
Date: Thu Feb 24 12:41:17 2011
Log: Fix cast problem in JsonRpcPayloadDialect.
The RequestFactory doesn't implement EnumMap, it's the internal
AutoBeanFactory.
Patch by: bobv
Review by: jasonhall
http://code.google.com/p/google-web-toolkit/source/detail?r
Revision: 9771
Author: jlaba...@google.com
Date: Thu Feb 24 14:23:24 2011
Log: Edited wiki page CellBackedWIdgets through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=9771
Modified:
/wiki/CellBackedWIdgets.wiki
===
--- /wiki
GWT Contributors -
I drafted a proposal for a new pattern that the GWT team will use to replace
existing GWT widgets with newer, shinier widgets. The proposal hits on the
major pain points that users have with existing widgets:
- Replace the styles of a widget instance
- Replace the DOM st
Revision: 9770
Author: jlaba...@google.com
Date: Thu Feb 24 14:21:05 2011
Log: Edited wiki page CellBackedWIdgets through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=9770
Modified:
/wiki/CellBackedWIdgets.wiki
===
--- /wiki
Revision: 9769
Author: gwt.mirror...@gmail.com
Date: Thu Feb 24 14:17:12 2011
Log: Fixes a bug in serializing Dependencies.DirectRef and
uses the updated class signature hash computation in CompiledClass
Review at http://gwt-code-reviews.appspot.com/1365801
http://code.google.com/p/google-web-to
Revision: 9768
Author: jlaba...@google.com
Date: Thu Feb 24 14:00:08 2011
Log: Edited wiki page CellBackedWIdgets through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=9768
Modified:
/wiki/CellBackedWIdgets.wiki
===
--- /wiki
Revision: 9767
Author: jlaba...@google.com
Date: Thu Feb 24 13:59:40 2011
Log: Edited wiki page CellBackedWIdgets through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=9767
Modified:
/wiki/CellBackedWIdgets.wiki
===
--- /wiki
Revision: 9766
Author: jlaba...@google.com
Date: Thu Feb 24 13:59:13 2011
Log: Edited wiki page CellBackedWIdgets through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=9766
Modified:
/wiki/CellBackedWIdgets.wiki
===
--- /wiki
Revision: 9765
Author: jlaba...@google.com
Date: Thu Feb 24 13:46:49 2011
Log: Edited wiki page CellBackedWIdgets through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=9765
Modified:
/wiki/CellBackedWIdgets.wiki
===
--- /wiki
Revision: 9764
Author: jlaba...@google.com
Date: Thu Feb 24 13:09:51 2011
Log: Created wiki page through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=9764
Added:
/wiki/CellBackedWIdgets.wiki
===
--- /dev/null
+++ /wiki/CellB
Thank you for the patch!
LGTM with a few nits. Lets get this into 2.3 and end this travesty of
broken onload events forever :)
http://gwt-code-reviews.appspot.com/1353801/diff/1/user/src/com/google/gwt/user/client/ui/Frame.java
File user/src/com/google/gwt/user/client/ui/Frame.java (right):
ht
http://gwt-code-reviews.appspot.com/1365801/diff/1/dev/core/src/com/google/gwt/dev/javac/Dependencies.java
File dev/core/src/com/google/gwt/dev/javac/Dependencies.java (right):
http://gwt-code-reviews.appspot.com/1365801/diff/1/dev/core/src/com/google/gwt/dev/javac/Dependencies.java#newcode63
de
LGTM
http://gwt-code-reviews.appspot.com/1365801/diff/1/dev/core/src/com/google/gwt/dev/javac/Dependencies.java
File dev/core/src/com/google/gwt/dev/javac/Dependencies.java (right):
http://gwt-code-reviews.appspot.com/1365801/diff/1/dev/core/src/com/google/gwt/dev/javac/Dependencies.java#newcod
Revision: 9763
Author: gwt.mirror...@gmail.com
Date: Thu Feb 24 08:59:36 2011
Log: Temporary hack to make DevMode refresh work. Since the file output in
the jar does not update
with DevMode refresh, we are taking the extremely hacky route of having
ensureInjected actually
install the contents
Reviewers: scottb, tobyr, jbrosenberg,
Description:
Fixes a bug in serializing Dependencies.DirectRef and
uses the updated class signature hash computation in CompiledClass
Please review this at http://gwt-code-reviews.appspot.com/1365801/
Affected files:
M dev/core/src/com/google/gwt/dev/ja
Revision: 9762
Author: fre...@google.com
Date: Thu Feb 24 06:41:44 2011
Log: Prevent developer's BODY { text-align: center; } from mucking up dev
mode exception light box
Review by: j...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9762
Modified:
/trunk/dev/core/src
Revision: 9761
Author: b...@google.com
Date: Thu Feb 24 03:33:17 2011
Log: Add additional data to ServerFailure for JSON-RPC payload dialect.
Patch by: bobv
Review by: jasonhall
http://code.google.com/p/google-web-toolkit/source/detail?r=9761
Modified:
/trunk/user/src/com/google/gwt/requestfa
Reviewers: rjrjr, bobv,
Description:
Issue 6076: EditorDelegate's getPath wrong when subeditor referenced
with dotted @Path annotation
http://code.google.com/p/google-web-toolkit/issues/detail?id=6076
AbstractEditorDriverGenerator incorrectly used getPropertyName instead
of getDeclaredPath to g
Reviewers: rjrjr, bobv,
Description:
Issue 6066: RequestFactoryEditorDriver failing to collect dotted path in
@Path annotation
http://code.google.com/p/google-web-toolkit/issues/detail?id=6066
PathCollection only ignores a path when the edited type is a value type
AND the absolute path does
21 matches
Mail list logo
