LGTM
http://gwt-code-reviews.appspot.com/1374803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1374803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1374803/diff/20/user/src/com/google/gwt/storage/client/StorageImplNonNativeEvents.java
File
user/src/com/google/gwt/storage/client/StorageImplNonNativeEvents.java
(right):
http://gwt-code-reviews.appspot.com/1374803/diff/20/user/src/com/google/gwt/storage/clie
Revision: 9813
Author: zun...@google.com
Date: Fri Mar 4 11:00:07 2011
Log: Adds unit tests for extending JavaScriptObject. Tests a loosening of
the
restriction for mulitple JSOs implementing the same interface added in
http://gwt-code-reviews.appspot.com/1373803/
Review at http://gwt-code-
committed as r9814
http://gwt-code-reviews.appspot.com/1370801/diff/7001/user/src/com/google/gwt/touch/client/Momentum.java
File user/src/com/google/gwt/touch/client/Momentum.java (right):
http://gwt-code-reviews.appspot.com/1370801/diff/7001/user/src/com/google/gwt/touch/client/Momentum.java#n
LGTM
I didn't look through the sample templates src files closely, but I'm
assuming they haven't materially changed.
http://gwt-code-reviews.appspot.com/1371808/diff/1/user/src/com/google/gwt/user/tools/WebAppCreator.java
File user/src/com/google/gwt/user/tools/WebAppCreator.java (right):
http
http://gwt-code-reviews.appspot.com/1355805/diff/6003/user/src/com/google/gwt/animation/client/AnimationImplWebkitAnimTiming.java
File
user/src/com/google/gwt/animation/client/AnimationImplWebkitAnimTiming.java
(right):
http://gwt-code-reviews.appspot.com/1355805/diff/6003/user/src/com/google/gw
http://gwt-code-reviews.appspot.com/1355805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I ran the AnimationTest in prod mode in Chrome 9 (stable), 10 (beta) and
11 (dev), as well as Firefox 4b12, IE8, Opera 11 and Safari 5.
I also checked that the moz- (resp. webkit-) -specific implementation
was correctly stripped out of the webkit (resp. gecko1_8) permutations.
http://gwt-code-r
Some comments of my own to kick off the discussion.
http://gwt-code-reviews.appspot.com/1375802/diff/1/dev/core/src/com/google/gwt/dev/DevModeBase.java
File dev/core/src/com/google/gwt/dev/DevModeBase.java (right):
http://gwt-code-reviews.appspot.com/1375802/diff/1/dev/core/src/com/google/gwt/d
Comment by jfgmaitl...@googlemail.com:
Would it be possible to update the ButtonCell code to include how to handle
the native events and call the onHover, onPush, onUnpush and onUnhover
methods on the Appearance?
For more information:
http://code.google.com/p/google-web-toolkit/wiki/CellBac
11 matches
Mail list logo