On 2011/03/16 05:29:29, Nick Chalko wrote:
Ok, tests are passing now. Please take a look.
http://gwt-code-reviews.appspot.com/1388801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1388801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1388801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rchandia,
Description:
Add Support for @ReportAsSingleViolation.
[JSR 303 TCK Result] 119 of 257 (46.30%) Pass with 12 Failures and 8
Errors.
Please review this at http://gwt-code-reviews.appspot.com/1388801/
Affected files:
M
user/src/com/google/gwt/validation/client/impl/Abst
Thanks, will add doc.
http://gwt-code-reviews.appspot.com/1384804/diff/1/dev/core/src/com/google/gwt/dev/util/collect/HashMap.java
File dev/core/src/com/google/gwt/dev/util/collect/HashMap.java (right):
http://gwt-code-reviews.appspot.com/1384804/diff/1/dev/core/src/com/google/gwt/dev/util/coll
LGTM
http://gwt-code-reviews.appspot.com/1384804/diff/1/dev/core/src/com/google/gwt/dev/util/collect/HashMap.java
File dev/core/src/com/google/gwt/dev/util/collect/HashMap.java (right):
http://gwt-code-reviews.appspot.com/1384804/diff/1/dev/core/src/com/google/gwt/dev/util/collect/HashMap.java#
http://gwt-code-reviews.appspot.com/1385803/diff/2002/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
(right):
http://gwt-code-reviews.appspot.com/1385803/diff/2002/dev/core/src/com/google/gwt/dev/jjs/JavaTo
http://gwt-code-reviews.appspot.com/1385803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1385803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: scottb,
Description:
Operations like i += d where i is an int and d is a double are not
properly
truncated (narrowed) to the LHS type. This patch forces i += d to be
written as
i = i + d, and applies a narrowing cast as needed, e.g. i = (int)(i +
d);
Updated to fix String concat issue
http://gwt-code-reviews.appspot.com/1384802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I think I now understand the high-level design. Definitely seems
workable, and probably pretty fast, too. Just a lot of nits to work
out, I think.
http://gwt-code-reviews.appspot.com/1375802/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
File dev/core/src/com/google/
Minor nits, overall looks like a good refactoring.
http://gwt-code-reviews.appspot.com/1375802/diff/9001/dev/core/src/com/google/gwt/dev/GWTCompiler.java
File dev/core/src/com/google/gwt/dev/GWTCompiler.java (right):
http://gwt-code-reviews.appspot.com/1375802/diff/9001/dev/core/src/com/google/
Couple more comments after reading Jason's feedback.
http://gwt-code-reviews.appspot.com/1375802/diff/9001/dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java
File dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java
(right):
http://gwt-code-reviews.appspot.com/1375802/diff
Reviewers: zundel,
Message:
(I ran into a bug while debugging your PersistentUnitCache patch.)
Due to a bug in com.google.gwt.dev.util.collect.HashMap.put(), we were
eagerly growing the underlying table even when the key was already
mapped. This causes an iterators to be invalidated on a non-st
Hi Scott:
I'm taking the opportunity to somewhat hijack this thread to ask a
question regarding this topic:
Is there an opportunity to use these internals to augment GWT testing
strategies?
Specifically, I'm wondering if the data structure generated during
compilation can be used to help baselin
On 2011/03/15 13:59:15, zundel wrote:
First, I want to let you know I put a lot of thought into where to put
the cache files and after discussions with Toby, we came up with the
WEB-INF solution.
There is precedent for putting the cache type files in WEB-INF (app
engine integration with GWT do
Revision: 9856
Author: ncha...@google.com
Date: Tue Mar 15 04:56:41 2011
Log: Test for compile failure if attributes don't match.
[JSR 303 TCK Result] 117 of 257 (45.53%) Pass with 14 Failures and 8 Errors.
Review at http://gwt-code-reviews.appspot.com/1384803
Review by: rchan...@google.com
htt
Revision: 9854
Author: jbrosenb...@google.com
Date: Mon Mar 14 11:04:13 2011
Log: Reintroduces JsInliner patch with minor tweaks, addresses issue 5707
(previously submitted by
cromwellian at rev 9362)
Review at http://gwt-code-reviews.appspot.com/1386801
http://code.google.com/p/google-web-to
Revision: 9855
Author: jbrosenb...@google.com
Date: Mon Mar 14 12:59:51 2011
Log: Rolling back jsinliner patch, issues have been identified
Review by: zun...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9855
Modified:
/trunk/dev/core/src/com/google/gwt/dev/js/JsInliner
Revision: 9853
Author: cromwell...@google.com
Date: Mon Mar 14 10:45:50 2011
Log: Overhaul overlay types.
In general, JSOs now treated like other Java types, except for
cast/instanceof
and instantiability.
1) Eliminate JavaScriptObjectNormalizer. JSO subtypes are no longer
rewritten as
JSO
Thanks, committed at r9850.
http://gwt-code-reviews.appspot.com/1382803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9852
Author: gwt.mirror...@gmail.com
Date: Tue Mar 15 07:55:50 2011
Log: Fixing touch scrolling support for devices that support it natively.
Our current touch support overrides native touch scrolling on tablets,
which breaks touch scrolling.
Review at http://gwt-code-reviews.appsp
Revision: 9851
Author: p...@google.com
Date: Mon Mar 14 09:06:35 2011
Log: Fix bug on IE where onload events don't fire for IFrames.
This is a bugfix for
http://code.google.com/p/google-web-toolkit/issues/detail?id=1720
Review at http://gwt-code-reviews.appspot.com/1294801
http://code.google.co
Add the base test class to RequestFactorySuite.
http://gwt-code-reviews.appspot.com/1384802/diff/4001/user/src/com/google/gwt/requestfactory/server/ServiceLayer.java
File user/src/com/google/gwt/requestfactory/server/ServiceLayer.java
(right):
http://gwt-code-reviews.appspot.com/1384802/diff/40
Revision: 9850
Author: gwt.mirror...@gmail.com
Date: Tue Mar 15 07:52:10 2011
Log: Fix generated JS for getting the locale property value from the
user agent.
Public review at: http://gwt-code-reviews.appspot.com/1382803/
Patch by: jat
Review by: jlabanca
http://code.google.com/p/google-web-too
I didn't respond to Scott's initial comments:
> - My gut reaction is that it's odd to make it a command-line option. It's not
> really a user-facing 'option' in the same way that draftCompile or
> style=PRETTY
> is, it's just an internal implementation detail. It would seem more like a
> jvm
>
LGTM
http://gwt-code-reviews.appspot.com/1384803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I posted my message in the GWT group first, but no responses.
https://groups.google.com/forum/#!topic/google-web-toolkit/2gWDTKw1tcA
The problem is because of a parsing error in this Feature.xml file, I can no
longer disable/enable other features in my eclipse environment. It is really
annoyi
29 matches
Mail list logo
