[gwt-contrib] [google-web-toolkit] r9887 committed - Start at adding media events for audio/video elements. Note, the under...

Revision: 9887 Author: fre...@google.com Date: Wed Mar 23 13:32:42 2011 Log: Start at adding media events for audio/video elements. Note, the underlying implementation for HTML5 media event handling is expected to change in the near future. Review at http://gwt-code-reviews.appspot.

[gwt-contrib] [google-web-toolkit] r9886 committed - tag the 2.3.0m1 release

Revision: 9886 Author: mrruss...@google.com Date: Wed Mar 23 16:19:00 2011 Log: tag the 2.3.0m1 release http://code.google.com/p/google-web-toolkit/source/detail?r=9886 Added: /tags/2.3.0-m1 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9885 committed - Using cached ZipFileClassPathEntry objects....

Revision: 9885 Author: scheg...@google.com Date: Wed Mar 23 12:56:08 2011 Log: Using cached ZipFileClassPathEntry objects. While this does not give benefits for DevMode, which parses jar files only once, GWT Designer does this many times. This gives about 15% speed up in GWT Designe

[gwt-contrib] Serialize GWT ASTs with CompilationUnits (issue1384807)

Reviewers: zundel, jbrosenberg, Description: When we persist CompilationUnits, persist the GWT AST too. Please review this at http://gwt-code-reviews.appspot.com/1384807/ Affected files: M dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java M dev/core/src/com/google/gwt/dev/jav

[gwt-contrib] [google-web-toolkit] r9884 committed - Making rendered Cells in CellWidgets fill the root element of the widg...

Revision: 9884 Author: jlaba...@google.com Date: Wed Mar 23 11:53:24 2011 Log: Making rendered Cells in CellWidgets fill the root element of the widget so that setting the height/width of the Widget applies to the Cell. Also making TextButton implement HasText so it can be used in

[gwt-contrib] [google-web-toolkit] r9883 committed - make -standardsMode the default for GwtTestCase....

Revision: 9883 Author: skybr...@google.com Date: Wed Mar 23 11:52:31 2011 Log: make -standardsMode the default for GwtTestCase. Review by: rj...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=9883 Modified: /trunk/user/src/com/google/gwt/junit/JUnitShell.java

[gwt-contrib] Re: Making rendered Cells in CellWidgets fill the root element of the widget so that setting the hei... (issue1383807)

http://gwt-code-reviews.appspot.com/1383807/diff/1/user/src/com/google/gwt/user/cellview/client/CellWidget.java File user/src/com/google/gwt/user/cellview/client/CellWidget.java (right): http://gwt-code-reviews.appspot.com/1383807/diff/1/user/src/com/google/gwt/user/cellview/client/CellWidget.ja

[gwt-contrib] [google-web-toolkit] r9882 committed - Fix JDK 1.6 dependency....

Revision: 9882 Author: j...@google.com Date: Wed Mar 23 11:44:28 2011 Log: Fix JDK 1.6 dependency. Patch by: jat Review by: drfibonacci http://code.google.com/p/google-web-toolkit/source/detail?r=9882 Modified: /trunk/user/test/com/google/gwt/requestfactory/shared/ServiceInheritan

[gwt-contrib] Re: Using cached ZipFileClassPathEntry objects. (issue1388803)

http://gwt-code-reviews.appspot.com/1388803/diff/3004/dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEntry.java File dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEntry.java (right): http://gwt-code-reviews.appspot.com/1388803/diff/3004/dev/core/src/com/google/gwt/

[gwt-contrib] Re: Using cached ZipFileClassPathEntry objects. (issue1388803)

LGTM http://gwt-code-reviews.appspot.com/1388803/diff/3004/dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEntry.java File dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEntry.java (right): http://gwt-code-reviews.appspot.com/1388803/diff/3004/dev/core/src/com/googl

[gwt-contrib] [google-web-toolkit] r9881 committed - Snip stray package-info from a dead package.

Revision: 9881 Author: rj...@google.com Date: Wed Mar 23 11:08:21 2011 Log: Snip stray package-info from a dead package. http://code.google.com/p/google-web-toolkit/source/detail?r=9881 Deleted: /trunk/user/src/com/google/gwt/app -- http://groups.google.com/group/Google-Web-Toolkit-

[gwt-contrib] We're still JRE 1.5 compatible a bit longer. And snip unthrown exception warning. (issue1388805)

Reviewers: drfibonacci, Description: We're still JRE 1.5 compatible a bit longer. And snip unthrown exception warning. Please review this at http://gwt-code-reviews.appspot.com/1388805/ Affected files: M user/test/com/google/gwt/requestfactory/shared/ServiceInheritanceTest.java Index:

[gwt-contrib] Re: Using cached ZipFileClassPathEntry objects. (issue1388803)

http://gwt-code-reviews.appspot.com/1388803/diff/7002/dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEntry.java File dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEntry.java (right): http://gwt-code-reviews.appspot.com/1388803/diff/7002/dev/core/src/com/google/gwt/

[gwt-contrib] Re: Using cached ZipFileClassPathEntry objects. (issue1388803)

LGTM http://gwt-code-reviews.appspot.com/1388803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add SafeUri type, similar to SafeHtml but for values in a URL attribute context. (issue1380806)

http://gwt-code-reviews.appspot.com/1380806/diff/1/user/src/com/google/gwt/cell/client/ImageCell.java File user/src/com/google/gwt/cell/client/ImageCell.java (right): http://gwt-code-reviews.appspot.com/1380806/diff/1/user/src/com/google/gwt/cell/client/ImageCell.java#newcode58 user/src/com/goog

[gwt-contrib] Re: Using cached ZipFileClassPathEntry objects. (issue1388803)

http://gwt-code-reviews.appspot.com/1388803/diff/3004/dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEntry.java File dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEntry.java (right): http://gwt-code-reviews.appspot.com/1388803/diff/3004/dev/core/src/com/google/gwt/

[gwt-contrib] Re: Using cached ZipFileClassPathEntry objects. (issue1388803)

http://gwt-code-reviews.appspot.com/1388803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds a cache (PersistenUnitCache) to store CompilationUnits (issue1375802)

On Wed, Mar 23, 2011 at 1:02 PM, Eric Ayers wrote: > FYI: I am adding a call to return the resource location to the > CompilationUnit to handle changing the key. That's what CompilationUnitBuilder.getLocation() was used for and in practice, CompilationUnit.getDisplayLocation() returns exactly t

[gwt-contrib] Re: Making rendered Cells in CellWidgets fill the root element of the widget so that setting the hei... (issue1383807)

On 2011/03/23 19:28:33, jlabanca wrote: LGTM if you add a test of the sizing changes for CellWidget http://gwt-code-reviews.appspot.com/1383807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Move com.google.gwt.requestfactory to com.google.requestfactory (issue1383808)

Reviewers: robertvawter, Description: Move com.google.gwt.requestfactory to com.google.requestfactory Keep a deprecated version in the old location Add targets for requestfactory client, server, and JRE test jars Please review this at http://gwt-code-reviews.appspot.com/1383808/ Affected files

[gwt-contrib] [google-web-toolkit] r9880 committed - Fixing issue 5807 on server side, new issue due to rietveld problems...

Revision: 9880 Author: drfibona...@google.com Date: Wed Mar 23 09:23:21 2011 Log: Fixing issue 5807 on server side, new issue due to rietveld problems Formerly at 1384802 Review at http://gwt-code-reviews.appspot.com/1384806 http://code.google.com/p/google-web-toolkit/source/detail

[gwt-contrib] Making rendered Cells in CellWidgets fill the root element of the widget so that setting the hei... (issue1383807)

Reviewers: pdr, Description: Making rendered Cells in CellWidgets fill the root element of the widget so that setting the height/width of the Widget applies to the Cell. Also making TextButton implement HasText so it can be used in UiBinder files with a default string. Please review this at htt

[gwt-contrib] Re: Using cached ZipFileClassPathEntry objects. (issue1388803)

I'm not sure I understand why you say an IdentityHashMap is "weak" by definition, can you explain? http://gwt-code-reviews.appspot.com/1388803/diff/3004/dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEntry.java File dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEnt

Re: [gwt-contrib] Questions on the process of issue fixing.

There's http://code.google.com/p/google-web-toolkit/wiki/BugTriageProcess but it's probably not up to date. @GWT Team: How about updating the "people list" with each developer's "duties" and linking to it from the "making GWT better" page? -- http://groups.google.com/group/Google-Web-Toolkit-C

Re: [gwt-contrib] Questions on the process of issue fixing.

There's already the "show more" of CellBrowser / CellTree and text in the SimplePager. We shipped our first milestone Monday and our customer already asked us to translate that "show more", so it's going to be an issue soon (we have the whole dataset ready though, so it's rather a bug in our co

[gwt-contrib] Re: Adding a new TextButton widget to replace the existing Button widget. The new widget provides th... (issue1383806)

LGTM2 On 2011/03/23 18:07:02, rjrjr wrote: LGTM This is pretty exciting. On Wed, Mar 23, 2011 at 11:05 AM, wrote: > Moving the Default/Negative/Primary Decorations into DefaultAppearance > makes the API much cleaner. > > First, I removed all of the static fa

[gwt-contrib] Re: Add SafeUri type, similar to SafeHtml but for values in a URL attribute context. (issue1380806)

On Wed, Mar 23, 2011 at 09:54, Ray Ryan wrote: > Christoph, can you take this review? > > Sure, I'll take it. > On Sat, Mar 19, 2011 at 10:04 AM, wrote: > > I tried to limit the changes to non-formatting ones. I also didn't go as > > far as http://gwt-code-reviews.appspot.com/1384801 wrt erro

Re: [gwt-contrib] Re: [RFC] GWT Widgets that ROCK!

On Wed, Mar 23, 2011 at 2:18 PM, Philippe Beaudoin < philippe.beaud...@gmail.com> wrote: > Nice. And will you have the shorter: > > For permutations that are guaranteed to support it? > Eventually... maybe. When we drop support for older versions of webkit and FF, we could switch those to lose

[gwt-contrib] Re: [RFC] GWT Widgets that ROCK!

I'm really looking forward to the new widgets. Sounds extremely promising! 2011/3/23 John LaBanca > @dflorey - > > We do plan to include some HTML5 widgets using the Appearance pattern. > HTML5 widgets follow a cool pattern where you can inline the fallback into > the HTML5 element. Browsers t

Re: [gwt-contrib] Re: [RFC] GWT Widgets that ROCK!

Nice. And will you have the shorter: For permutations that are guaranteed to support it? On Wed, Mar 23, 2011 at 11:11 AM, John LaBanca wrote: > @dflorey - > We do plan to include some HTML5 widgets using the Appearance pattern. >  HTML5 widgets follow a cool pattern where you can inline the f

[gwt-contrib] Re: [RFC] GWT Widgets that ROCK!

@dflorey - We do plan to include some HTML5 widgets using the Appearance pattern. HTML5 widgets follow a cool pattern where you can inline the fallback into the HTML5 element. Browsers that do not support the HTML5 element naturally show the fallback, while browsers that do support the HTML5 wid

[gwt-contrib] Re: Adding a new TextButton widget to replace the existing Button widget. The new widget provides th... (issue1383806)

LGTM This is pretty exciting. On Wed, Mar 23, 2011 at 11:05 AM, wrote: > Moving the Default/Negative/Primary Decorations into DefaultAppearance > makes the API much cleaner. > > First, I removed all of the static factory methods (but left some > JavaDoc explaining how to use the different const

[gwt-contrib] Re: Adding a new TextButton widget to replace the existing Button widget. The new widget provides th... (issue1383806)

Moving the Default/Negative/Primary Decorations into DefaultAppearance makes the API much cleaner. First, I removed all of the static factory methods (but left some JavaDoc explaining how to use the different constructors). Users can just use the default constructor, then call setDecoration() to

[gwt-contrib] Re: Adding a new TextButton widget to replace the existing Button widget. The new widget provides th... (issue1383806)

http://gwt-code-reviews.appspot.com/1383806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Questions on the process of issue fixing.

On Fri, Mar 18, 2011 at 6:44 PM, Antoine DESSAIGNE < antoine.dessai...@gmail.com> wrote: > Also I created new string messages that needs to be translated, but I > didn't do anything to allow GWT contributors to translate it. I can do the > French translation, but should I simply create the _FR.pro

Re: [gwt-contrib] Questions on the process of issue fixing.

If I'll patch some of my own issues or if the issue owner is not a Google guy which person would I select as reviewer? No one or a random one from the developer list http://code.google.com/p/google-web-toolkit/people/list (if this list is up to date)? Maybe it would be nice to fill in some info

[gwt-contrib] Re: Issue 1054 (issue1380807)

http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding a new TextButton widget to replace the existing Button widget. The new widget provides th... (issue1383806)

http://gwt-code-reviews.appspot.com/1383806/diff/13/user/src/com/google/gwt/cell/client/ButtonCellBase.java File user/src/com/google/gwt/cell/client/ButtonCellBase.java (right): http://gwt-code-reviews.appspot.com/1383806/diff/13/user/src/com/google/gwt/cell/client/ButtonCellBase.java#newcode53

[gwt-contrib] Issue 1054 (issue1380807)

Reviewers: rjrjr, Description: Issue 1054 Please review this at http://gwt-code-reviews.appspot.com/1380807/ Affected files: M user/src/com/google/gwt/user/RemoteService.gwt.xml M user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java M user/src/com/google/gwt/user/rebind/

[gwt-contrib] Issue 1054 (issue1386804)

Reviewers: robertvawter, Description: Issue 1054 Please review this at http://gwt-code-reviews.appspot.com/1386804/ Affected files: M user/src/com/google/gwt/user/RemoteService.gwt.xml M user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java M user/src/com/google/gwt/user/

[gwt-contrib] Re: Adding a new TextButton widget to replace the existing Button widget. The new widget provides th... (issue1383806)

http://gwt-code-reviews.appspot.com/1383806/diff/13/user/src/com/google/gwt/user/widget/client/ButtonBase.java File user/src/com/google/gwt/user/widget/client/ButtonBase.java (right): http://gwt-code-reviews.appspot.com/1383806/diff/13/user/src/com/google/gwt/user/widget/client/ButtonBase.java#n

[gwt-contrib] Re: Adds a cache (PersistenUnitCache) to store CompilationUnits (issue1375802)

On Wed, Mar 23, 2011 at 12:23 PM, Scott Blum wrote: > On Wed, Mar 23, 2011 at 9:57 AM, wrote: >> >> If we only write the cache to the same war dir subdirectory, then I >> think my concerns with purging the cache are solved (the cache will be >> in a well known place).  I'm still going to make an

[gwt-contrib] Re: Add SafeUri type, similar to SafeHtml but for values in a URL attribute context. (issue1380806)

Christoph, can you take this review? On Sat, Mar 19, 2011 at 10:04 AM, wrote: > I tried to limit the changes to non-formatting ones. I also didn't go as > far as http://gwt-code-reviews.appspot.com/1384801 wrt error handling to > limit the amount of changes and avoid merge conflicts (or make the

Re: [gwt-contrib] Re: [RFC] GWT Widgets that ROCK!

Antoine, I think the Appearance plan is closer to what you want than you realize. In particular, you should know that we're working on a change to UiBinder to allow it to generate SafeHtmlRenderer instances, and then to allow those instances to manage cell event handling. We'll share a design prop

[gwt-contrib] Re: Adds a cache (PersistenUnitCache) to store CompilationUnits (issue1375802)

On Wed, Mar 23, 2011 at 9:57 AM, wrote: > If we only write the cache to the same war dir subdirectory, then I > think my concerns with purging the cache are solved (the cache will be > in a well known place). I'm still going to make an exception so that > setting a system property will allow the

[gwt-contrib] Re: Fixing touch scrolling support for devices that support it natively. Our current touch support o... (issue1369809)

committed as r9852 http://gwt-code-reviews.appspot.com/1369809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Made UiBinder class lookup more generous. (issue1386803)

http://gwt-code-reviews.appspot.com/1386803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Made UiBinder class lookup more generous. (issue1386803)

Thanks, updated as suggested. http://gwt-code-reviews.appspot.com/1386803/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (right): http://gwt-code-reviews.appspot.com/1386803/diff/1/user/src/com/google/gwt/uibin

[gwt-contrib] [google-web-toolkit] r9877 committed - cherry picking r9861 into release/2.3m1

Revision: 9877 Author: fabio...@google.com Date: Wed Mar 23 05:27:01 2011 Log: cherry picking r9861 into release/2.3m1 http://code.google.com/p/google-web-toolkit/source/detail?r=9877 Modified: /releases/2.3/user/src/com/google/gwt/core/client/impl/Impl.java /releases/2.3/user/src/c

[gwt-contrib] Re: Adding a new TextButton widget to replace the existing Button widget. The new widget provides th... (issue1383806)

http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/cell/client/ButtonCellBase.java File user/src/com/google/gwt/cell/client/ButtonCellBase.java (right): http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/cell/client/ButtonCellBase.java#newcod

[gwt-contrib] Re: Adding a new TextButton widget to replace the existing Button widget. The new widget provides th... (issue1383806)

http://gwt-code-reviews.appspot.com/1383806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update partial support elements for ie9. (issue1389802)

LGTM http://gwt-code-reviews.appspot.com/1389802/diff/1/user/src/com/google/gwt/media/Media.gwt.xml File user/src/com/google/gwt/media/Media.gwt.xml (right): http://gwt-code-reviews.appspot.com/1389802/diff/1/user/src/com/google/gwt/media/Media.gwt.xml#newcode54 user/src/com/google/gwt/media/Me

[gwt-contrib] Update partial support elements for ie9. (issue1389802)

Reviewers: jlabanca, Description: Update partial support elements for ie9. Please review this at http://gwt-code-reviews.appspot.com/1389802/ Affected files: M user/src/com/google/gwt/canvas/Canvas.gwt.xml M user/src/com/google/gwt/media/Media.gwt.xml Index: user/src/com/google/gwt/canva

[gwt-contrib] Re: Ie9 fix. (issue1389801)

LGTM http://gwt-code-reviews.appspot.com/1389801/diff/1/user/test/com/google/gwt/dom/client/SelectTests.java File user/test/com/google/gwt/dom/client/SelectTests.java (right): http://gwt-code-reviews.appspot.com/1389801/diff/1/user/test/com/google/gwt/dom/client/SelectTests.java#newcode158 user

[gwt-contrib] Re: [RFC] GWT Widgets that ROCK!

I am wondering if you are considering to use html5 widgets if available and provide a fallback gwt implementation for browsers that do not (yet) support widgets like http://slides.html5rocks.com/#semantic-tags-2 I think in general GWT has the right tools for using native browser stuff whenever

[gwt-contrib] Re: Adds a cache (PersistenUnitCache) to store CompilationUnits (issue1375802)

On 2011/03/22 21:59:31, scottb wrote: High-level, my major issues at this point are: 1) MemoryUnitCache having anything to do with the on-disk cache. 2) Using PUC from entry points other than DevMode and Compiler (although we should seriously consider the JUnitShell use case). 3) Cachi

Re: [gwt-contrib] Re: [RFC] GWT Widgets that ROCK!

With the appearance pattern your proposed Theme class would be the same as a GWT module containing all the deferred bindings for changing all the appearance classes of all widgets. So you would inherit this theme module and you are done. I think you could also overwrite a specific deferred bind

Re: [gwt-contrib] Re: [RFC] GWT Widgets that ROCK!

Hi, I'm fairly new in the GWT development but I'm not sure that the selected development answers the initial need. Let me explain you why (sorry it is rather long). It is also very possible that I'm completely wrong. The main goal is allowing the developers to easily theme their application. As a