Reviewers: fabiomfv,
Description:
Fixing a few Cell Widget bugs. I combined these bugs because they are
all quick fixes and fairly straightforward.
(Issue 5971) CompositeCell does not implement isEditing. I implemented
isEditing in CompositeCell.
(Issue 5993) TextInputCell and EditTextCell dou
http://gwt-code-reviews.appspot.com/1370808/diff/14001/gadgets/src/com/google/gwt/gadgets/linker/computeUrlForGadgetResource.js
File
gadgets/src/com/google/gwt/gadgets/linker/computeUrlForGadgetResource.js
(right):
http://gwt-code-reviews.appspot.com/1370808/diff/14001/gadgets/src/com/google/gwt
http://gwt-code-reviews.appspot.com/1384801/diff/8001/user/src/com/google/gwt/safecss/shared/SafeStyles.java
File user/src/com/google/gwt/safecss/shared/SafeStyles.java (right):
http://gwt-code-reviews.appspot.com/1384801/diff/8001/user/src/com/google/gwt/safecss/shared/SafeStyles.java#newcode71
Comment by boj...@gmail.com:
However philosophically we speak, the fact is software will be modular. GWT
promotes building huge monolithic apps with no inherent plugability. If you
don't realize and fix this sooner, GWT will be on its death bed. OSGi is
getting so much focus that it would b
Revision: 9952
Author: r...@google.com
Date: Wed Apr 6 10:54:18 2011
Log: Change RequestFactoryMagic -> RequestFactorySource in comment
Review at http://gwt-code-reviews.appspot.com/1406801
Review by: robertvaw...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r
committed as r9925
http://gwt-code-reviews.appspot.com/1394802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I renamed SafeCssProperties to SafeStyles, but I left the package as
com.google.gwt.css so we can add more CSS support in the future (such as
support for CSS in a CSS file or a style tag). The generator now throws
an error if SafeStyles doesn't appear in the CSS_ATTRIBUTE_START
context.
http://g
LGTM
I think you probably meant "codec" rather than "codex", but I can
understand if this name change would be too much at this point.
I hate the word "reify", I don't really understand what it means and I
doubt 99% of our users will either. Can you add a juicy comment
somewhere that explains w
http://gwt-code-reviews.appspot.com/1384801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
r9948
http://gwt-code-reviews.appspot.com/1402801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9951
Author: schen...@google.com
Date: Wed Apr 6 09:03:10 2011
Log: Cherry picking r9950 into releases/2.3m1.
http://gwt-code-reviews.appspot.com/1386805/
http://code.google.com/p/google-web-toolkit/source/detail?r=9951
Added:
/releases/2.3/user/src/com/google/gwt/use
Patch updates the formatting to put a space between ] and { in array
initializers (see gwt_format.xml change in
http://gwt-code-reviews.appspot.com/1402803 )
http://gwt-code-reviews.appspot.com/1405801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9950
Author: schen...@google.com
Date: Wed Apr 6 07:57:12 2011
Log: Adding an empty interface to prevent the Google Plugin for
Eclipse from
marking XsrfProtectedService as missing an Async class.
Review at http://gwt-code-reviews.appspot.com/1386805
http://code.google.co
http://gwt-code-reviews.appspot.com/1405801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I have a requirement that our users should be able to dynamically create
groups of rows inside a celltable.
For example, lets say a user was searching for books, and wanted to group by
Author. The Author column should be hidden (this isn't a problem), but there
should be a new row with a colspa
On Wed, Apr 6, 2011 at 12:11 AM, John Tamplin wrote:
> On Tue, Apr 5, 2011 at 8:35 PM, Ray Ryan wrote:
>>
>> I don't think it's reasonable to ask Eric to tweak the auto formatter. We
>> had that conversation already. He's just doing the same thing we have
>> eclipse configured to do, right?
>
> W
http://gwt-code-reviews.appspot.com/1402803/diff/1/tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java
File
tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java
(right):
http://gwt-code-reviews.appspot.com/1402803/diff/1/tools/cldr-import/
http://gwt-code-reviews.appspot.com/1402803/diff/1/tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java
File
tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java
(right):
http://gwt-code-reviews.appspot.com/1402803/diff/1/tools/cldr-import/
http://gwt-code-reviews.appspot.com/1402803/diff/1/tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java
File
tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java
(right):
http://gwt-code-reviews.appspot.com/1402803/diff/1/tools/cldr-import/
I still the the assignment line breaks are really ugly this way, but if
others would rather avoid long lines no matter how ugly the result is, I
can go with it.
http://gwt-code-reviews.appspot.com/1402803/diff/6001/tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java
Reviewers: rice, rjrjr,
Description:
Convert AutoBeans to use JSOs as their backing store with lazy
reification of
values.
Use JsonSplittable in DevMode to avoid JSNI overhead.
Patch by: bobv
Review by: rice, rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1407802/
Affected fil
Revision: 9949
Author: b...@google.com
Date: Wed Apr 6 04:44:12 2011
Log: Reformat autobeans package to cut down on diff churn for lazy
reification patch.
Patch by: bobv
Review by: rice
Review at http://gwt-code-reviews.appspot.com/1407801
http://code.google.com/p/google-web-toolk
LGTM
http://gwt-code-reviews.appspot.com/1406801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1407801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rice,
Description:
Reformat autobeans package to cut down on diff churn for lazy
reification patch.
Patch by: bobv
Review by: rice
Please review this at http://gwt-code-reviews.appspot.com/1407801/
Affected files:
M
user/src/com/google/gwt/autobean/client/impl/AbstractAutoBeanFa
Reviewers: robertvawter,
Description:
Change RequestFactoryMagic -> RequestFactorySource in comment
Please review this at http://gwt-code-reviews.appspot.com/1406801/
Affected files:
M
user/src/com/google/web/bindery/requestfactory/server/testing/InProcessRequestTransport.java
Index:
Revision: 9948
Author: rj...@google.com
Date: Wed Apr 6 03:31:11 2011
Log: Temporarily introduces configuration property
UiBinder.useSafeHtmlTemplates to
allow UiBinder's SafeHtml integration to be disabled while the last
couple of kinks are worked out.
Review at http://gwt-code-re
http://gwt-code-reviews.appspot.com/1402803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
28 matches
Mail list logo
