[gwt-contrib] Fwd: Trying to address issue 6234 (Support RequestFactory service inheritance on the client) (issue1411802)

2011-04-09 Thread Johannes Tuchscherer
-- Forwarded message -- From: Date: Sun, Apr 10, 2011 at 00:13 Subject: Trying to address issue 6234 (Support RequestFactory service inheritance on the client) (issue1411802) To: jtuchsche...@gmail.com Cc: google-web-toolkit-contributors@googlegroups.com, re...@gwt-code-reviews.app

Re: [gwt-contrib] GWT Private/Protected Members

2011-04-09 Thread John Tamplin
On Mon, Apr 4, 2011 at 12:10 PM, Clécio Varjão wrote: > One of the most frustrating thing in OO is private methods. Specially > in an "open source" software, I believe there should not be private > methods (or avoided, and use only for essential code- e.g. > manipulating private fields). Protected

[gwt-contrib] GWT Private/Protected Members

2011-04-09 Thread Clécio Varjão
Hi All, One of the most frustrating thing in OO is private methods. Specially in an "open source" software, I believe there should not be private methods (or avoided, and use only for essential code- e.g. manipulating private fields). Protected methods could be used in favor of private methods, so

[gwt-contrib] Re: Issue 6193: Fix memory-leak in WeakMapping when the value holds a reference on the key (issue1401802)

2011-04-09 Thread t . broyer
I introduced an IsShim interface that all AutoBean shims (whether generated or VM proxies) implement to get the associated AutoBean back, instead of using WeakMapping. WeakMapping is now only used when the key is a wrapped object. This still causes a leak if the developer fails to unwrap() the obj