[gwt-contrib] Re: Calculates result of getSourceName() one time, so reuse because of CU cache. (issue1438801)

http://gwt-code-reviews.appspot.com/1438801/diff/3001/dev/core/test/com/google/gwt/dev/javac/CompiledClassTest.java File dev/core/test/com/google/gwt/dev/javac/CompiledClassTest.java (right): http://gwt-code-reviews.appspot.com/1438801/diff/3001/dev/core/test/com/google/gwt/dev/javac/CompiledCla

[gwt-contrib] Re: Calculates result of getSourceName() one time, so reuse because of CU cache. (issue1438801)

http://gwt-code-reviews.appspot.com/1438801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Calculates result of getSourceName() one time, so reuse because of CU cache. (issue1438801)

LGTM http://gwt-code-reviews.appspot.com/1438801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] rfc on 6068 fix

Bob V is the authority here, but he's on vacation this week. On Sun, May 8, 2011 at 7:08 AM, Patrick Julien wrote: > Here is what I am planning to do to fix issue 6068 > > http://code.google.com/p/google-web-toolkit/issues/detail?id=6068 > > 1. Add to BeanMethod.java (package > com.google.web.bi

[gwt-contrib] [google-web-toolkit] r10162 committed - Calculates result of getSourceName() one time, so reuse because of CU ...

Revision: 10162 Author: scheg...@google.com Date: Mon May 9 07:42:14 2011 Log: Calculates result of getSourceName() one time, so reuse because of CU cache. Prepares SAXParserFActory one time, so avoids expensive ClassLoader lookups. Review at http://gwt-code-reviews.appspot.com/143

[gwt-contrib] Disabling test for null on getBrowserById for DOM elements without DTD when running on Chrome 12 (issue1443801)

Reviewers: jat, Frank, Description: Disabling test for null on getBrowserById for DOM elements without DTD when running on Chrome 12 Please review this at http://gwt-code-reviews.appspot.com/1443801/ Affected files: M user/test/com/google/gwt/xml/client/XMLTest.java Index: user/test/com/go

[gwt-contrib] Re: Minor refactoring of "dashboard" interfaces in GWT. I'd made these changes this week in another ... (issue1439801)

http://gwt-code-reviews.appspot.com/1439801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10164 committed - Edited wiki page BeanValidation through web user interface.

Revision: 10164 Author: ncha...@google.com Date: Mon May 9 12:10:10 2011 Log: Edited wiki page BeanValidation through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=10164 Modified: /wiki/BeanValidation.wiki === ---

[gwt-contrib] [google-web-toolkit] r10165 committed - Introduces read only task view with an edit button. Gets around...

Revision: 10165 Author: rj...@google.com Date: Mon May 9 09:40:33 2011 Log: Introduces read only task view with an edit button. Gets around problems when we try to edit a TaskProxyImpl, which is unpossible. http://code.google.com/p/google-web-toolkit/source/detail?r=10165 Added:

[gwt-contrib] [google-web-toolkit] r10166 committed - Fix the transition direction between read and task views

Revision: 10166 Author: rj...@google.com Date: Mon May 9 10:10:43 2011 Log: Fix the transition direction between read and task views http://code.google.com/p/google-web-toolkit/source/detail?r=10166 Modified: /trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/

[gwt-contrib] Better error reporting (issue1444801)

Reviewers: jlabanca, Description: Better error reporting Please review this at http://gwt-code-reviews.appspot.com/1444801/ Affected files: M samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/App.java M samples/mobilewebapp/src/main/com/google/gwt/sample/mobileweb

[gwt-contrib] [google-web-toolkit] r10167 committed - Implementing custom TaskReadViews for tablet, desktop, and mobile.

Revision: 10167 Author: jlaba...@google.com Date: Mon May 9 10:25:15 2011 Log: Implementing custom TaskReadViews for tablet, desktop, and mobile. http://code.google.com/p/google-web-toolkit/source/detail?r=10167 Added: /trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mob

[gwt-contrib] Re: Better error reporting (issue1444801)

Not quite ready for review http://gwt-code-reviews.appspot.com/1444801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Better error reporting (issue1444801)

http://gwt-code-reviews.appspot.com/1444801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

I don't have the full context, but adding flakiness is not a good idea. According to the current code structure, if we want to make the variable non-static, we may need to pass the propertyOracle parameter to many methods, because shouldConsiderFieldsForSerialization method in SerializableTypeOr

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

On 2011/04/18 18:56:30, Stephen Chenney wrote: http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java File user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java (right): http://gwt-code-reviews.appspot.com/1

[gwt-contrib] Re: Disabling test for null on getBrowserById for DOM elements without DTD when running on Chrome 12 (issue1443801)

LGTM http://gwt-code-reviews.appspot.com/1443801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Better error reporting (issue1444801)

Verbal LGTM from John. r10167 On Mon, May 9, 2011 at 1:40 PM, wrote: > http://gwt-code-reviews.appspot.com/1444801/ > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Remove JProgram.jsniMap in favor of local accounting. (issue1445801)

Reviewers: jbrosenberg, cromwellian, Please review this at http://gwt-code-reviews.appspot.com/1445801/ Affected files: M dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java A dev/core/src/com/google/gwt/dev/jjs/ast/js/JsniClassLiteral.java M dev/core/src/com/google/gwt/dev/jjs/ast/js/