Re: [gwt-contrib] Re: Pruner runs only once. (issue1436802)

Sorry for the delay, spent most of today catching up after I/O, I will take care of these Friday. On Tue, May 10, 2011 at 6:44 PM, wrote: > This is ready for review now. > > http://gwt-code-reviews.appspot.com/1436802/ > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > -

[gwt-contrib] Re: Allows enum ordinalization to proceed for enums with static methods/fields (issue1428808)

It looks like I had some unpublished comments in this review, so just sending them out now. http://gwt-code-reviews.appspot.com/1428808/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/EnumOrdinalizerTest.java File dev/core/test/com/google/gwt/dev/jjs/impl/EnumOrdinalizerTest.java (right): http

[gwt-contrib] Re: Decentralize nullmethod/nullfield (issue1442802)

http://gwt-code-reviews.appspot.com/1442802/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java (right): http://gwt-code-reviews.appspot.com/1442802/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java#

[gwt-contrib] Re: Pruner runs only once. (issue1436802)

Can you clarify what you mean by "Pruner runs only once"? It looks like it will still be invoked multiple times by the optimizeLoop, etc. Can you provide some background on the "jitter" phenomena? http://gwt-code-reviews.appspot.com/1436802/ -- http://groups.google.com/group/Google-Web-Toolkit

[gwt-contrib] Re: Pruner runs only once. (issue1436802)

Some background - some optimizers run themselves in a loop on each pass of the optimizer. During some performance investigations last year, we tried to get some of these extra loops out, but Pruner was a tough nut to crack. The nasty thing about this looping behavior is that the last pass through

[gwt-contrib] Re: Allows enum ordinalization to proceed for enums with static methods/fields (issue1428808)

http://gwt-code-reviews.appspot.com/1428808/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/EnumOrdinalizerTest.java File dev/core/test/com/google/gwt/dev/jjs/impl/EnumOrdinalizerTest.java (right): http://gwt-code-reviews.appspot.com/1428808/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/Enum

[gwt-contrib] Re: Enables on the persistent unit cache by default. (issue1448801)

http://gwt-code-reviews.appspot.com/1448801/diff/1/dev/core/src/com/google/gwt/dev/javac/UnitCacheFactory.java File dev/core/src/com/google/gwt/dev/javac/UnitCacheFactory.java (right): http://gwt-code-reviews.appspot.com/1448801/diff/1/dev/core/src/com/google/gwt/dev/javac/UnitCacheFactory.java#

[gwt-contrib] Re: Decentralize nullmethod/nullfield (issue1442802)

http://gwt-code-reviews.appspot.com/1442802/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java (right): http://gwt-code-reviews.appspot.com/1442802/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java#

[gwt-contrib] Re: Enables on the persistent unit cache by default. (issue1448801)

http://gwt-code-reviews.appspot.com/1448801/diff/1/dev/core/src/com/google/gwt/dev/javac/UnitCacheFactory.java File dev/core/src/com/google/gwt/dev/javac/UnitCacheFactory.java (right): http://gwt-code-reviews.appspot.com/1448801/diff/1/dev/core/src/com/google/gwt/dev/javac/UnitCacheFactory.java#

[gwt-contrib] Re: Attachable elements in UiBinder: always run logicalAdd(Attachable) for Attachable widgets. (issue1446801)

LGTM http://gwt-code-reviews.appspot.com/1446801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Decentralize nullmethod/nullfield (issue1442802)

LGTM http://gwt-code-reviews.appspot.com/1442802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enables on the persistent unit cache by default. (issue1448801)

LGTM http://gwt-code-reviews.appspot.com/1448801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10182 committed - Attachable elements in UiBinder: always run logicalAdd(Attachable) for...

Revision: 10182 Author: jul...@google.com Date: Fri May 13 08:01:50 2011 Log: Attachable elements in UiBinder: always run logicalAdd(Attachable) for Attachable widgets. Before this patch, if we declared a in the UiBinder template and a corresponding @UiField(provided=true) field

[gwt-contrib] Re: Pruner runs only once. (issue1436802)

On Fri, May 13, 2011 at 11:15 AM, Eric Ayers wrote: > I've been reading the code and talking to Scott about it. The loop > being removed is the while() loop in execImpl(). The "jitter" is the > fact that the ControlFlowAnalyzer might return one result for liveness > before the Pruner runs, and

[gwt-contrib] [google-web-toolkit] r10183 committed - Decentralize nullmethod/nullfield....

Revision: 10183 Author: sco...@google.com Date: Fri May 13 08:44:36 2011 Log: Decentralize nullmethod/nullfield. http://gwt-code-reviews.appspot.com/1442802/ Review by: jbrosenb...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=10183 Modified: /trunk/dev/core

[gwt-contrib] Re: Enables on the persistent unit cache by default. (issue1448801)

LGTM http://gwt-code-reviews.appspot.com/1448801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: SafeHtmlRenderer code gen for UiBinder. Picking up issue 1426803 (issue1442804)

http://gwt-code-reviews.appspot.com/1442804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: SafeHtmlRenderer code gen for UiBinder. Picking up issue 1426803 (issue1442804)

http://gwt-code-reviews.appspot.com/1442804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: SafeHtmlRenderer code gen for UiBinder. Picking up issue 1426803 (issue1442804)

PTAL. Smoke tests pass. On 2011/05/13 19:16:42, rchandia wrote: http://gwt-code-reviews.appspot.com/1442804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fix various warnings. (issue1446804)

Reviewers: rice, Description: Fix various warnings. Please review this at http://gwt-code-reviews.appspot.com/1446804/ Affected files: M samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/activity/TaskListActivity.java M samples/mobilewebapp/src/main/com/google/gwt

[gwt-contrib] Re: Fix various warnings. (issue1446804)

LGTM http://gwt-code-reviews.appspot.com/1446804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix various warnings. (issue1446804)

nevermind http://gwt-code-reviews.appspot.com/1446804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix various warnings. (issue1446804)

No, do mind. LGTM accepted, thankee http://gwt-code-reviews.appspot.com/1446804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] This change works around a problem found in GWT Designer testing. (issue1446805)

Reviewers: scheglov, scottb, Description: This change works around a problem found in GWT Designer testing. The compilation unit rescue was really only intended for old cached compilation units, not files that change after you first start running the process. Please review this at http://gwt-c

[gwt-contrib] [google-web-toolkit] r10184 committed - Fix various warnings....

Revision: 10184 Author: gwt.mirror...@gmail.com Date: Fri May 13 14:17:46 2011 Log: Fix various warnings. Review at http://gwt-code-reviews.appspot.com/1446804 Review by: r...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=10184 Modified: /trunk/samples/mob

[gwt-contrib] Fixed malformed REDIRECT URL on login in MobileWebApp (issue1447805)

Reviewers: rjrjr, jlabanca, Description: Fixed malformed REDIRECT URL on login in MobileWebApp Please review this at http://gwt-code-reviews.appspot.com/1447805/ Affected files: M samples/mobilewebapp/src/main/com/google/gwt/sample/gaerequest/server/GaeAuthFilter.java M samples/mobilew

[gwt-contrib] Activities and Places documentation

GWT MVP Development with Activities and Places does not, as far as I can see, contain any reference to the fact that you need to inherit com.google.gwt.activity.Activity and com.google.gwt.place.Place. Shouldn't it? D

[gwt-contrib] First example of a View that kicks off its own presenter as (issue1446806)

Reviewers: rice, Description: First example of a View that kicks off its own presenter as needed. Part way toward separating presenters from activities, and making all views self inject their presenters. When we're done, we'll have proper MVP separation, but will be able to assemble widgets dire

[gwt-contrib] Re: First example of a View that kicks off its own presenter as (issue1446806)

LGTM http://gwt-code-reviews.appspot.com/1446806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Comment on RequestFactoryMovingParts in google-web-toolkit

Comment by ad...@dualsportmaps.com: Can we get a reference implementation of a JRE RequestTransport? Perhaps going to http://localhost:/rf ? I think that would help a lot of people wrap there head around this. Thank you! For more information: http://code.google.com/p/google-web-toolkit/

[gwt-contrib] Re: This change works around a problem found in GWT Designer testing. (issue1446805)

LGTM http://gwt-code-reviews.appspot.com/1446805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] In PRETTY and DETAILED, generate symbolic type queries for readability. (issue1449801)

Reviewers: zundel, cromwellian, jbrosenberg, Description: This makes the output much nicer to read, you can actually tell what type checks mean instead of looking at useless numbers. Also, this patch greatly reduces compiled output "jitter" when you're trying to diff slightly different versions