(updated patch)
http://gwt-code-reviews.appspot.com/1461803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1461803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Now that's a good answer! So the real is is just to close the result of
sourceFile.openContents()?
I would update the doc on DiskCache.tranferTo/FromStream that they don't
close the stream, and then look at all the callers and make sure they do the
right thing.
On Fri, Jun 24, 2011 at 10:36 PM,
Found the reason it fixes it.
The machine I'm testing on is not tuned for lots of files:
[java] Caused by: java.io.FileNotFoundException:
/home/testing/gwt-orig/us\
er/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_eu.java
(Too\
many open files)
[java] at java.io.FileI
Revision: 10399
Author: sco...@google.com
Date: Fri Jun 24 16:03:25 2011
Log: Fix bug resolving multiple-nested types.
http://gwt-code-reviews.appspot.com/1466808/
Review by: zun...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10399
Modified:
/trunk/dev/cor
On Fri, Jun 24, 2011 at 10:02 PM, wrote:
> Sounds good; I was hoping for some kind of "for good measure" reason
> like that. I've been translating GwtAstBuilder/ReferenceMapper to
> jribble versions and had to skip over this part because jribble only has
> textual ASTs, so when I come across exte
Revision: 10398
Author: sco...@google.com
Date: Fri Jun 24 15:51:33 2011
Log: Suppress additional JDT compile problems.
http://gwt-code-reviews.appspot.com/1461804/
Review by: zun...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10398
Modified:
/trunk/dev/co
http://gwt-code-reviews.appspot.com/1461804/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper.java
File dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper.java
(right):
http://gwt-code-reviews.appspot.com/1461804/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper
LGTM
Helpful explanation from Scott:
... the class being referenced via jsni is double-nested
the call site is a generated type it gets build in pass #2
in pass #1, the original unit is built, including the top type, a nested
type, and a nested-nested type when JsniChecker comes along, it fails t
http://gwt-code-reviews.appspot.com/1461804/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper.java
File dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper.java
(right):
http://gwt-code-reviews.appspot.com/1461804/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper
Reviewers: zundel,
Please review this at http://gwt-code-reviews.appspot.com/1466808/
Affected files:
M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java
Index: dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java
diff --git a/dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java
Reviewers: tobyr, zundel,
Description:
Make generator result caching framework api available publically.
Removes "Experimental" comment warnings.
Renames the class GeneratorExt to IncrementalGenerator.
Merges methods from GeneratorContextExt into GeneratorContext.
Please review this at http://
This will enable generator result caching by default for both dev mode
and dev-mode tests.
http://gwt-code-reviews.appspot.com/1467808/diff/1/dev/core/src/com/google/gwt/dev/DevModeBase.java
File dev/core/src/com/google/gwt/dev/DevModeBase.java (right):
http://gwt-code-reviews.appspot.com/14678
Reviewers: tobyr, zundel,
Description:
Enable generator result caching, by default.
This initially will allow caching for ClientBundle and RPC generators.
Other generators can be updated to support caching.
The -XenableGeneratorResultCaching flag is now redundant, but it is
still
allowed. It s
(Actually looked at everything this time.)
http://gwt-code-reviews.appspot.com/1455802/diff/5002/user/src/com/google/gwt/dom/builder/shared/HtmlBuilderImpl.java
File user/src/com/google/gwt/dom/builder/shared/HtmlBuilderImpl.java
(right):
http://gwt-code-reviews.appspot.com/1455802/diff/5002/u
http://gwt-code-reviews.appspot.com/1463809/diff/1/user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java
File
user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java
(right):
http://gwt-code-reviews.appspot.com/1463809/diff/1/user/src/com/google/gwt/user/rebind/rpc/
Revision: 10397
Author: jbrosenb...@google.com
Date: Fri Jun 24 12:48:13 2011
Log: Handle arrays of generic types, in rpc result cacheability
checking
Review at http://gwt-code-reviews.appspot.com/1463809
http://code.google.com/p/google-web-toolkit/source/detail?r=10397
Modified:
http://gwt-code-reviews.appspot.com/1463809/diff/1/user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java
File
user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java
(right):
http://gwt-code-reviews.appspot.com/1463809/diff/1/user/src/com/google/gwt/user/rebind/rpc/
http://gwt-code-reviews.appspot.com/1463809/diff/1/user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java
File
user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java
(right):
http://gwt-code-reviews.appspot.com/1463809/diff/1/user/src/com/google/gwt/user/rebind/rpc/
The onerror mechanism is kind of new, so it isn't supported in older
browsers like safari 3. The workarounds suggested all require checking
something expected in the script, and
this is meant to be more general purpose.
on Windows, onFail never returns. in Safari 3, the onload
callback is fired
http://gwt-code-reviews.appspot.com/1451818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1451818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
lgtm
http://gwt-code-reviews.appspot.com/1461804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1461804/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper.java
File dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper.java
(right):
http://gwt-code-reviews.appspot.com/1461804/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper
Reviewers: zundel,
Please review this at http://gwt-code-reviews.appspot.com/1461804/
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper.java
Index: dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper.java
diff --git a/dev/core/src/com/google/gwt/dev/jjs/impl/R
On 2011/06/24 21:38:20, codefu wrote:
LGTM, well, as good as the ugly vcproj format allows for such a CL to
look :P
http://gwt-code-reviews.appspot.com/1468803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: conroy,
Description:
Adding FF50 VC project files and libraries; updated manifest
Review by: con...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1468803/
Affected files:
M plugins/xpcom/VisualStudio/FirefoxPlugins.sln
A plugins/xpcom/VisualStudio/ff50-xpco
LGTM
http://gwt-code-reviews.appspot.com/1463809/diff/1/user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java
File
user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java
(right):
http://gwt-code-reviews.appspot.com/1463809/diff/1/user/src/com/google/gwt/user/rebin
This one came up once I turned on assertions with dev mode tests!
http://gwt-code-reviews.appspot.com/1463809/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: zundel, tobyr,
Description:
Handle arrays of generic types, in rpc result cacheability checking
Please review this at http://gwt-code-reviews.appspot.com/1463809/
Affected files:
M user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java
Index: user/src/com/google/g
Revision: 10395
Author: con...@google.com
Date: Fri Jun 24 13:51:30 2011
Log: Update README for Windows SDK files
http://code.google.com/p/google-web-toolkit/source/detail?r=10395
Modified:
/plugin-sdks/gecko-sdks/gecko-5.0.0/README.txt
===
--- /pl
committed as r10394
http://gwt-code-reviews.appspot.com/1462808/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
committed as r10394
http://gwt-code-reviews.appspot.com/1467807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10394
Author: jlaba...@google.com
Date: Fri Jun 24 09:50:57 2011
Log: Fixing a bug in HTMLPanel#addAndReplaceElement() where widgets
that are children of the element being replaced are never removed, which
puts the widgets in an invalid state. We now handle three additiona
http://gwt-code-reviews.appspot.com/1461803/diff/1/dev/core/src/com/google/gwt/dev/javac/SourceFileCompilationUnit.java
File
dev/core/src/com/google/gwt/dev/javac/SourceFileCompilationUnit.java
(right):
http://gwt-code-reviews.appspot.com/1461803/diff/1/dev/core/src/com/google/gwt/dev/javac/Sour
http://gwt-code-reviews.appspot.com/1461803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1461803/diff/1/dev/core/src/com/google/gwt/dev/javac/SourceFileCompilationUnit.java
File
dev/core/src/com/google/gwt/dev/javac/SourceFileCompilationUnit.java
(right):
http://gwt-code-reviews.appspot.com/1461803/diff/1/dev/core/src/com/google/gwt/dev/javac/Sour
Revision: 10393
Author: con...@google.com
Date: Fri Jun 24 12:39:23 2011
Log: Add the Windows Gecko 5.0 SDK files
http://code.google.com/p/google-web-toolkit/source/detail?r=10393
Added:
/plugin-sdks/gecko-sdks/gecko-5.0.0/WINNT_x86-msvc
/plugin-sdks/gecko-sdks/gecko-5.0.0/WINNT_x86-
http://gwt-code-reviews.appspot.com/1461803/diff/1/dev/core/src/com/google/gwt/dev/javac/SourceFileCompilationUnit.java
File
dev/core/src/com/google/gwt/dev/javac/SourceFileCompilationUnit.java
(right):
http://gwt-code-reviews.appspot.com/1461803/diff/1/dev/core/src/com/google/gwt/dev/javac/Sour
On 2011/06/24 18:42:47, jlabanca wrote:
This is an updated patch for issue:
http://gwt-code-reviews.appspot.com/1462808/
This version addresses additional error states.
LGTM
http://gwt-code-reviews.appspot.com/1467807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10392
Author: sco...@google.com
Date: Fri Jun 24 09:10:50 2011
Log: Ignore invalid types in heirarchy.
Fixes a bug where invalid types in the chain can break assumptions. This
is a problem in a case like this:
Good unit:
Foo.init();
Bad unit:
public class Foo implements
http://code.google.com/p/google-web-toolkit/source/detail?r=10391 should
unbreak FF4 and (and all the previous FF versions). Things are still
unstable, and I'm waiting on Mozilla to release an x86_64 OSX Gecko SDK.
If you like living dangerously, feel free to test the new XPI on Linux.
On Fri, Ju
Reviewers: jbrosenberg,
Message:
if you build in ant from a clean build, you'll see an NPE in DiskCache.
My testing before my last change didn't include cleaning out the old
.gwtar files, so all the units being written were
CachedCompilationUnits.
http://gwt-code-reviews.appspot.com/1461803/dif
Revision: 10391
Author: con...@google.com
Date: Fri Jun 24 08:39:48 2011
Log: In the chrome.manifest, list binary components in ascending
version order so that the right choice wins. Unbreaks <=FF4 from my
previous change.
Don't conflate debug with debuglevel (really, loglevel). D
Created http://gwt-code-reviews.appspot.com/1467807/ to address
additional error states.
http://gwt-code-reviews.appspot.com/1462808/diff/1/user/src/com/google/gwt/user/client/ui/HTMLPanel.java
File user/src/com/google/gwt/user/client/ui/HTMLPanel.java (right):
http://gwt-code-reviews.appspot.c
This is an updated patch for issue:
http://gwt-code-reviews.appspot.com/1462808/
This version addresses additional error states.
http://gwt-code-reviews.appspot.com/1467807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rchandia,
Description:
Fixing a bug in HTMLPanel#addAndReplaceElement() where widgets that are
children of the element being replaced are never removed, which puts the
widgets in an invalid state. We now handle three additional scenarios.
If the element being replaced is the new widget
On 2011/06/24 16:03:14, conroy wrote:
LGTM!
http://gwt-code-reviews.appspot.com/1465806/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10390
Author: gwt.mirror...@gmail.com
Date: Fri Jun 24 10:56:54 2011
Log: Don't attempt generator result caching for deRPC
Review at http://gwt-code-reviews.appspot.com/1462809
http://code.google.com/p/google-web-toolkit/source/detail?r=10390
Modified:
/trunk/user/src/co
Reviewers: bobv,
Description:
Removes .apt_generated from gwt-user classpath. Since Annotation
Processor
support isn't turned on for the imported project, the directory is never
created
and just causes errors when trying to launch projects.
In the future, we might want this back on along with A
Ready for more review.
http://gwt-code-reviews.appspot.com/1455802/diff/8002/user/src/com/google/gwt/dom/builder/shared/ElementBuilderFactory.java
File
user/src/com/google/gwt/dom/builder/shared/ElementBuilderFactory.java
(right):
http://gwt-code-reviews.appspot.com/1455802/diff/8002/user/src/c
http://gwt-code-reviews.appspot.com/1455802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
some background, this issue came up when I first turned on generator
result caching as the default, for dev mode tests (which of ended up
testing deRPC)...
http://gwt-code-reviews.appspot.com/1462809/diff/2003/user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java
File
user/src/co
LGTM
http://gwt-code-reviews.appspot.com/1466806/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
lgtm2, but I like method sorting.
http://gwt-code-reviews.appspot.com/1462809/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1462809/diff/2003/user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java
File
user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java
(right):
http://gwt-code-reviews.appspot.com/1462809/diff/2003/user/src/com/google/gwt/user
http://gwt-code-reviews.appspot.com/1455802/diff/5002/user/src/com/google/gwt/dom/builder/shared/ElementBuilderBase.java
File user/src/com/google/gwt/dom/builder/shared/ElementBuilderBase.java
(right):
http://gwt-code-reviews.appspot.com/1455802/diff/5002/user/src/com/google/gwt/dom/builder/shar
See comments. Updated patch coming within the next hour.
http://gwt-code-reviews.appspot.com/1455802/diff/5002/user/src/com/google/gwt/dom/builder/client/DomBuilderFactory.java
File user/src/com/google/gwt/dom/builder/client/DomBuilderFactory.java
(right):
http://gwt-code-reviews.appspot.com/1
http://gwt-code-reviews.appspot.com/1462809/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: codefu,
Description:
In the chrome.manifest, list binary components in ascending version
order so that the right choice wins. Unbreaks <=FF4 from my previous
change.
Don't conflate debug with debuglevel (really, loglevel). Default to
build binaries without debugging information for th
On Fri, Jun 24, 2011 at 4:58 PM, Chris Conroy wrote:
> This is definitely temporary (and clearly not tested widely) as it only
> supports Linux. You saw the extra permission prompt because this build
> include's codefu's latest work of making the code server part of the
> security model. Thanks fo
This is definitely temporary (and clearly not tested widely) as it only
supports Linux. You saw the extra permission prompt because this build
include's codefu's latest work of making the code server part of the
security model. Thanks for the heads up though. I'll ping back on this
thread when ther
On Fri, Jun 24, 2011 at 8:35 AM, wrote:
> So, what you are saying is that we are getting lots of unrelated errors
> for units that reference foo that are obscuring the real problem?
The unrelated units are actually causing a blow-up. When we try to
construct the type hierarchy to represent Foo
http://gwt-code-reviews.appspot.com/1462809/diff/1/user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java
File
user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java
(right):
http://gwt-code-reviews.appspot.com/1462809/diff/1/user/src/com/google/gwt/user/rebind/rpc/
http://gwt-code-reviews.appspot.com/1462809/diff/1/user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java
File
user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java
(right):
http://gwt-code-reviews.appspot.com/1462809/diff/1/user/src/com/google/gwt/user/rebind/rpc/
For those who might have missed it in other threads, Google Plugin for
Eclipse 2.3 is now available for Eclipse Indigo (3.7). See instructions
here:
http://code.google.com/eclipse/docs/getting_started.html
GPE 2.4 is currently in beta, release coming shortly.
/dmc
--
David Chandler
Developer P
Reviewers: tobyr, zundel,
Description:
Fix for rpc generator result caching (fix potential NPE)
Please review this at http://gwt-code-reviews.appspot.com/1462809/
Affected files:
M user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java
Index: user/src/com/google/gwt/user/reb
On 2011/06/24 00:48:05, scottb wrote:
Fixes a bug where invalid types in the chain can break assumptions.
This is a
problem in a case like this:
Good unit:
Foo.init();
Bad unit:
public class Foo implements UnknownType { ... }
The good unit itself doesn't have errors, but trying to cons
I tried the XPI from this commit in Firefox 4.0.1 on Ubuntu 11.04 (to check
that it worked before upgrading to Firefox 5) and guess what: it failed!
First, it prompted me to allow the "web and code server combination" again
(I'm debugging in -noserver mode) despite being already there in the
ex
69 matches
Mail list logo
