[gwt-contrib] Re: This patch substantially reduces the overhead of Java types in the output by minimizing vtable s... (issue1447821)

http://gwt-code-reviews.appspot.com/1447821/diff/3001/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java (right): http://gwt-code-reviews.appspot.com/1447821/diff/3001/dev/core/src/com/google/gwt/dev/jjs/JavaTo

[gwt-contrib] Re: This patch substantially reduces the overhead of Java types in the output by minimizing vtable s... (issue1447821)

http://gwt-code-reviews.appspot.com/1447821/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: This patch substantially reduces the overhead of Java types in the output by minimizing vtable s... (issue1447821)

http://gwt-code-reviews.appspot.com/1447821/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix bug in UnifyAst where non-null array types failed to canonicalize. (issue1469802)

LGTM http://gwt-code-reviews.appspot.com/1469802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fix bug in UnifyAst where non-null array types failed to canonicalize. (issue1469802)

Reviewers: jbrosenberg, Please review this at http://gwt-code-reviews.appspot.com/1469802/ Affected files: M dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java Index: dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java diff --git a/dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.j

[gwt-contrib] Re: Adding explicit casts to the return value of certain methods to help the javac compiler. Some c... (issue1463810)

committed as r10413 I don't have the version readily available, but I'll take a look in the build logs. On 2011/06/29 15:32:51, robertvawter wrote: LGTM It's helpful to add the output from "javac -version" if it's available so future code maintainers can know whether or not new code performi

[gwt-contrib] Re: Updates the module name validation check for using CompileModule on a project. (issue1467810)

lgtm http://gwt-code-reviews.appspot.com/1467810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Updates the module name validation check for using CompileModule on a project. (issue1467810)

http://gwt-code-reviews.appspot.com/1467810/diff/1/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (right): http://gwt-code-reviews.appspot.com/1467810/diff/1/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java#newcode80 dev/core/src/com/

[gwt-contrib] Re: Updates the module name validation check for using CompileModule on a project. (issue1467810)

http://gwt-code-reviews.appspot.com/1467810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10414 committed - Fix ArrayStoreException in assignments to an element of an array of a ...

Revision: 10414 Author: gwt.mirror...@gmail.com Date: Wed Jun 29 11:56:33 2011 Log: Fix ArrayStoreException in assignments to an element of an array of a single jso interface type. Addresses issue 6448 Review at http://gwt-code-reviews.appspot.com/1470801 http://code.google.com/p/

[gwt-contrib] Re: Updates the module name validation check for using CompileModule on a project. (issue1467810)

http://gwt-code-reviews.appspot.com/1467810/diff/1/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (right): http://gwt-code-reviews.appspot.com/1467810/diff/1/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java#newcode80 dev/core/src/com/

[gwt-contrib] [google-web-toolkit] r10413 committed - Adding explicit casts to the return value of certain methods to help t...

Revision: 10413 Author: jlaba...@google.com Date: Wed Jun 29 05:16:14 2011 Log: Adding explicit casts to the return value of certain methods to help the javac compiler. Some compilers require the explicit cast. Review at http://gwt-code-reviews.appspot.com/1463810 Review by: rober

[gwt-contrib] Updates the module name validation check for using CompileModule on a project. (issue1467810)

Reviewers: tobyr, jbrosenberg, Description: Updates the module name validation check for using CompileModule on a project. 1) Loosen the requirement that the last part of the module name be a Java identifier. Users were creating modules with non-java identifer names but since they weren't top l

[gwt-contrib] Re: Update XML doc to make it clearer that 'compiler.emulatedStack' should no longer be used. (issue1462804)

LGTM http://gwt-code-reviews.appspot.com/1462804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update XML doc to make it clearer that 'compiler.emulatedStack' should no longer be used. (issue1462804)

ping http://gwt-code-reviews.appspot.com/1462804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Follow up to r10350. Allow collapse-all-properties in .gwt.xml module files (issue1463806)

ping http://gwt-code-reviews.appspot.com/1463806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add RequestFactory validator implemented as an annotation processor. (issue1467804)

On Wed, Jun 29, 2011 at 2:58 PM, BobV wrote: > On Wed, Jun 29, 2011 at 8:46 AM,   wrote: >> Still having stackoverflows when enabling the annotation processor in >> Eclipse. The error I got the last time I tried had a very similar >> stacktrace (see below). > > Do you have any self-parameterized t

[gwt-contrib] Adding explicit casts to the return value of certain methods to help the javac compiler. Some c... (issue1463810)

Reviewers: robertvawter, Description: Adding explicit casts to the return value of certain methods to help the javac compiler. Some compilers require the explicit cast. Please review this at http://gwt-code-reviews.appspot.com/1463810/ Affected files: M user/src/com/google/gwt/dom/builder/c

[gwt-contrib] Re: Fix ArrayStoreException in assignments to an element of an array of a single jso interface type. (issue1470801)

Agreed On Wed, Jun 29, 2011 at 4:01 AM, wrote: > > LGTM. You're right, you can't do it statically because the array type > can be from a cast. > > > > http://gwt-code-reviews.appspot.com/1470801/diff/1003/dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Array.java > File > dev

[gwt-contrib] Re: Add RequestFactory validator implemented as an annotation processor. (issue1467804)

On Wed, Jun 29, 2011 at 8:46 AM, wrote: > Still having stackoverflows when enabling the annotation processor in > Eclipse. The error I got the last time I tried had a very similar > stacktrace (see below). Do you have any self-parameterized types? Foo> kind of things going on? I'd assumed from

[gwt-contrib] Re: Add RequestFactory validator implemented as an annotation processor. (issue1467804)

Still having stackoverflows when enabling the annotation processor in Eclipse. The error I got the last time I tried had a very similar stacktrace (see below). Running the tool from the Maven build gives a lot of warnings like those: "Cannot validate this method because the domain mapping for the

[gwt-contrib] Re: RFC: ElementBuilder API (issue1455802)

committed as r10412 http://gwt-code-reviews.appspot.com/1455802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix ArrayStoreException in assignments to an element of an array of a single jso interface type. (issue1470801)

LGTM. You're right, you can't do it statically because the array type can be from a cast. http://gwt-code-reviews.appspot.com/1470801/diff/1003/dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Array.java File dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lan