Revision: 10420
Author: mrruss...@google.com
Date: Thu Jul 7 06:43:13 2011
Log: tag for the 2.4 rc1 release
http://code.google.com/p/google-web-toolkit/source/detail?r=10420
Added:
/tags/2.4.0-rc1
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: keertip, pquitslund, tbroyer,
Description:
Add compile-time tests for APT-based RequestFactory interface validator.
Move all validator message formatting to a single class.
Patch by: bobv
Review by: keertip,pquitslund, t.broyer
Suggested by: t.broyer
Please review this at
http://gwt-code-reviews.appspot.com/1469803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Added support for dynamically checking the browser for identity, which
includes Chromium 12, 13, and some versions of 14. Responsibility for
the expando was packaged in to the LocalObjects. The new
NPVariantUtil.h is simply all the static NPVariant utilities from
NPVariantProxy that strictly
Revision: 10421
Author: rdcas...@google.com
Date: Wed Jul 6 10:57:13 2011
Log: Fixing IsRenderable API step 2: pass in a stamper instead of the
actual ID.
As we discussed a few weeks ago, the goal here is to make the exact scheme
by
which elements are marked and retrieved
Revision: 10422
Author: sco...@google.com
Date: Wed Jul 6 13:03:16 2011
Log: UnifyAst correctly handles polymorphic overrides with mixed
default/public access.
GWT AST now tracks method access. This is used by UnifyAst to correctly
compute overrides. Before, UnifyAst would
almost there
http://gwt-code-reviews.appspot.com/1469803/diff/6009/plugins/npapi/LocalObjectTable.h
File plugins/npapi/LocalObjectTable.h (right):
http://gwt-code-reviews.appspot.com/1469803/diff/6009/plugins/npapi/LocalObjectTable.h#newcode166
plugins/npapi/LocalObjectTable.h:166: set( id,
Comment by herditea...@gmail.com:
yes
my join
For more information:
http://code.google.com/p/google-web-toolkit/wiki/IssueReportSample
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1469803/diff/6009/plugins/npapi/LocalObjectTable.h
File plugins/npapi/LocalObjectTable.h (right):
http://gwt-code-reviews.appspot.com/1469803/diff/6009/plugins/npapi/LocalObjectTable.h#newcode166
plugins/npapi/LocalObjectTable.h:166: set( id, jsObject );
On
http://gwt-code-reviews.appspot.com/1469803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1469803/diff/6009/plugins/npapi/ScriptableInstance.h
File plugins/npapi/ScriptableInstance.h (right):
http://gwt-code-reviews.appspot.com/1469803/diff/6009/plugins/npapi/ScriptableInstance.h#newcode91
plugins/npapi/ScriptableInstance.h:91: static bool
Awesome!
I haven't read the ExpectCollector code, and probably a few other lines
of code, but the code reads good to me!
http://gwt-code-reviews.appspot.com/1473801/diff/1/user/src/com/google/web/bindery/requestfactory/apt/State.java
File
PING
http://gwt-code-reviews.appspot.com/1465805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM++
http://gwt-code-reviews.appspot.com/1469803/diff/6009/plugins/npapi/ScriptableInstance.h
File plugins/npapi/ScriptableInstance.h (right):
http://gwt-code-reviews.appspot.com/1469803/diff/6009/plugins/npapi/ScriptableInstance.h#newcode91
plugins/npapi/ScriptableInstance.h:91: static bool
Reviewers: rchandia,
Description:
Adding all supported element builders to the ElementBuilder API. This
is a follow-on change for r10412, which introduced the core
ElementBuilder libraries.
For each Element type, we introduce five new files:
1. The builder interface (ex. AnchorBuilder)
2. The
Reviewers: jbrosenberg, scottb,
Description:
JsoNormalizer did not give unique names to devirtualized
methods from Object overrides or DualJsoImpl types. The
obfuscated namer papered over this, but if you turn on
pretty mode, you can run into problems if two interfaces
have DualJsoImpl types
Reviewers: aliibrahim_google.com,
Description:
Integrating r3302 from GWT 1.5 back into trunk. The change fixes a bug
in Tree where opening a TreeItem while another node is selected causes
the Tree to scroll to scroll to the selected node (opening an item does
not select a node). The original
On 2011/07/06 14:05:05, stephenh wrote:
That would be great. Could you please upload the patch? Thanks!
Sure--I can't upload a new patchset to this issue because I'm not the
owner. Is
it possible to add me? Or would you prefer for me to create a new
issue?
Could you please create a new
Reviewers: zhuyi,
Please review this at http://gwt-code-reviews.appspot.com/1463813/
Affected files:
M user/src/com/google/gwt/rpc/rebind/RpcProxyCreator.java
M user/src/com/google/gwt/user/RemoteService.gwt.xml
A user/src/com/google/gwt/user/RemoteServiceFinalFields.gwt.xml
A
Could you please create a new issue?
Yeah, np:
http://gwt-code-reviews.appspot.com/1463813/
I'll reiterate my previous disclaimer that I didn't do any clean up for
formatting/line-length/etc. as it was just a proof of concept. If you'd
like me to clean it up to be directly submit-able, let me
Reviewers: zhuyi,
Description:
This time with the original patch first for easier diffs.
The first patch is the last patch set from:
http://gwt-code-reviews.appspot.com/1380807/
The 2nd patch set will be my changes.
Please review this at http://gwt-code-reviews.appspot.com/1463814/
Affected
http://gwt-code-reviews.appspot.com/1467812/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/JsoDevirtualizer.java
File dev/core/src/com/google/gwt/dev/jjs/impl/JsoDevirtualizer.java
(right):
http://gwt-code-reviews.appspot.com/1466809/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1466809/diff/1/tools/api-checker/config/gwt23_24userApi.conf
File tools/api-checker/config/gwt23_24userApi.conf (right):
http://gwt-code-reviews.appspot.com/1466809/diff/1/tools/api-checker/config/gwt23_24userApi.conf#newcode58
Reviewers: cromwellian, zundel, scottb,
Description:
Fix JsInliner, to properly handle name scope tracking after multi-level
inlining. Was causing local variable name collisions after obfuscation.
Fixes issue 5936.
Please review this at http://gwt-code-reviews.appspot.com/1472803/
Affected
http://gwt-code-reviews.appspot.com/1447821/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Should we really be fixing the issue here, or should we just fix it up
in GenerateJavaScriptAST or JsNamer? There are lots of locations in the
GWT compiler where methods and fields are synthesized, so I would bet
that there are other collisions like this lurking, just not being
tripped.
Another
You commented in the issue tracker that the JsInliner is not the
issue, the obfuscator is the problem, so why the patch to Inliner?
On Thu, Jul 7, 2011 at 5:09 PM, jbrosenb...@google.com wrote:
Reviewers: cromwellian, zundel, scottb,
Description:
Fix JsInliner, to properly handle name scope
Thanks. I'll look through and incorporate your changes.
On Thu, Jul 7, 2011 at 6:33 PM, stephen.haber...@gmail.com wrote:
http://gwt-code-reviews.**appspot.com/1463813/http://gwt-code-reviews.appspot.com/1463813/
I deleted this issue and made a new one:
29 matches
Mail list logo
