[gwt-contrib] [google-web-toolkit] r10447 committed - Explicitly enable external DTDs feature....

2011-07-12 Thread codesite-noreply
Revision: 10447 Author: gwt.mirror...@gmail.com Date: Tue Jul 12 14:55:15 2011 Log: Explicitly enable external DTDs feature. Review by: j...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=10447 Modified: /trunk/user/src/com/google/gwt/uibinder/rebind/W3cDomHel

[gwt-contrib] [google-web-toolkit] r10446 committed - Reduces chances of deadlock when CompilingClassLoader and MultiParentC...

2011-07-12 Thread codesite-noreply
Revision: 10446 Author: to...@google.com Date: Tue Jul 12 13:27:01 2011 Log: Reduces chances of deadlock when CompilingClassLoader and MultiParentClassLoader are concurrently accessed from multiple threads. Review at http://gwt-code-reviews.appspot.com/1479801 http://code.google.co

[gwt-contrib] Re: JsoNormalizer did not give unique names to devirtualized (issue1467812)

2011-07-12 Thread zundel
http://gwt-code-reviews.appspot.com/1467812/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/OptimizerTestBase.java File dev/core/test/com/google/gwt/dev/jjs/impl/OptimizerTestBase.java (right): http://gwt-code-reviews.appspot.com/1467812/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/Optimize

[gwt-contrib] Re: JsoNormalizer did not give unique names to devirtualized (issue1467812)

2011-07-12 Thread zundel
On 2011/07/08 19:07:11, scottb wrote: Legally tho, it doesn't make sense for a single class to have more than one method with the same signature. Maybe that should be an assertion somewhere. On Thu, Jul 7, 2011 at 8:57 PM, wrote: > > Should we really be fi

[gwt-contrib] Add StringKey to gwt-servlet.jar to support RequestFactory users. (issue1479802)

2011-07-12 Thread bobv
Reviewers: drfibonacci, Description: Add StringKey to gwt-servlet.jar to support RequestFactory users. Patch by: bobv Review by: drfibonacci Please review this at http://gwt-code-reviews.appspot.com/1479802/ Affected files: M servlet/build.xml Index: servlet/build.xml =

[gwt-contrib] Re: JsoNormalizer did not give unique names to devirtualized (issue1467812)

2011-07-12 Thread zundel
http://gwt-code-reviews.appspot.com/1467812/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10445 committed - Updating test case to check for existence of indexOf() (<=IE8)...

2011-07-12 Thread codesite-noreply
Revision: 10445 Author: cod...@google.com Date: Tue Jul 12 10:58:10 2011 Log: Updating test case to check for existence of indexOf() (<=IE8) Review at http://gwt-code-reviews.appspot.com/1469803 Review by: jlaba...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=

[gwt-contrib] Re: Updating npapi plugin to remove gwtId from Jso objects (idenity fix), (issue1469803)

2011-07-12 Thread jlabanca
On 2011/07/12 20:36:59, codefu wrote: LGTM http://gwt-code-reviews.appspot.com/1469803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Updating npapi plugin to remove gwtId from Jso objects (idenity fix), (issue1469803)

2011-07-12 Thread codefu
http://gwt-code-reviews.appspot.com/1469803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10444 committed - change to fix the JavaDoc error during build...

2011-07-12 Thread codesite-noreply
Revision: 10444 Author: mrruss...@google.com Date: Tue Jul 12 08:08:43 2011 Log: change to fix the JavaDoc error during build Review at http://gwt-code-reviews.appspot.com/1478801 Review by: p...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=10444 Modified:

[gwt-contrib] Re: change to fix the JavaDoc error during build (issue1478801)

2011-07-12 Thread pdr
On 2011/07/12 17:50:51, Mark R Russell wrote: LGTM! http://gwt-code-reviews.appspot.com/1478801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make generator result caching framework api available publically. (issue1468804)

2011-07-12 Thread jbrosenberg
http://gwt-code-reviews.appspot.com/1468804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10442 committed - Missing file Pruner.java from last submitted change.

2011-07-12 Thread codesite-noreply
Revision: 10442 Author: cromwell...@google.com Date: Mon Jul 11 14:42:59 2011 Log: Missing file Pruner.java from last submitted change. http://code.google.com/p/google-web-toolkit/source/detail?r=10442 Modified: /trunk/dev/core/src/com/google/gwt/dev/jjs/impl/Pruner.java ===

[gwt-contrib] Performance improvements for ElementBuilder. (issue1477801)

2011-07-12 Thread jlabanca
Reviewers: rdcastro, Description: Performance improvements for ElementBuilder. The current version of ElementBuilder involves a lot of casting, which results in thousands of dynamic casts (runtime type checks) when building a large table. This change removes most of the unnecessary casts. All

[gwt-contrib] [google-web-toolkit] r10440 committed - After an enum is ordinalized, any static methods generated as staticIm...

2011-07-12 Thread codesite-noreply
Revision: 10440 Author: jbrosenb...@google.com Date: Mon Jul 11 09:47:54 2011 Log: After an enum is ordinalized, any static methods generated as staticImpl's should no longer be considered as such, since there is no longer an instantated instance being passed as the first arg to the

[gwt-contrib] [google-web-toolkit] r10439 committed - Cherry-pick r10437 into 2.4 release branch.

2011-07-12 Thread codesite-noreply
Revision: 10439 Author: b...@google.com Date: Mon Jul 11 11:27:30 2011 Log: Cherry-pick r10437 into 2.4 release branch. http://code.google.com/p/google-web-toolkit/source/detail?r=10439 Modified: /releases/2.4/user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java ===

Re: [gwt-contrib] Review for Issue 4862

2011-07-12 Thread Felix H. Dahlke
I've added those two as reviewers, thanks for the hint. As you can probably guess, I'm not very familiar with the process :) On Jul 11, 2011, at 8:18 PM, Eric Ayers wrote: > Lining up and adding a specific reviewer helps, because then the review shows > up on their code review dashboard. In th