[gwt-contrib] Re: Introducing a new CellTableBuilder API, which allows users to customize the structure of a CellT... (issue1501803)

2011-07-25 Thread Jeff Larsen
I had about an hour-hour and a half to play with this over the weekend and I have to say it looks great. I have to ask though, is there a reason why ColumnT,? doesn't contain the header and footer cell? It would sure make it easier for things like reordering columns, hiding columns. Also it

[gwt-contrib] Re: Introducing a new CellTableBuilder API, which allows users to customize the structure of a CellT... (issue1501803)

2011-07-25 Thread John LaBanca
The primary reason is that we didn't want to impose the restriction that all table based implementations of HasDataPresenter contain a header and a footer consisting of a single header/footer per column. You can imagine a variation of CellTable that does not include headers, or one that supports

Re: [gwt-contrib] Re: Introducing a new CellTableBuilder API, which allows users to customize the structure of a CellT... (issue1501803)

2011-07-25 Thread Michael Anstis
For what it's worth, I'd be in favour of the header and footer being decoupled from the columns. We had to home-bake a CellTable equivalent that has a header with multiple rows and cells that span multiple columns Just my 2c. :) On 25 July 2011 17:04, John LaBanca jlaba...@google.com

[gwt-contrib] Adding API method Column#setDefaultSortOrder(boolean isAscending) to control whether the column ... (issue1498806)

2011-07-25 Thread jlabanca
Reviewers: pengzhuang_google.com, Description: Adding API method Column#setDefaultSortOrder(boolean isAscending) to control whether the column should be sorted in ascending or descending order the first time it is clicked. Currently, the first time a column is clicked, it is sorted in ascending

[gwt-contrib] Re: Adds a static factory method to create Event.Type using type (issue1462806)

2011-07-25 Thread rjrjr
Thanks, this is nice. Would you mind expanding the patch to make some existing event types use it? How about the set in com.google.gwt.event.logical.shared? http://gwt-code-reviews.appspot.com/1462806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fixes a bug in AbstractPager where clearing the display and resetting it causes an NPE. (issue1500803)

2011-07-25 Thread jlabanca
Reviewers: andycheng_google.com, Description: Fixes a bug in AbstractPager where clearing the display and resetting it causes an NPE. Please review this at http://gwt-code-reviews.appspot.com/1500803/ Affected files: M user/src/com/google/gwt/user/cellview/client/AbstractPager.java M

[gwt-contrib] Re: DirectInstallLinker should not immediately remove the script tag it has inserted into the IFRAME... (issue1454802)

2011-07-25 Thread fredsa
Committed in r10293 http://gwt-code-reviews.appspot.com/1454802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Use glass panel isntead of alert() when displaying dev mode connection failures, (issue1449802)

2011-07-25 Thread fredsa
Committed in r10204 http://gwt-code-reviews.appspot.com/1449802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add the beginnings of new HTML5 drag and drop events (issue1398802)

2011-07-25 Thread fredsa
Committed in r9944 http://gwt-code-reviews.appspot.com/1398802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add media events for audio/video elements (issue1385804)

2011-07-25 Thread fredsa
Committed in r9918 http://gwt-code-reviews.appspot.com/1385804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix Javadoc for gesture/touch events (issue1383805)

2011-07-25 Thread fredsa
Committed in r9869 http://gwt-code-reviews.appspot.com/1383805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Quick patch, in follow up to r9344, which replaces remaining uses of the legacy 'compiler.emulat... (issue1338804)

2011-07-25 Thread fredsa
Committed in r9756 http://gwt-code-reviews.appspot.com/1338804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Include the property name in the error message when a single-valued property does not have exact... (issue1348801)

2011-07-25 Thread fredsa
Committed in r9702 http://gwt-code-reviews.appspot.com/1348801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Remove list of JavaScriptException object properties when compiler.stackTrace = emulated (issue1310802)

2011-07-25 Thread fredsa
Committed in r9672 http://gwt-code-reviews.appspot.com/1310802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Updated StackTraceDeobfuscator javadoc in follow up to r9162. (issue1321801)

2011-07-25 Thread fredsa
Committed in r9604 http://gwt-code-reviews.appspot.com/1321801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Re-enable XML parse test, which was previously failing in one Safari configuration in Production... (issue1229801)

2011-07-25 Thread fredsa
Committed in r9503 http://gwt-code-reviews.appspot.com/1229801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Re-enable a few style tests now that old linux hosted mode is gone (issue1228801)

2011-07-25 Thread fredsa
Committed in r9499 http://gwt-code-reviews.appspot.com/1228801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Replace most user/developer visible references to hosted/web mode with Development/Production Mode (issue1221801)

2011-07-25 Thread fredsa
Committed in r9459 http://gwt-code-reviews.appspot.com/1221801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: - Use z-index to layer multiple notifications in hosted.html (issue1323801)

2011-07-25 Thread fredsa
Committed in r9758 http://gwt-code-reviews.appspot.com/1323801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Handle cases where element.canPlayType() returns 'no' instead of the empty string on some browsers. (issue1362802)

2011-07-25 Thread fredsa
Committed in r9868 http://gwt-code-reviews.appspot.com/1362802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: 1. Assert, at runtime, that GWT is running in Standards Mode (i.e. with an appropriate DOCTYPE d... (issue1422816)

2011-07-25 Thread fredsa
Committed in r10204 http://gwt-code-reviews.appspot.com/1422816/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Follow up to r10350. Allow collapse-all-properties in .gwt.xml module files (issue1463806)

2011-07-25 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/1463806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: Implements UiBinder rendering for Cells. (issue1466809)

2011-07-25 Thread Ray Ryan
I've shared a publicly visible copy here: https://docs.google.com/document/d/1Oo_imxskoGX5O9l9LhHDtJ0yJkHvNTNQqU3dkkekZYI/edit?hl=en_US Does that work for you? On Fri, Jul 8, 2011 at 3:22 PM, stephen.haber...@gmail.com wrote: Is it okay to make that public? I think it is OK. We usually

Re: [gwt-contrib] Re: Implements UiBinder rendering for Cells. (issue1466809)

2011-07-25 Thread Stephen Haberman
https://docs.google.com/document/d/1Oo_imxskoGX5O9l9LhHDtJ0yJkHvNTNQqU3dkkekZYI/edit?hl=en_US Does that work for you? Awesome! Yep, it works. Thanks. - Stephen -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Comment on UiBinder in google-web-toolkit

2011-07-25 Thread codesite-noreply
Comment by globall...@gmail.com: I second that! For more information: http://code.google.com/p/google-web-toolkit/wiki/UiBinder -- http://groups.google.com/group/Google-Web-Toolkit-Contributors