[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

2011-08-30 Thread stephen . haberman
I am integrating it. Sorry that I haven't worked on it for a while due to other jobs. Awesome, no problem. Was just wondering if I should try and pick it up if you weren't working on it. http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contribut

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

2011-08-30 Thread Yi Zhu
I am integrating it. Sorry that I haven't worked on it for a while due to other jobs. On Fri, Aug 26, 2011 at 8:24 AM, wrote: > >> Thanks. I'll look through and incorporate your changes. > > zhuyi, any updates on this? > > http://gwt-code-reviews.appspot.com/1380807/ > -- http://groups.google.

[gwt-contrib] [google-web-toolkit] r10596 committed - Undeprecates the methods in StyleInjector that deal with StyleElement....

2011-08-30 Thread codesite-noreply
Revision: 10596 Author: rj...@google.com Date: Tue Aug 30 08:32:20 2011 Log: Undeprecates the methods in StyleInjector that deal with StyleElement. They still aren't safe for IE, but apps that don't care about that still use them. Updates javadoc accordingly. Review at http://gwt-co

[gwt-contrib] Re: Integrating Peng's recent API changes to CellTableBuilder into HeaderCreator. HeaderCreator now... (issue1533804)

2011-08-30 Thread skybrian
LGTM (other than a bit of clarification) http://gwt-code-reviews.appspot.com/1533804/diff/6001/user/src/com/google/gwt/user/cellview/client/FooterBuilder.java File user/src/com/google/gwt/user/cellview/client/FooterBuilder.java (right): http://gwt-code-reviews.appspot.com/1533804/diff/6001/use

[gwt-contrib] Re: Undeprecates the methods in StyleInjector that deal with StyleElement. (issue1535803)

2011-08-30 Thread rjrjr
http://gwt-code-reviews.appspot.com/1535803/diff/1/user/src/com/google/gwt/dom/client/StyleInjector.java File user/src/com/google/gwt/dom/client/StyleInjector.java (right): http://gwt-code-reviews.appspot.com/1535803/diff/1/user/src/com/google/gwt/dom/client/StyleInjector.java#newcode329 user/sr

[gwt-contrib] Re: Undeprecates the methods in StyleInjector that deal with StyleElement. (issue1535803)

2011-08-30 Thread rjrjr
http://gwt-code-reviews.appspot.com/1535803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Undeprecates the methods in StyleInjector that deal with StyleElement. (issue1535803)

2011-08-30 Thread rjrjr
Reviewers: lkw_google.com, Description: Undeprecates the methods in StyleInjector that deal with StyleElement. They still aren't safe for IE, but apps that don't care about that still use them. Updates javadoc accordingly. Please review this at http://gwt-code-reviews.appspot.com/1535803/ Affe

[gwt-contrib] [google-web-toolkit] r10595 committed - Add RowHoverEvent for the CellTable. This can come in handy if the use...

2011-08-30 Thread codesite-noreply
Revision: 10595 Author: pengzhu...@google.com Date: Tue Aug 30 06:42:56 2011 Log: Add RowHoverEvent for the CellTable. This can come in handy if the user want to have special handling logic when a row is hovered. For example, the style of only a few cells can be updated, or one cell

[gwt-contrib] Re: Integrating Peng's recent API changes to CellTableBuilder into HeaderCreator. HeaderCreator now... (issue1533804)

2011-08-30 Thread jlabanca
http://gwt-code-reviews.appspot.com/1533804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Integrating Peng's recent API changes to CellTableBuilder into HeaderCreator. HeaderCreator now... (issue1533804)

2011-08-30 Thread jlabanca
http://gwt-code-reviews.appspot.com/1533804/diff/6001/user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java File user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java (right): http://gwt-code-reviews.appspot.com/1533804/diff/6001/user/src/com/google/gwt/user/cellview/

[gwt-contrib] Re: Add RowHoverEvent for the CellTable. This can come in handy if the user want to have special han... (issue1534804)

2011-08-30 Thread jlabanca
http://gwt-code-reviews.appspot.com/1534804/diff/1/user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java File user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java (right): http://gwt-code-reviews.appspot.com/1534804/diff/1/user/src/com/google/gwt/user/cellview/client

[gwt-contrib] [google-web-toolkit] r10594 committed - Adding some extra capabilities to CountingEventBus so that we can redu...

2011-08-30 Thread codesite-noreply
Revision: 10594 Author: danielwh...@google.com Date: Mon Aug 29 22:37:59 2011 Log: Adding some extra capabilities to CountingEventBus so that we can reduce the boilerplate involved in testing events fired on the EventBus. Review at http://gwt-code-reviews.appspot.com/1526803 Review