[gwt-contrib] Re: Add ability to control time zone in DateCell. (issue1539803)

LGTM http://gwt-code-reviews.appspot.com/1539803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: to set property values (issue1524803)

On Monday, September 5, 2011, wrote: > I wouldn't see that as a problem. From my understanding, the generated > code always generates where all field declarations are at the top, then > all the setters are called and lastly all event listeners are created > (for UiHandler methods). > > Where I wou

[gwt-contrib] Re: Update the missing plugin page to stop taunting Safari 5.1 users, and (issue1536803)

ping On Friday, September 2, 2011, wrote: > Kelly, can you take another look? Now sniffing on the Safari version > rather than the Webkit version, so that 5.0.6 isn't blocked. > > http://gwt-code-reviews.**appspot.com/1536803/ > -- http://groups.goo

[gwt-contrib] [google-web-toolkit] r10615 committed - Restrict usage of the entryDepth watchdog to script mode.

Revision: 10615 Author: emmanu...@google.com Date: Tue Sep 6 06:11:27 2011 Log: Restrict usage of the entryDepth watchdog to script mode. http://code.google.com/p/google-web-toolkit/source/detail?r=10615 Modified: /trunk/user/src/com/google/gwt/core/client/impl/Impl.java ==

[gwt-contrib] [google-web-toolkit] r10616 committed - Fix typo

Revision: 10616 Author: rj...@google.com Date: Tue Sep 6 09:25:45 2011 Log: Fix typo http://code.google.com/p/google-web-toolkit/source/detail?r=10616 Modified: /wiki/RequestFactory_2_4.wiki === --- /wiki/RequestFactory_2_4.wiki Mon Aug 15 0

Re: [gwt-contrib] Comment on RequestFactory_2_4 in google-web-toolkit

Fixed, thanks. On Monday, September 5, 2011, wrote: > Comment by ido@gmail.com: > > In Improved request batching section the sample has typo: > ctxB.requestB().to(new Receiver(){}); > should be > > ctxB.requestB().to(new Receiver(){}); > > For more information: > http://code.google.com/p/**go

[gwt-contrib] Re: Event handling support for UiRenderer (issue1534806)

On 2011/09/02 00:01:48, rjrjr wrote: http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode1202 user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:1202: try { Should use the TypeOracle, not reflection Here I need to act

[gwt-contrib] Re: to set property values (issue1524803)

So, let me try to clear up what I'm afraid about in more detail. The lazy widgets code generation splits attribute creation and access by creating 2 methods build_XYZ(), and get_XYZ(). All setters are called in the build_XYZ() part, so you'd have something like this: private void build_layoutData(

[gwt-contrib] Re: Event handling support for UiRenderer (issue1534806)

Oh, crazy! I didn't notice that you were invoking it at compile time. And I suppose that's going to let it fail at compile time instead of runtime, isn't it? Okey doke. On Tuesday, September 6, 2011, wrote: > On 2011/09/02 00:01:48, rjrjr wrote: > > http://gwt-code-reviews.**appspot.com/1534806/d

[gwt-contrib] Re: Event handling support for UiRenderer (issue1534806)

http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (right): http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Event handling support for UiRenderer (issue1534806)

http://gwt-code-reviews.appspot.com/1534806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Event handling support for UiRenderer (issue1534806)

http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/client/AbstractUiRenderer.java File user/src/com/google/gwt/uibinder/client/AbstractUiRenderer.java (right): http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/client/AbstractUiRe

[gwt-contrib] Adds requestfactory-apt-src to the RF produced artifacts (issue1540803)

Reviewers: drfibonacci, rjrjr, Description: Adds requestfactory-apt-src to the RF produced artifacts Please review this at http://gwt-code-reviews.appspot.com/1540803/ Affected files: M requestfactory/build.xml Index: requestfactory/build.xml ===

[gwt-contrib] Re: Adds requestfactory-apt-src to the RF produced artifacts (issue1540803)

LGTM http://gwt-code-reviews.appspot.com/1540803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

Looks good to me. http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Misc TypeOracle cleanup (issue1505805)

http://gwt-code-reviews.appspot.com/1505805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Misc TypeOracle cleanup (issue1505805)

Made TypeParser package private, plus rebased against HEADish, so ping. http://gwt-code-reviews.appspot.com/1505805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixup class literals across fragments (issue1513803)

Ping. http://gwt-code-reviews.appspot.com/1513803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Remove duplicate loop over cached units. (issue1463802)

Ping. http://gwt-code-reviews.appspot.com/1463802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Updates pom.xml to use new Request Factory libraries (issue1541803)

Reviewers: rjrjr, drfibonacci, Description: Updates pom.xml to use new Request Factory libraries Please review this at http://gwt-code-reviews.appspot.com/1541803/ Affected files: M samples/mobilewebapp/pom.xml Index: samples/mobilewebapp/pom.xml ===

[gwt-contrib] Re: Updates pom.xml to use new Request Factory libraries (issue1541803)

LGTM Nice! On Tue, Sep 6, 2011 at 1:22 PM, wrote: > Reviewers: rjrjr, drfibonacci, > > Description: > Updates pom.xml to use new Request Factory libraries > > > Please review this at > http://gwt-code-reviews.**appspot.com/1541803/ > > Affected fil

Re: [gwt-contrib] less name mangling

Thanks Steve! We chatted, and Ray C is up for reviewing this, but I'm afraid it'll be the usual maybe-this-week drill. On Fri Sep 02 13:06:44 GMT-700 2011, Stephen Haberman wrote: > > > I'd prefer this problem to be addressed in separate CL independent > > from of our effort. > > Here is a comm