[gwt-contrib] New Code Splitter (issue1580803)

2011-10-24 Thread acleung
Reviewers: cromwellian, Description: New Code Splitter Please review this at http://gwt-code-reviews.appspot.com/1580803/ Affected files: A dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter2.java A dev/core/test/com/google/gwt/dev/jjs/impl/CodeSplitter2Test.java -- http://groups.goog

[gwt-contrib] Re: New Code Splitter (issue1580803)

2011-10-24 Thread acleung
On 2011/10/24 08:32:52, acleung wrote: Instead of coding up the whole thing and do a "code dump" review, I decided to clean up the code and let people take a look first. Lots of things are not finished but it is in a state where I can demonstrate the core functions with some unit tests. Thanks.

[gwt-contrib] Fixing a bug in Cell Widgets when using the BOUND_TO_SELECTION KeyboardSelectionPolicy in which ... (issue1578805)

2011-10-24 Thread jlabanca
Reviewers: skybrian, Description: Fixing a bug in Cell Widgets when using the BOUND_TO_SELECTION KeyboardSelectionPolicy in which programmatically deselecting a value makes the value unselectable until the user selects a different value. For example, in the list A, B, C, if you programmatically d

[gwt-contrib] Adding Element#getPreviousSibling(). (issue1581803)

2011-10-24 Thread jlabanca
Reviewers: skybrian, Description: Adding Element#getPreviousSibling(). Issue: 3670 Please review this at http://gwt-code-reviews.appspot.com/1581803/ Affected files: M user/src/com/google/gwt/dom/client/DOMImpl.java M user/src/com/google/gwt/dom/client/Element.java M user/test/com/googl

[gwt-contrib] Re: Fixing a bug in Cell Widgets when using the BOUND_TO_SELECTION KeyboardSelectionPolicy in which ... (issue1578805)

2011-10-24 Thread skybrian
LGTM http://gwt-code-reviews.appspot.com/1578805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding Element#getPreviousSibling(). (issue1581803)

2011-10-24 Thread jlabanca
committed as r10722 http://gwt-code-reviews.appspot.com/1581803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Switch to internal implementation of StringInterner to avoid class loader (issue1578804)

2011-10-24 Thread skybrian
Update: turns out that sharding actually does something. 1 shard: 30 seconds slower than Guava 256 shards: 12 seconds slower 4096 shards: 7 seconds slower (This is with AWFE and no persistent cache.) I could bump up the shards again, but I think instead I'll try ThreadLocal. http://gwt-code-r