[gwt-contrib] Add various docs, minor variable renames (issue1578807)

2011-10-26 Thread stephen . haberman
Reviewers: cromwellian, Message: No functionality changes, just adding docs, usually to explicitly state whether its internal/binary/source names being used, or a few renames to make which internal/etc. names are being used more explicit. Please review this at http://gwt-code-reviews.appspot.c

[gwt-contrib] AdditionalTypeProviderDelegate uses internal names (issue1583803)

2011-10-26 Thread stephen . haberman
Reviewers: cromwellian, Message: This is a small clean up from the less name mangling patch that is just fixing a variable name to be "internalName" instead of "binaryName". I have another patch or two coming that is the same thing; pulling peripheral, no-functionality-changes out of the name ma

[gwt-contrib] Re: Make form event getTypes public. (issue1582803)

2011-10-26 Thread stephen . haberman
http://gwt-code-reviews.appspot.com/1582803/diff/1/user/src/com/google/gwt/user/client/ui/FormPanel.java File user/src/com/google/gwt/user/client/ui/FormPanel.java (left): http://gwt-code-reviews.appspot.com/1582803/diff/1/user/src/com/google/gwt/user/client/ui/FormPanel.java#oldcode98 user/src/

[gwt-contrib] Make form event getTypes public. (issue1582803)

2011-10-26 Thread stephen . haberman
Reviewers: rjrjr, Message: I was writing some stubs for FormPanel and couldn't access the event types from another package. So far all the events I've needed have an accessible getType method, so I think this change is okay. Please review this at http://gwt-code-reviews.appspot.com/1582803/ A

[gwt-contrib] Re: r10697 is back! It was falsely accused last time. Fingers crossed: (issue1578806)

2011-10-26 Thread rdayal
LGTM. http://gwt-code-reviews.appspot.com/1578806/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java File user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java (right): http://gwt-code-reviews.appspot.com/1578806/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBind

[gwt-contrib] Re: r10697 is back! It was falsely accused last time. Fingers crossed: (issue1578806)

2011-10-26 Thread rchandia
http://gwt-code-reviews.appspot.com/1578806/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java File user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java (right): http://gwt-code-reviews.appspot.com/1578806/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderGenera

[gwt-contrib] Re: r10697 is back! It was falsely accused last time. Fingers crossed: (issue1578806)

2011-10-26 Thread rchandia
http://gwt-code-reviews.appspot.com/1578806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Switch to internal implementation of StringInterner to avoid class loader (issue1578804)

2011-10-26 Thread tobyr
LGTM Still not really fond of the manual sharding, but it's hard to argue against fixed without regression. http://gwt-code-reviews.appspot.com/1578804/diff/4004/dev/core/test/com/google/gwt/dev/util/StringInternerTest.java File dev/core/test/com/google/gwt/dev/util/StringInternerTest.java (rig

Re: [gwt-contrib] Re: loading live, instantly-generated data from the server and displaying it as a line graph

2011-10-26 Thread arif
Thank you for the reply! Is there any example/tutorial you could refer to that explains this in more detail? BTW, which users group you were referring to? On Tue, Oct 25, 2011 at 12:07 PM, Jeff Larsen wrote: > This is probably a better discussion for the users group, but I'll answer > it anyway

[gwt-contrib] Announce: GwtQuery 1.1.0

2011-10-26 Thread Manuel Carrasco Moñino
The GQuery team is proud to announce the version 1.1.0 of the library. We have been working hard in order to fix many issues and to achieve a closed jQuery API. The new release includes new features like the jQuery Ajax API, Data binding to easily manage json and xml data, better interaction with

[gwt-contrib] Re: Switch to internal implementation of StringInterner to avoid class loader (issue1578804)

2011-10-26 Thread skybrian
Another possibility is that WeakKeyHashMap's performance varies with size and the performance difference has nothing to do with concurrency - it's just the smaller hash maps are closer to optimal. But anyway, we're speculating, and I'm not inclined to investigate the mystery. At that point I'm pr

[gwt-contrib] Re: Fixing a bug in Cell Widgets when using the BOUND_TO_SELECTION KeyboardSelectionPolicy in which ... (issue1578805)

2011-10-26 Thread jlabanca
committed as r10724 http://gwt-code-reviews.appspot.com/1578805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] r10697 is back! It was falsely accused last time. Fingers crossed: (issue1578806)

2011-10-26 Thread rchandia
Reviewers: rdayal, Description: r10697 is back! It was falsely accused last time. Fingers crossed: *** Original change description *** Change default of UiBinder.useLazyWidgetBuilders to true, in preparation for deleting the old code. Review by: rda...@google.com Please review this at http://