[gwt-contrib] Re: Fix for issue 5952: RequestContext#isChanged. (issue1601806)

2011-12-05 Thread t . broyer
I've applied the same technique to makePayloadOperations to slightly reduce the request payload size (by removing false-positives in property changes), as it's causing issues in our app. It still, IMO, sends too many things in a request (every proxy referenced by another proxy, even if not

[gwt-contrib] Re: Issue 6331: Let AutoBean serialize dates as numbers when possible. (issue1601805)

2011-12-05 Thread rdayal
Brian, can you review this CL? http://gwt-code-reviews.appspot.com/1601805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Adding jscomp to the classpath for gwt user and dev projects. (issue1606803)

2011-12-05 Thread jlabanca
Reviewers: cromwellian, Description: Adding jscomp to the classpath for gwt user and dev projects. Review by: cromwell...@google.com Please review this at http://gwt-code-reviews.appspot.com/1606803/ Affected files: M eclipse/dev/.classpath M eclipse/user/.classpath Index:

[gwt-contrib] Re: Adding jscomp to the classpath for gwt user and dev projects. (issue1606803)

2011-12-05 Thread t . broyer
LGTM In my working copy I also have a .factory and an entry in .classpath for .apt_generated. See http://code.google.com/p/google-web-toolkit/wiki/RequestFactoryInterfaceValidation#Eclipse http://gwt-code-reviews.appspot.com/1606803/ --

[gwt-contrib] Re: Adding jscomp to the classpath for gwt user and dev projects. (issue1606803)

2011-12-05 Thread cromwellian
LGTM. Sorry, as an IntelliJ user, Eclipse often escapes my mind. :) http://gwt-code-reviews.appspot.com/1606803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Issue 6331: Let AutoBean serialize dates as numbers when possible. (issue1601805)

2011-12-05 Thread skybrian
http://gwt-code-reviews.appspot.com/1601805/diff/1/user/src/com/google/web/bindery/autobean/shared/ValueCodex.java File user/src/com/google/web/bindery/autobean/shared/ValueCodex.java (right):

[gwt-contrib] Re: Fix for ScrollImplTrident leak (issue1601803)

2011-12-05 Thread stephen . haberman
http://gwt-code-reviews.appspot.com/1601803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix for ScrollImplTrident leak (issue1601803)

2011-12-05 Thread stephen . haberman
On 2011/12/06 06:11:56, stephenh wrote: This patch uses Thomas's suggestion of static methods with srcElement to avoid holding on to a scrollableElem that comes from outside the event handler's closure. http://gwt-code-reviews.appspot.com/1601803/ --