One general note:
The Uint stuff is one thing of this API I hate very much in the context
of GWT. There are two solutions:
1. use emulated longs, and somehow convert them to real primitive JS
numbers (either using a string, as we did in some places or using
doubles behind the scene)
2. use
On 2012/01/04 19:52:29, jat wrote:
I have only glanced over the files, but I have a general comment. If
possible,
it would be nice if shared code could operate on typed arrays. That
would mean
defining most things in interfaces in shared, and then in the places
that need
it using
On Fri, Jan 6, 2012 at 3:18 PM, steffen.scha...@googlemail.com wrote:
I think extracting interfaces and place them in shared won't be the
problem. I'll do that for the next patch set.
I have some questions about that:
- Where is the best place to implement the factory methods? In a nested
Re. long vs. double, my opinion is: do not deal with long at all in the
API.
I doubt there could ever be a better performing long[]-JsArrayNumber
conversion than iterating through the array and doing a long-double
conversion for each value; so I wouldn't even provide utility methods
(as that
http://gwt-code-reviews.appspot.com/1621803/diff/1/user/src/com/google/gwt/typedarrays/client/DataView.java
File user/src/com/google/gwt/typedarrays/client/DataView.java (right):
I think it is appropriate to keep the correct type on things, as using
it on the server people will be unhappy using double for purely integral
values. So, I think using long for uint32 is correct, but there should
be docs explaining that it is slow and should be avoided in the client,
and also
Try the following modifications to DockLayoutPanel :
Add this somewhere in the class:
AnimationCallback animationCallback = new AnimationCallback () {
@Override
public void onAnimationComplete () {
System.out.println(\r\nAnimation complete!\r\n);
onResize();
}
Reviewers: jlabanca,
Description:
ColumnSortList can grow indefintely, but some users would like to have
only a
limited number of entries within it (usually just one). In such cases it
will
reduce the need to call clear() before push(...), reducing the number of
header
refresh calls. Adding a
LGTM
http://gwt-code-reviews.appspot.com/1625803/diff/1/user/src/com/google/gwt/user/cellview/client/ColumnSortList.java
File user/src/com/google/gwt/user/cellview/client/ColumnSortList.java
(right):
http://gwt-code-reviews.appspot.com/1624803/diff/1/user/src/com/google/gwt/user/client/ui/aria/AttributeValueType.java
File user/src/com/google/gwt/user/client/ui/aria/AttributeValueType.java
(right):
10 matches
Mail list logo
