[gwt-contrib] Re: Call for forgotten patches

2012-03-09 Thread Patrick Tucker
http://code.google.com/p/google-web-toolkit/issues/detail?id=7135 I know I was asked to submit the patch to appspot, I just haven't found the time... On Mar 8, 9:59 pm, Bradley Gottfried brad...@worldviewsoftware.com wrote: http://gwt-code-reviews.appspot.com/1634804/ Thanks, Bradley

[gwt-contrib] Re: Introduced PagerFactory to allow easy swap of pagers for CellBrowser. (issue1659803)

2012-03-09 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/1659803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introduced PagerFactory to allow easy swap of pagers for CellBrowser. (issue1659803)

2012-03-09 Thread t . broyer
http://gwt-code-reviews.appspot.com/1659803/diff/1/user/src/com/google/gwt/user/cellview/client/CellBrowser.java File user/src/com/google/gwt/user/cellview/client/CellBrowser.java (right):

[gwt-contrib] Re: Introduced PagerFactory to allow easy swap of pagers for CellBrowser. (issue1659803)

2012-03-09 Thread jlabanca
http://gwt-code-reviews.appspot.com/1659803/diff/1/user/src/com/google/gwt/user/cellview/client/CellBrowser.java File user/src/com/google/gwt/user/cellview/client/CellBrowser.java (right):

Re: [gwt-contrib] Call for forgotten patches

2012-03-09 Thread Jason Terk
http://gwt-code-reviews.appspot.com/1588803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introduced PagerFactory to allow easy swap of pagers for CellBrowser. (issue1659803)

2012-03-09 Thread jat
http://gwt-code-reviews.appspot.com/1659803/diff/1/user/src/com/google/gwt/user/cellview/client/CellBrowser.java File user/src/com/google/gwt/user/cellview/client/CellBrowser.java (right):

[gwt-contrib] Re: Introduced Builder pattern for CellBrowser creation. (issue1658803)

2012-03-09 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/1658803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Call for forgotten patches

2012-03-09 Thread Jim Douglas
Ray, I didn't submit a formal patch for this, but I noted the trivial fix in the bug report: http://code.google.com/p/google-web-toolkit/issues/detail?id=6704 (Not urgent for me; I worked around this when I tripped over it.) This fix is pending in code review:

[gwt-contrib] Re: Adds extra optimization pass to eliminate more types in draftCompile. This is needed for some li... (issue1599803)

2012-03-09 Thread acleung
LGTM http://gwt-code-reviews.appspot.com/1599803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors