[gwt-contrib] Re: Add Integer.TYPE, etc. (issue1710804)

We will need a new config file for GWT 2.5 I started copy/pasting the config file for 2.4, but it has some comments that I really am not following...Rajeev, could you or someone more familiar with apicheck get it setup for 2.5? I suppose if I tracked down the commit that set it up for 2.4, I

[gwt-contrib] Re: Add Integer.TYPE, etc. (issue1710804)

We will need a new config file for GWT 2.5, I don't know exactly where in the release process that goes, but probably sooner rather than later. http://gwt-code-reviews.appspot.com/1710804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix for issue 5952: RequestContext#isChanged. (issue1601806)

http://gwt-code-reviews.appspot.com/1601806/diff/45014/user/test/com/google/web/bindery/requestfactory/server/SimpleBar.java File user/test/com/google/web/bindery/requestfactory/server/SimpleBar.java (right): http://gwt-code-reviews.appspot.com/1601806/diff/45014/user/test/com/google/web/bindery

[gwt-contrib] Re: Fix for issue 5952: RequestContext#isChanged. (issue1601806)

http://gwt-code-reviews.appspot.com/1601806/diff/45014/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java File user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java (right): http://gwt-code-reviews.appspot.com/1601806/diff/4501

[gwt-contrib] Re: Filter no longer referenced symbols from symbol table. (issue1711804)

http://gwt-code-reviews.appspot.com/1711804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Filter no longer referenced symbols from symbol table. (issue1711804)

Updated. http://gwt-code-reviews.appspot.com/1711804/diff/1/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java (right): http://gwt-code-reviews.appspot.com/1711804/diff/1/dev/core/src/com/google/gwt/dev/jjs/Ja

[gwt-contrib] Re: Added style getters to UiRenderers (issue1700803)

http://gwt-code-reviews.appspot.com/1700803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removing uses of deprecated Tree code in GWT showcase sample and TreeExample. (issue1712804)

LGTM http://gwt-code-reviews.appspot.com/1712804/diff/1/samples/showcase/src/com/google/gwt/sample/showcase/client/content/lists/CwTree.java File samples/showcase/src/com/google/gwt/sample/showcase/client/content/lists/CwTree.java (right): http://gwt-code-reviews.appspot.com/1712804/diff/1/sam

[gwt-contrib] Re: Add Integer.TYPE, etc. (issue1710804)

Can you fix this up? Do you want me to just add something to gwt23_24userApi.conf? I don't see a gwt24_25userApi.conf. Not sure if I should just make a new gwt24_25userApi.conf and I'm good to go or if I need to make new reference jars... http://gwt-code-reviews.appspot.com/1710804/ -- http:/

[gwt-contrib] Re: DefaultProxyStore violated ProxyStore#nextId contract. (issue1622803)

http://gwt-code-reviews.appspot.com/1622803/diff/6001/user/src/com/google/web/bindery/requestfactory/shared/DefaultProxyStore.java File user/src/com/google/web/bindery/requestfactory/shared/DefaultProxyStore.java (right): http://gwt-code-reviews.appspot.com/1622803/diff/6001/user/src/com/google/

[gwt-contrib] Re: Add Integer.TYPE, etc. (issue1710804)

On 2012/05/23 16:20:30, stephenh wrote: Ran this through our battery of tests, and this is the failure that I saw: apicheck-nobuild: [java] Found 38 new resources [java] Found 38 new resources [java] ApiChanges [ [java] com.google.gwt.core.client.impl.CrossSiteIframeLoadingS

[gwt-contrib] Re: Add white-space support to Style (issue1714803)

committed as r10988 http://gwt-code-reviews.appspot.com/1714803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing a Chrome animation bug where animations never stop running. The timestamp that webkitReq... (issue1702803)

LGTM http://gwt-code-reviews.appspot.com/1702803/diff/5001/user/src/com/google/gwt/animation/client/AnimationSchedulerImplMozilla.java File user/src/com/google/gwt/animation/client/AnimationSchedulerImplMozilla.java (right): http://gwt-code-reviews.appspot.com/1702803/diff/5001/user/src/com/goo

[gwt-contrib] Re: Fix for issue 5952: RequestContext#isChanged. (issue1601806)

I'm fine with the production code. This is mostly nitpicks, except that we need to make sure that the code in RequestPayloadTest is actually run. http://gwt-code-reviews.appspot.com/1601806/diff/45014/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java File us

[gwt-contrib] Re: Fixing a Chrome animation bug where animations never stop running. The timestamp that webkitReq... (issue1702803)

Thanks for the heads up Thomas. I've updated the CL to include firefox. http://gwt-code-reviews.appspot.com/1702803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing a Chrome animation bug where animations never stop running. The timestamp that webkitReq... (issue1702803)

http://gwt-code-reviews.appspot.com/1702803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Preparing for an upcoming API change to requestAnimationFrame where browsers will pass a sub-mil... (issue1715803)

Reviewers: rdayal, Description: Preparing for an upcoming API change to requestAnimationFrame where browsers will pass a sub-millisecond timer instead of a Date.now() timestamp. This can cause havoc with animations and has already popped up in the Chrome dev channel (but was reverted). We now ig

[gwt-contrib] Re: Add white-space support to Style (issue1714803)

Looking at it now http://gwt-code-reviews.appspot.com/1714803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] HELP: Generated Javascript contains wrong prototype assignments

> Whenever this happens, the GWT compiler forgets to > insert a prototype assignment which results in ClassCastExceptions. This sounds vaguely like a problem scala-gwt ran into in the scala-ized GWT showcase with classes that were shared across split points. The problem there was with undefined

[gwt-contrib] Re: Using SafeStyles in the ButtonCellBase Templates to avoid the compiler warnings against using St... (issue1707804)

Committed as r10985 http://gwt-code-reviews.appspot.com/1707804/diff/1/user/src/com/google/gwt/cell/client/ButtonCellBase.java File user/src/com/google/gwt/cell/client/ButtonCellBase.java (right): http://gwt-code-reviews.appspot.com/1707804/diff/1/user/src/com/google/gwt/cell/client/ButtonCellB

[gwt-contrib] Re: Add Integer.TYPE, etc. (issue1528806)

Stephen, do you want to open a new issue for this (with a clean patch)? Sure, done: http://gwt-code-reviews.appspot.com/1710804 Closing this one. http://gwt-code-reviews.appspot.com/1528806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Add Integer.TYPE, etc. (issue1710804)

Reviewers: rdayal, Please review this at http://gwt-code-reviews.appspot.com/1710804/ Affected files: M user/super/com/google/gwt/emul/java/lang/Boolean.java M user/super/com/google/gwt/emul/java/lang/Byte.java M user/super/com/google/gwt/emul/java/lang/Double.java M user/super/com/goo

[gwt-contrib] Re: Add Integer.TYPE, etc. (issue1528806)

Stephen, do you want to open a new issue for this (with a clean patch)? http://gwt-code-reviews.appspot.com/1528806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: AbsolutePanel logs IllegalStateException in dev mode (issue1703803)

LGTM. http://gwt-code-reviews.appspot.com/1703803/diff/1/user/src/com/google/gwt/user/client/ui/AbsolutePanel.java File user/src/com/google/gwt/user/client/ui/AbsolutePanel.java (right): http://gwt-code-reviews.appspot.com/1703803/diff/1/user/src/com/google/gwt/user/client/ui/AbsolutePanel.java

[gwt-contrib] Re: Fix for issue 5952: RequestContext#isChanged. (issue1601806)

On 2012/05/23 10:08:59, tbroyer wrote: http://gwt-code-reviews.appspot.com/1601806/diff/40003/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java File user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java (right): http://g

[gwt-contrib] Re: Add white-space support to Style (issue1714803)

LGTM And now we have to find a committer to get this in: John maybe? http://gwt-code-reviews.appspot.com/1714803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] HELP: Generated Javascript contains wrong prototype assignments

Hi, I hope you can give me some advice on the following problem we currently have as I have no idea where to start. In our app we use activities and have used an ActivityProxy (pretty similar to the solution in http://code.google.com/p/google-web-toolkit/issues/detail?id=5129) to code split a

[gwt-contrib] Re: Fix for issue 5952: RequestContext#isChanged. (issue1601806)

http://gwt-code-reviews.appspot.com/1601806/diff/40003/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java File user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java (right): http://gwt-code-reviews.appspot.com/1601806/diff/4000

[gwt-contrib] Re: Fixing a Chrome animation bug where animations never stop running. The timestamp that webkitReq... (issue1702803)

Looks like we should re-open this CL: http://updates.html5rocks.com/2012/05/requestAnimationFrame-API-now-with-sub-millisecond-precision We might also want to revisit the Mozilla implementation with a similar change to make sure it won't break in a future version of Firefox. (and also note that,