[gwt-contrib] Re: Fix issue 6959. (issue1587803)

2012-05-24 Thread t . broyer
Ping http://gwt-code-reviews.appspot.com/1587803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Generated EditorContext class names take actual parameterization into account. (issue1352806)

2012-05-24 Thread t . broyer
Ping http://gwt-code-reviews.appspot.com/1352806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Addresses a couple of my concerns re. RF validation. (issue1577806)

2012-05-24 Thread t . broyer
Ping (sorry for the spam, these are important issues that we should really try to fix in 2.5, so I'm just making sure they're not forgotten) http://gwt-code-reviews.appspot.com/1577806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] HELP: Generated Javascript contains wrong prototype assignments

2012-05-24 Thread Jens
Can you apply this patch to a local GWT trunk build and see if it helps: http://gwt-code-reviews.appspot.com/1513803/ Using trunk with your patch does not solve the issue. In the first split point the code _ = CustomPlace_2.prototype = CustomPlace_0.prototype = CustomPlace.prototype =

[gwt-contrib] Re: Fixing a Chrome animation bug where animations never stop running. The timestamp that webkitReq... (issue1702803)

2012-05-24 Thread jlabanca
committed as r10989 http://gwt-code-reviews.appspot.com/1702803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removing uses of deprecated Tree code in GWT showcase sample and TreeExample. (issue1712804)

2012-05-24 Thread jlabanca
http://gwt-code-reviews.appspot.com/1712804/diff/1/samples/showcase/src/com/google/gwt/sample/showcase/client/content/lists/CwTree.java File samples/showcase/src/com/google/gwt/sample/showcase/client/content/lists/CwTree.java (right):

[gwt-contrib] Re: Added style getters to UiRenderers (issue1700803)

2012-05-24 Thread rchandia
http://gwt-code-reviews.appspot.com/1700803/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (right):

[gwt-contrib] Re: Add Integer.TYPE, etc. (issue1710804)

2012-05-24 Thread stephen . haberman
I suppose if I tracked down the commit that set it up for 2.4, I could just change whatever it changed...I'll look in to that. It seems like this shouldn't be too hard, but after making a new gwt24_25 conf file and creating new reference jars from gwt 2.4, I'm getting this error:

[gwt-contrib] Re: Removing uses of deprecated Tree code in GWT showcase sample and TreeExample. (issue1712804)

2012-05-24 Thread jlabanca
committed as r10991 http://gwt-code-reviews.appspot.com/1712804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Resubmitting code review 1660804 (issue1716803)

2012-05-24 Thread rchandia
Reviewers: rdayal, Description: Resubmitting code review 1660804 Allow absolute paths in ui:style's src= Thanks Thomas! Fixes issue: 7230 Review by: rda...@google.com Please review this at http://gwt-code-reviews.appspot.com/1716803/ Affected files: M

[gwt-contrib] Re: Issue 7230: allow absolute paths in ui:style's src= (issue1660804)

2012-05-24 Thread rchandia
Reposting for internal resubmission at: http://gwt-code-reviews.appspot.com/1716803 http://gwt-code-reviews.appspot.com/1660804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Resubmission of Issue 1686803 (issue1717803)

2012-05-24 Thread rchandia
Reviewers: rdayal, Description: Resubmission of Issue 1686803 Add text-align support to Style Thanks Patrick! Please review this at http://gwt-code-reviews.appspot.com/1717803/ Affected files: M user/src/com/google/gwt/dom/client/Style.java M

[gwt-contrib] HorizontalSplitPanel should use ScheduledCommand instead of Command (issue1718803)

2012-05-24 Thread rchandia
Reviewers: rdayal, Description: HorizontalSplitPanel should use ScheduledCommand instead of Command Resubmitting issue 1694803 Thanks Patrick! Please review this at http://gwt-code-reviews.appspot.com/1718803/ Affected files: M

[gwt-contrib] Re: HorizontalSplitPanel should use ScheduledCommand instead of Command (issue1694803)

2012-05-24 Thread rchandia
LGTM Reposting internally at: http://gwt-code-reviews.appspot.com/1718803 http://gwt-code-reviews.appspot.com/1694803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: SplitLayoutPanel should use ScheduledCommand instead of Command (issue1695803)

2012-05-24 Thread rchandia
Submitted as r10957 http://gwt-code-reviews.appspot.com/1695803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] DateBox should use ScheduledCommand instead of Command (issue1719803)

2012-05-24 Thread rchandia
Reviewers: rdayal, Description: DateBox should use ScheduledCommand instead of Command Resubmission of issue 1695804 Thanks Patrick! Please review this at http://gwt-code-reviews.appspot.com/1719803/ Affected files: M user/src/com/google/gwt/user/datepicker/client/DateBox.java Index:

[gwt-contrib] Re: DateBox should use ScheduledCommand instead of Command (issue1695804)

2012-05-24 Thread rchandia
LGTM Reposting at http://gwt-code-reviews.appspot.com/1719803 http://gwt-code-reviews.appspot.com/1695804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Issue 7038: CompositeEditor and ListEditor optimizations (issue1664803)

2012-05-24 Thread Brian Slesinsky
On Sat, May 19, 2012 at 9:16 AM, Thomas Broyer t.bro...@gmail.com wrote: So I agree that is seems logical that a live view would only last until the next flush() or at most until the next setValue(). But this isn't well-documented in this class or anywhere else that I've found so far. To

[gwt-contrib] Add HasEnabled to FileUpload. (issue1614808)

2012-05-24 Thread tuckerpmt
LGTM http://gwt-code-reviews.appspot.com/1614808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Add clear support to Style (issue1720803)

2012-05-24 Thread tuckerpmt
Reviewers: , Description: Style does not have a getter, setter or clear function for the 'clear' CSS property. Please review this at http://gwt-code-reviews.appspot.com/1720803/ Affected files: user/src/com/google/gwt/dom/client/Style.java