[gwt-contrib] Re: Fix for issue 5952: RequestContext#isChanged. (issue1601806)

http://gwt-code-reviews.appspot.com/1601806/diff/45014/user/test/com/google/web/bindery/requestfactory/server/SimpleBar.java File user/test/com/google/web/bindery/requestfactory/server/SimpleBar.java (right): http://gwt-code-reviews.appspot.com/1601806/diff/45014/user/test/com/google/web/bindery

[gwt-contrib] Re: ExternalTextResourceGenerator is locale/machine-dependent. (issue1716804)

LGTM https://gwt-code-reviews.appspot.com/1716804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Issue 7038: CompositeEditor and ListEditor optimizations (issue1664803)

On 2012/05/25 17:58:21, skybrian wrote: In getEditors: "The returned list will be live until the next call to setValue() and shouldn't be used after that." [...] Yeah, #3 is out. Option #2 would make sense if we expected that complaining early means that most people would fix the problem bef

[gwt-contrib] ExternalTextResourceGenerator is locale/machine-dependent. (issue1716804)

Reviewers: , Message: Looking for a reviewer on this. Note there are other uses of getBytes() without a specified encoding: - in XsrfProtectedServiceServlet and XsrfTokenServiceServlet (though it's not that important, as it's about creating and validating a token; it could be an issue onl

[gwt-contrib] Re: Fix for issue 5952: RequestContext#isChanged. (issue1601806)

On 2012/05/25 21:43:28, sjostrand.jonas wrote: When a proxy is edit()ed not only sub ENTITY proxies but also sub VALUE proxies are automatically edit()ed and considered as changed by the auto bean diff. Can this be fixed by the same technique? I tried the patch and it didn't solve the probl

[gwt-contrib] Re: HorizontalSplitPanel should use ScheduledCommand instead of Command (issue1718803)

On 2012/05/25 21:16:45, rchandia wrote: Submitted as r10996 http://gwt-code-reviews.appspot.com/1718803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: HorizontalSplitPanel should use ScheduledCommand instead of Command (issue1694803)

On 2012/05/24 20:25:26, rchandia wrote: LGTM Reposting internally at: http://gwt-code-reviews.appspot.com/1718803 Submitted as r10996 http://gwt-code-reviews.appspot.com/1694803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: HorizontalSplitPanel should use ScheduledCommand instead of Command (issue1718803)

http://gwt-code-reviews.appspot.com/1718803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add Map support to RequestFactory (issue 6132056)

AutoBean has no equivalent to these "partial loading"; just like a POJO has no notion of lazy loading, compared to JPA entities. Le 25 mai 2012 21:06, "James Horsley" a écrit : > I read Alexis's email too hastily and hadn't noted he was asking about > nested complex types. I'll add some tests to

[gwt-contrib] Re: Resubmission of Issue 1686803 (issue1717803)

Submitter as r10995 http://gwt-code-reviews.appspot.com/1717803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Issue 7230: allow absolute paths in ui:style's src="" (issue1660804)

On 2012/05/24 18:07:45, rchandia wrote: Reposting for internal resubmission at: http://gwt-code-reviews.appspot.com/1716803 Submitted as r10994 http://gwt-code-reviews.appspot.com/1660804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Resubmitting code review 1660804 (issue1716803)

On 2012/05/24 18:06:50, rchandia wrote: Submitted as r10994 http://gwt-code-reviews.appspot.com/1716803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Generated EditorContext class names take actual parameterization into account. (issue1352806)

LGTM. (Some optional nitpicks.) It seems a little odd that you'd want to do this. I'd expect that the subtype (Manager or Intern) would have additional fields to edit, so you wouldn't be able to just reuse the editor for the parent type. But it should still be allowed. http://gwt-code-reviews.

[gwt-contrib] Re: Add Map support to RequestFactory (issue 6132056)

I read Alexis's email too hastily and hadn't noted he was asking about nested complex types. I'll add some tests to see how it behaves. I'll be interested to dig into what AutoBean's behaviour is here as that's what I based on, mimicked, and leveraged for this patch. On 25 May 2012 19:38, wrote:

[gwt-contrib] Re: Add Map support to RequestFactory (issue 6132056)

On 2012/05/25 17:09:32, james.horsley wrote: I added tests for complex keys and complex values which're passing so it should do yes. I don't see any change to addPathsToResolution... Also, how would it work? Say I have a Map, A has a reference "c" to a proxy C, and B has a reference "d" to a

[gwt-contrib] Re: Issue 7038: CompositeEditor and ListEditor optimizations (issue1664803)

On Fri, May 25, 2012 at 1:43 AM, Thomas Broyer wrote: > I think the expected use of getEditors() is that users don't keep an > handle on it. > Even if they, if they call getEditors() after each setValue(), then it > doesn't really matter whether the returned value will be the same > instance or a

[gwt-contrib] Re: Add Map support to RequestFactory (issue 6132056)

I added tests for complex keys and complex values which're passing so it should do yes. On 25 May 2012 17:01, wrote: > Hello > With your patch, does the function .with() works for a map for example > in an entity: > > Map(String,ServiceParam) params; > > requestContext.find(id).with("**params.Se

Re: [gwt-contrib] HELP: Generated Javascript contains wrong prototype assignments

Boy will this be a hard one to fix without a stable repro case. I hope you keep around a repeatable broken build. The code responsible for generating prototype assignments is here, you can see: http://code.google.com/p/google-web-toolkit/source/browse/trunk/dev/core/src/com/google/gwt/dev/jjs/impl

Re: [gwt-contrib] HELP: Generated Javascript contains wrong prototype assignments

Hehe yeah its pretty hard to reproduce it in a new project. Even in our app branch for that issue I have to delete things out very carefully. As soon as I delete too much or something wrong, the ClassCastException disappears because split points are generated slightly different or GWT optimizes

Re: [gwt-contrib] HELP: Generated Javascript contains wrong prototype assignments

> Using trunk with your patch does not solve the issue. Well, shoot. I've tried to recreate your issue and am not having any luck. I modified the Hello sample to have a few run asyncs, and put different constructor calls to the same class in each one, but it's working annoyingly well. I can get

[gwt-contrib] Re: Resubmission of Issue 1686803 (issue1717803)

http://gwt-code-reviews.appspot.com/1717803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Contributor License Agreements question

Confirmation email forwarded. Thanks, Alexandre 2012/5/25 Rajeev Dayal > Hey Alexandre, > > You're not able to verify that you signed the CLA in the corporate case. I > looked at our corporate CLA list, and I don't see your name (or that of > your company) listed there. > > I'll do some more di

Re: [gwt-contrib] Contributor License Agreements question

Hey Alexandre, You're not able to verify that you signed the CLA in the corporate case. I looked at our corporate CLA list, and I don't see your name (or that of your company) listed there. I'll do some more digging to see what happened. Did you receive any sort of confirmation e-mail? If so, cou

Re: [gwt-contrib] Re: Contributor License Agreements question

2012/5/25 Thomas Broyer > On Friday, May 25, 2012 2:55:21 PM UTC+2, Alexandre Ardhuin wrote: >> >> I don't see the review made by Thomas in this contributors group and I >> wonder why. >> > > Ah, you didn't CC > google-web-toolkit-contributors@googlegroups.com.

[gwt-contrib] Re: Contributor License Agreements question

On Friday, May 25, 2012 2:55:21 PM UTC+2, Alexandre Ardhuin wrote: > > I don't see the review made by Thomas in this contributors group and I > wonder why. > Ah, you didn't CC google-web-toolkit-contributors@googlegroups.com. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Contributor License Agreements question

Hi all, A few days ago I submitted a patch ( http://gwt-code-reviews.appspot.com/1712803/ ) after having followed the steps described at https://developers.google.com/web-toolkit/makinggwtbetter#submittingpatches. My CTO had signed the "Corporate Contributor License Agreement" ( http://code.google

[gwt-contrib] Re: Issue 7038: CompositeEditor and ListEditor optimizations (issue1664803)

On Fri, May 25, 2012 at 12:48 AM, Brian Slesinsky wrote: > On Sat, May 19, 2012 at 9:16 AM, Thomas Broyer wrote: >> >>> So I agree that is >>> seems logical that a "live" view would only last until the next >>> flush() or at most until the next setValue(). But this isn't >>> well-documented in th