http://gwt-code-reviews.appspot.com/1727808/diff/8001/build.xml
File build.xml (right):
http://gwt-code-reviews.appspot.com/1727808/diff/8001/build.xml#newcode41
build.xml:41:
On 2012/06/15 00:34:59, skybrian wrote:
I asked Ray about this. Elemental is experimental and its build
process is
r
Reviewers: cromwellian, skybrian,
Message:
Another dependency packaging issue.
Description:
Issue 7428: include the StreamHtmlParser within gwt-servlet.jar
Also moves from gwt-dev.jar to gwt-user.jar, where it should have always
been.
Please review this at https://gwt-code-reviews.appspot.com
LGTM
http://gwt-code-reviews.appspot.com/1742803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2012/06/15 02:39:33, skybrian wrote:
I verified that the ant build and google builds both work. The ant
build takes
about 9 minutes with this change, versus about 5:30 before. Also,
elemental gets
a full rebuild each time so a no-op build now takes about 4:30.
Thanks for checking this ou
https://gwt-code-reviews.appspot.com/1727808/diff/16001/distro-source/build.xml
File distro-source/build.xml (right):
https://gwt-code-reviews.appspot.com/1727808/diff/16001/distro-source/build.xml#newcode39
distro-source/build.xml:39:
Will this cause the build to fail if gwt-elemental.jar is n
On 2012/06/15 15:32:26, rdayal wrote:
On 2012/06/15 02:39:33, skybrian wrote:
> I verified that the ant build and google builds both work. The ant
build takes
> about 9 minutes with this change, versus about 5:30 before. Also,
elemental
gets
> a full rebuild each time so a no-op build now tak
https://gwt-code-reviews.appspot.com/1727808/diff/16001/distro-source/build.xml
File distro-source/build.xml (right):
https://gwt-code-reviews.appspot.com/1727808/diff/16001/distro-source/build.xml#newcode39
distro-source/build.xml:39:
On 2012/06/15 15:39:27, rdayal wrote:
Will this cause the
On 2012/06/15 15:56:08, tbroyer wrote:
https://gwt-code-reviews.appspot.com/1727808/diff/16001/distro-source/build.xml
File distro-source/build.xml (right):
https://gwt-code-reviews.appspot.com/1727808/diff/16001/distro-source/build.xml#newcode39
distro-source/build.xml:39:
/>
On 2012/06/1
Reviewers: rdayal,
Description:
Make RfValidator Java7 Compat.
Please review this at http://gwt-code-reviews.appspot.com/1743803/
Affected files:
M user/src/com/google/web/bindery/requestfactory/apt/RfValidator.java
M user/test/com/google/web/bindery/requestfactory/apt/ExpectCollector.java
Hey Thomas, Rajeev told me that you are understood lots of the request
factory code.
I am trying to fix the follow error in Java7:
junit.framework.AssertionFailedError: Did not see expected errors:
[warning: Supported source version 'RELEASE_6' from annotation processor
'com.google.web.bindery.r
LGTM.
This reminds me that when we start doing JDK7 builds of GWT, we should
set -target 1.6, so that GWT can still run on JDK 1.6.
http://gwt-code-reviews.appspot.com/1743803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM. I commented on some issues to fix in later patches.
http://gwt-code-reviews.appspot.com/1727808/diff/16001/distro-source/build.xml
File distro-source/build.xml (right):
http://gwt-code-reviews.appspot.com/1727808/diff/16001/distro-source/build.xml#newcode39
distro-source/build.xml:39:
I
Post 2.5 we can fix the no op build, the shell script needs to be axed
in favor of separate tasks, because
1) elemental_freemontcutbuilder only depends on third_party/WebCore,
elemental.idl, and the direct idl* and database.py files. It produces
a python pickle cache as output
2) elementaldomgener
BTW, the internal genrule seems to work properly and not rebuild everytime
On Fri, Jun 15, 2012 at 12:24 PM, Ray Cromwell wrote:
> Post 2.5 we can fix the no op build, the shell script needs to be axed
> in favor of separate tasks, because
>
> 1) elemental_freemontcutbuilder only depends on thir
LGTM
http://gwt-code-reviews.appspot.com/1743803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1731806/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/EnumOrdinalizerTest.java
File dev/core/test/com/google/gwt/dev/jjs/impl/EnumOrdinalizerTest.java
(right):
http://gwt-code-reviews.appspot.com/1731806/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/Enum
Reviewers: rdayal,
Description:
Missed file for -XfragmentCount
Please review this at http://gwt-code-reviews.appspot.com/1743804/
Affected files:
M dev/core/src/com/google/gwt/dev/PrecompileTaskArgProcessor.java
Index: dev/core/src/com/google/gwt/dev/PrecompileTaskArgProcessor.java
==
LGTM. It looks like this was already fixed for the google build, so it's
purely an open source change.
https://gwt-code-reviews.appspot.com/1741803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: skybrian,
Description:
Make CoverageTest less dependent on execution order.
Please review this at http://gwt-code-reviews.appspot.com/1741804/
Affected files:
M user/test/com/google/gwt/dev/jjs/test/CoverageTest.java
Index: user/test/com/google/gwt/dev/jjs/test/CoverageTest.java
Looks good as far as it goes.
http://gwt-code-reviews.appspot.com/1741804/diff/1/user/test/com/google/gwt/dev/jjs/test/CoverageTest.java
File user/test/com/google/gwt/dev/jjs/test/CoverageTest.java (right):
http://gwt-code-reviews.appspot.com/1741804/diff/1/user/test/com/google/gwt/dev/jjs/test
LGTM.
http://gwt-code-reviews.appspot.com/1743804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
21 matches
Mail list logo
