[gwt-contrib] Re: Fixed scrollbar width calculation. In Chrome, for a scrollbar styled (issue1756803)

2012-06-21 Thread ehwang
Checkstyle error: user/src/com/google/gwt/user/client/ui/AbstractNativeScrollbar.java:23.8 -- Unused import - com.google.gwt.dom.client.Style.Visibility. http://gwt-code-reviews.appspot.com/1756803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix unicode escaping in JSON Util. (issue1754803)

2012-06-21 Thread skybrian
On 2012/06/21 19:58:13, acleung wrote: LGTM. Could you also create a GWT Issue? http://gwt-code-reviews.appspot.com/1754803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix unicode escaping in JSON Util. (issue1754803)

2012-06-21 Thread jat
LGTM http://gwt-code-reviews.appspot.com/1754803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fix unicode escaping in JSON Util. (issue1754803)

2012-06-21 Thread acleung
Reviewers: skybrian, Description: Fix unicode escaping in JSON Util. Please review this at http://gwt-code-reviews.appspot.com/1754803/ Affected files: M user/src/com/google/gwt/core/client/JsonUtils.java Index: user/src/com/google/gwt/core/client/JsonUtils.java ===

[gwt-contrib] Re: Add compilation progress logging, visible in dev mode when log level set to TRACE. This is helpf... (issue1749803)

2012-06-21 Thread skybrian
Seems fine in principle. What does this look like in context, when there are also compile warnings or errors? It might be nice to log the total compilation time as well. http://gwt-code-reviews.appspot.com/1749803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update to 1.6 for javac source/target. (issue1753803)

2012-06-21 Thread Rajeev Dayal
Oh shoot, fat-fingered - I'm sorry about that! On Thu, Jun 21, 2012 at 11:12 AM, Thomas Broyer wrote: > > > On Thursday, June 21, 2012 4:46:36 PM UTC+2, rdayal wrote: >> >> Reviewers: jat, t.broyer_google.com, > > > Ah ah! > People please do not read anything in Rajeev's mistake above ;-) > Ther

[gwt-contrib] Re: Update to 1.6 for javac source/target. (issue1753803)

2012-06-21 Thread t . broyer
LGTM http://gwt-code-reviews.appspot.com/1753803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update to 1.6 for javac source/target. (issue1753803)

2012-06-21 Thread Thomas Broyer
On Thursday, June 21, 2012 4:46:36 PM UTC+2, rdayal wrote: > > Reviewers: jat, t.broyer_google.com, Ah ah! People please do not read anything in Rajeev's mistake above ;-) There's no current plan that I work at Google in the near future. -- http://groups.google.com/group/Google-Web-Toolkit-C

[gwt-contrib] Re: Update to 1.6 for javac source/target. (issue1753803)

2012-06-21 Thread jat
LGTM http://gwt-code-reviews.appspot.com/1753803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Update to 1.6 for javac source/target. (issue1753803)

2012-06-21 Thread rdayal
Reviewers: jat, t.broyer_google.com, Description: Update to 1.6 for javac source/target. Please review this at http://gwt-code-reviews.appspot.com/1753803/ Affected files: M common.ant.xml Index: common.ant.xml === --- common.