[gwt-contrib] Re: Fix JSON escaping of unicode characters to work in JDK 7. (issue1796803)

2012-07-26 Thread t . broyer
I'm not against this kind of change but IMO any deviation from the JSON and/or ECMAScript specs should be documented, or we risk removing them at a later time and break things again (that being said, I don't understand what's broken here and how this CL fixes it wrt JDK 7, as all I see is

[gwt-contrib] A couple of little fixes to get nicer coverage results. (issue1797803)

2012-07-26 Thread isbadawi
Reviewers: cromwellian, skybrian, Description: A couple of little fixes to get nicer coverage results. Please review this at http://gwt-code-reviews.appspot.com/1797803/ Affected files: M dev/core/src/com/google/gwt/dev/js/BaselineCoverageGatherer.java Index:

[gwt-contrib] I need your support : Chrome keeps asking to kill the page when debuging

2012-07-26 Thread ALAA MURAD
Dear All, Could you please star this bug http://code.google.com/p/google-web-toolkit/issues/detail?id=5830 So Google can fix it I'm GWT Mobile Developer Chrome is the best for development for those platforms, however the annoying pop-up window that keeps asking me to kill the debug session is

[gwt-contrib] Re: A couple of little fixes to get nicer coverage results. (issue1797803)

2012-07-26 Thread skybrian
LGTM http://gwt-code-reviews.appspot.com/1797803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix JSON escaping of unicode characters to work in JDK 7. (issue1796803)

2012-07-26 Thread skybrian
On 2012/07/26 07:02:08, tbroyer wrote: I'm not against this kind of change but IMO any deviation from the JSON and/or ECMAScript specs should be documented, or we risk removing them at a later time and break things again (that being said, I don't understand what's broken here and how this

Re: [gwt-contrib] I need your support : Chrome keeps asking to kill the page when debuging

2012-07-26 Thread John A. Tamplin
On Thu, Jul 26, 2012 at 12:56 PM, ALAA MURAD alaamu...@gmail.com wrote: Could you please star this bug http://code.google.com/p/google-web-toolkit/issues/detail?id=5830 So Google can fix it I'm GWT Mobile Developer Chrome is the best for development for those platforms, however the

[gwt-contrib] Re: A couple of little fixes to get nicer coverage results. (issue1797803)

2012-07-26 Thread cromwellian
http://gwt-code-reviews.appspot.com/1797803/diff/1/dev/core/src/com/google/gwt/dev/js/BaselineCoverageGatherer.java File dev/core/src/com/google/gwt/dev/js/BaselineCoverageGatherer.java (right):

[gwt-contrib] Re: A couple of little fixes to get nicer coverage results. (issue1797803)

2012-07-26 Thread isbadawi
On 2012/07/26 22:06:10, cromwellian wrote: http://gwt-code-reviews.appspot.com/1797803/diff/1/dev/core/src/com/google/gwt/dev/js/BaselineCoverageGatherer.java File dev/core/src/com/google/gwt/dev/js/BaselineCoverageGatherer.java (right):

[gwt-contrib] Re: Added Aria roles and properties to the CellTree (issue1776803)

2012-07-26 Thread skybrian
Thanks, that's gotten me reading the right code; before I couldn't even find the SelectionChangeListener and now I see that it's in HasDataPresenter. So for this CL, I think we just assume rendering happens when it needs to and update aria-selected (and other attributes) whenever a node gets

[gwt-contrib] Fix UiSuite to pass when test methods are run in a different order. (issue1795804)

2012-07-26 Thread skybrian
Reviewers: cromwellian, Description: Fix UiSuite to pass when test methods are run in a different order. The symptom was that many tests would fail, starting with RootPanelTest.testGetById(). I don't know the root cause, but it seems that leaving a RichTextArea with focus in the RootPanel

Re: [gwt-contrib] I need your support : Chrome keeps asking to kill the page when debuging

2012-07-26 Thread ALAA MURAD
John, I understand the risk of letting plug-in control this, however, a user should be in control and I see those solutions : 1- Chrome let you add to a white-list urls so it can ignore . 2- GWT plugin can keep sending response message to Chrome in another thread (Not sure if that is possible ).

Re: [gwt-contrib] I need your support : Chrome keeps asking to kill the page when debuging

2012-07-26 Thread John A. Tamplin
On Thu, Jul 26, 2012 at 4:48 PM, ALAA MURAD alaamu...@gmail.com wrote: I understand the risk of letting plug-in control this, however, a user should be in control and I see those solutions : 1- Chrome let you add to a white-list urls so it can ignore . 2- GWT plugin can keep sending response

Re: [gwt-contrib] I need your support : Chrome keeps asking to kill the page when debuging

2012-07-26 Thread Thomas Broyer
On Thursday, July 26, 2012 11:08:00 PM UTC+2, John A. Tamplin wrote: On Thu, Jul 26, 2012 at 12:56 PM, ALAA MURAD alaamu...@gmail.com wrote: Could you please star this bug http://code.google.com/p/google-web-toolkit/issues/detail?id=5830 So Google can fix it I'm GWT Mobile Developer