On 2012/08/08 22:25:10, skybrian wrote:
Any reason clear() can't be moved into SelectionModel and not make
SingleSelectionModel implement SetSelectionModel? It seems misleading
to make SingleSelectionModel extend SetSelectionModel when it only deals
with one element.
http://gwt-code-reviews.app
minor nit.
LGTM
http://gwt-code-reviews.appspot.com/1807803/diff/1/user/src/com/google/gwt/validation/client/impl/BaseGwtConfiguration.java
File
user/src/com/google/gwt/validation/client/impl/BaseGwtConfiguration.java
(right):
http://gwt-code-reviews.appspot.com/1807803/diff/1/user/src/com/goog
On 2012/08/09 16:17:26, rkj wrote:
Understandable, seems like an extension of SingleSelectionModel to fit
your specific case would make the most sense here?
http://gwt-code-reviews.appspot.com/1798806/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
The idea is that any SingleSelectionModel can be thought of as a set
that contains either zero or one items. So it seems appropriate that it
should have the new methods - and after all, the whole point is to be
able to treat them uniformly.
SetSelectionModel isn't intended to imply that the Selec
http://gwt-code-reviews.appspot.com/1806803/diff/1/samples/mobilewebapp/pom.xml
File samples/mobilewebapp/pom.xml (right):
http://gwt-code-reviews.appspot.com/1806803/diff/1/samples/mobilewebapp/pom.xml#newcode183
samples/mobilewebapp/pom.xml:183: 1.6
Change tabs to spaces
http://gwt-code-revie
If you implement login and logout link in a JSP, you can remove all the
user service wrapper stuff.
http://gwt-code-reviews.appspot.com/1806803/diff/1/samples/mobilewebapp/src/main/java/com/google/gwt/sample/gaerequest/server/GaeAuthFilter.java
File
samples/mobilewebapp/src/main/java/com/google/
Reviewers: Nick Chalko, cromwellian,
Description:
Changed package structure with the intention of keeping the "client"
package clean of all classes which the user should not see
(implementation-specific).
[JSR 303 TCK Result] 191 of 204 (93.63%) Pass with 12 Failures and 0
Errors.
Please revie
lgtm
http://gwt-code-reviews.appspot.com/1807804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
