[gwt-contrib] Force returning integer pixel values from DOMImplWebkit (#6130) (issue1797805)

2012-08-16 Thread t . broyer
absoluteTop/Left are not enough: http://code.google.com/p/google-web-toolkit/issues/detail?id=7575 And WebKit is probably not enough too (subpixel rendering is becoming standard, and will soon be mainstream). http://gwt-code-reviews.appspot.com/1797805/ --

[gwt-contrib] Add setComparator to allow custom sorting of candidates from search. (issue1807805)

2012-08-16 Thread dvik
Reviewers: reviewers_userid_google.com, Description: Add setComparator to allow custom sorting of candidates from search. Fixes issues 4373, 5920 Review by: skybr...@google.com Please review this at http://gwt-code-reviews.appspot.com/1807805/ Affected files: M

[gwt-contrib] Removed EXPERIMENTAL flag from GWT validation. Cleaned up all JavaDoc comments to reflect this c... (issue1811803)

2012-08-16 Thread idol
Reviewers: Nick Chalko, cromwellian, Description: Removed EXPERIMENTAL flag from GWT validation. Cleaned up all JavaDoc comments to reflect this change. Please review this at http://gwt-code-reviews.appspot.com/1811803/ Affected files: M

[gwt-contrib] Re: Removed EXPERIMENTAL flag from GWT validation. Cleaned up all JavaDoc comments to reflect this c... (issue1811803)

2012-08-16 Thread nchalko
lgtm http://gwt-code-reviews.appspot.com/1811803/diff/1/user/src/com/google/gwt/validation/client/GwtValidation.java File user/src/com/google/gwt/validation/client/GwtValidation.java (right):

[gwt-contrib] Re: Move GAE Auth functionality from Expenses over the MobileWebApp sample. (issue1806803)

2012-08-16 Thread t . broyer
FYI, my take on authentication and RequestFactory can be found at https://github.com/tbroyer/gwt-maven-archetypes/tree/master/guice-rf-activities (also uses Guice, GIN and Guava). I'm in the process of trading the userName and isAdmin JS variables for an object (managing ser/deserialization with