Are there tests that could be added / updated?
http://gwt-code-reviews.appspot.com/1815803/diff/1/src/com/google/gwt/dom/client/DOMImpl.java
File src/com/google/gwt/dom/client/DOMImpl.java (right):
Reviewers: acleung,
Description:
Got the development mode plugin to compile for Firefox 15 using
xulrunner-15.0b6 on 64-bit Linux.
(This is not ready to commit yet, since it's not tested, but here's a
preview.)
Please review this at http://gwt-code-reviews.appspot.com/1816803/
Affected
LGTM after testing. Suggest changing how JSVAL_IS_OBJECT is handled,
but I don't feel strongly about it.
http://gwt-code-reviews.appspot.com/1816803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thanks! In that case, I'll commit this and follow up in another CL if
needed.
http://gwt-code-reviews.appspot.com/1816803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Sorry, didn't notice my draft comment wasn't included in the reply
before.
http://gwt-code-reviews.appspot.com/1816803/diff/1/plugins/xpcom/FFSessionHandler.cpp
File plugins/xpcom/FFSessionHandler.cpp (right):
lgtm
http://gwt-code-reviews.appspot.com/1816803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2012/08/24 20:41:13, jtamplin wrote:
#ifndef JSVAL_IS_OBJECT
#define JSVAL_IS_OBJECT(x) (!JSVAL_IS_PRIMITIVE(x))
#endif
They're actually subtly different because the removed JSVAL_IS_OBJECT
would return true for a null, and so does JSVAL_IS_PRIMITIVE. However, I
didn't see any code that
Strangely, this isn't working for me. The plugin seems to install and I
can bring up preferences, but the __gwt_HostedModePlugin javascript
variable doesn't show up, so it goes to the missing plugin page. Any
ideas?
Firefox version:
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:15.0) Gecko/20100101
Turns out I needed to update chrome.manifest. After fixing this, I'm
getting an error on reloading the page. I'm surprised it was working for
jat, unless that was with Firefox 14.
Connect(url=http://localhost:8080/Showcase.html?gwt.codesvr=xx.xx.xx.xx:9997#!CwCheckBox,
sessionKey=XXX,
On Fri, Aug 24, 2012 at 9:16 PM, skybr...@google.com wrote:
Turns out I needed to update chrome.manifest. After fixing this, I'm
getting an error on reloading the page. I'm surprised it was working for
jat, unless that was with Firefox 14.
I have not tested it on FF in several months, don't
Aha, I misunderstood LGTM after testing.
On Fri, Aug 24, 2012 at 6:35 PM, John A. Tamplin j...@jaet.org wrote:
I have not tested it on FF in several months, don't know what version it
was.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: acleung,
Description:
Fix development mode Firefox plugin to work on with Firefox 15 on Linux.
Tested with 64-bit linux. Now builds 32-bit Linux for 15, but that's not
tested yet.
Please review this at http://gwt-code-reviews.appspot.com/1817803/
Affected files:
M
On Aug 24, 2012 9:38 PM, Brian Slesinsky skybr...@google.com wrote:
Aha, I misunderstood LGTM after testing.
Sorry, I meant LGTM after you had tested it :-)
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
13 matches
Mail list logo
